* [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
@ 2017-10-27 22:32 Michel Thierry
2017-10-27 23:06 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (5 more replies)
0 siblings, 6 replies; 8+ messages in thread
From: Michel Thierry @ 2017-10-27 22:32 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
There is no need check if PPGTT is disabled because that not possible
in CNL. Execlists and GuC submission modes rely on at least aliasing
PPGTT and even intel_sanitize_enable_ppgtt says: "We don't allow disabling
PPGTT for gen9+ as it's a requirement for execlists, the sole mechanism
available to submit work."
Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Michel Thierry <michel.thierry@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 7ebfc8ee479e..302ffe0cf3c7 100644
--- a/drivers/gpu/drm/i915/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
@@ -3206,12 +3206,6 @@ static void cnl_setup_private_ppat(struct intel_ppat *ppat)
ppat->match = bdw_private_pat_match;
ppat->clear_value = GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(3);
- /* XXX: spec is unclear if this is still needed for CNL+ */
- if (!USES_PPGTT(ppat->i915)) {
- __alloc_ppat_entry(ppat, 0, GEN8_PPAT_UC);
- return;
- }
-
__alloc_ppat_entry(ppat, 0, GEN8_PPAT_WB | GEN8_PPAT_LLC);
__alloc_ppat_entry(ppat, 1, GEN8_PPAT_WC | GEN8_PPAT_LLCELLC);
__alloc_ppat_entry(ppat, 2, GEN8_PPAT_WT | GEN8_PPAT_LLCELLC);
--
2.14.2
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 8+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
2017-10-27 22:32 [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat Michel Thierry
@ 2017-10-27 23:06 ` Patchwork
2017-10-30 17:41 ` [PATCH] " Daniele Ceraolo Spurio
` (4 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-27 23:06 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
URL : https://patchwork.freedesktop.org/series/32792/
State : failure
== Summary ==
Series 32792v1 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
https://patchwork.freedesktop.org/api/1.0/series/32792/revisions/1/mbox/
Test gem_exec_flush:
Subgroup basic-wb-ro-before-default:
pass -> DMESG-FAIL (fi-glk-dsi)
Subgroup basic-wb-ro-default:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-wb-rw-before-default:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-wb-rw-default:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-wb-set-default:
pass -> SKIP (fi-glk-dsi)
Test gem_exec_nop:
Subgroup basic-parallel:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-series:
pass -> SKIP (fi-glk-dsi)
Test gem_exec_parallel:
Subgroup basic:
pass -> SKIP (fi-glk-dsi)
Test gem_exec_reloc:
Subgroup basic-cpu:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-gtt:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-cpu:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-read:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-read:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-cpu:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-gtt:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-read:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-gtt-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-cpu-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-read-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-read-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-cpu-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-gtt-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-read-noreloc:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-gtt-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-cpu-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-cpu-read-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-gtt-read-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-cpu-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-gtt-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-write-read-active:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-softpin:
pass -> SKIP (fi-glk-dsi)
Test gem_exec_store:
Subgroup basic-all:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-blt:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-bsd:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-default:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-render:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-vebox:
pass -> SKIP (fi-glk-dsi)
Test gem_exec_suspend:
Subgroup basic:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-s3:
pass -> SKIP (fi-glk-dsi)
Subgroup basic-s4-devices:
pass -> SKIP (fi-glk-dsi)
Test gem_linear_blits:
WARNING: Long output truncated
d0582552491e17f5e386747f82147c1f2d9158c9 drm-tip: 2017y-10m-27d-19h-16m-21s UTC integration manifest
4e986cec9962 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6254/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
2017-10-27 22:32 [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat Michel Thierry
2017-10-27 23:06 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-10-30 17:41 ` Daniele Ceraolo Spurio
2017-10-31 23:04 ` Rodrigo Vivi
2017-10-30 20:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
` (3 subsequent siblings)
5 siblings, 1 reply; 8+ messages in thread
From: Daniele Ceraolo Spurio @ 2017-10-30 17:41 UTC (permalink / raw)
To: Michel Thierry, intel-gfx; +Cc: Rodrigo Vivi
On 27/10/17 15:32, Michel Thierry wrote:
> There is no need check if PPGTT is disabled because that not possible
> in CNL. Execlists and GuC submission modes rely on at least aliasing
> PPGTT and even intel_sanitize_enable_ppgtt says: "We don't allow disabling
> PPGTT for gen9+ as it's a requirement for execlists, the sole mechanism
> available to submit work."
>
> Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> ---
Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ------
> 1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 7ebfc8ee479e..302ffe0cf3c7 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -3206,12 +3206,6 @@ static void cnl_setup_private_ppat(struct intel_ppat *ppat)
> ppat->match = bdw_private_pat_match;
> ppat->clear_value = GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(3);
>
> - /* XXX: spec is unclear if this is still needed for CNL+ */
> - if (!USES_PPGTT(ppat->i915)) {
> - __alloc_ppat_entry(ppat, 0, GEN8_PPAT_UC);
> - return;
> - }
> -
> __alloc_ppat_entry(ppat, 0, GEN8_PPAT_WB | GEN8_PPAT_LLC);
> __alloc_ppat_entry(ppat, 1, GEN8_PPAT_WC | GEN8_PPAT_LLCELLC);
> __alloc_ppat_entry(ppat, 2, GEN8_PPAT_WT | GEN8_PPAT_LLCELLC);
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
2017-10-27 22:32 [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat Michel Thierry
2017-10-27 23:06 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-30 17:41 ` [PATCH] " Daniele Ceraolo Spurio
@ 2017-10-30 20:23 ` Patchwork
2017-10-31 19:47 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-30 20:23 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
URL : https://patchwork.freedesktop.org/series/32792/
State : failure
== Summary ==
Series 32792v1 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
https://patchwork.freedesktop.org/api/1.0/series/32792/revisions/1/mbox/
Test gem_exec_reloc:
Subgroup basic-write-cpu-active:
pass -> FAIL (fi-gdg-551)
Subgroup basic-write-gtt-active:
pass -> FAIL (fi-gdg-551) fdo#102582
Test gem_exec_suspend:
Subgroup basic-s3:
pass -> DMESG-WARN (fi-cfl-s) fdo#103186
Test pm_rpm:
Subgroup basic-pci-d3-state:
incomplete -> FAIL (fi-bxt-j4205)
fdo#102582 https://bugs.freedesktop.org/show_bug.cgi?id=102582
fdo#103186 https://bugs.freedesktop.org/show_bug.cgi?id=103186
fi-bdw-5557u total:289 pass:266 dwarn:0 dfail:0 fail:2 skip:21 time:459s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:447s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:375s
fi-bsw-n3050 total:289 pass:241 dwarn:0 dfail:0 fail:2 skip:46 time:537s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:265s
fi-bxt-j4205 total:289 pass:258 dwarn:0 dfail:0 fail:2 skip:29 time:510s
fi-byt-j1900 total:289 pass:251 dwarn:1 dfail:0 fail:2 skip:35 time:512s
fi-byt-n2820 total:289 pass:247 dwarn:1 dfail:0 fail:2 skip:39 time:500s
fi-cfl-s total:289 pass:251 dwarn:4 dfail:0 fail:2 skip:32 time:623s
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:421s
fi-gdg-551 total:289 pass:176 dwarn:1 dfail:0 fail:3 skip:109 time:250s
fi-glk-1 total:289 pass:259 dwarn:0 dfail:0 fail:2 skip:28 time:590s
fi-hsw-4770 total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:444s
fi-hsw-4770r total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:443s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:415s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:493s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:459s
fi-kbl-7500u total:289 pass:262 dwarn:1 dfail:0 fail:2 skip:24 time:510s
fi-kbl-7560u total:289 pass:268 dwarn:0 dfail:0 fail:2 skip:19 time:580s
fi-kbl-7567u total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:493s
fi-kbl-r total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:592s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:540s
fi-skl-6260u total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:469s
fi-skl-6600u total:289 pass:260 dwarn:0 dfail:0 fail:2 skip:27 time:595s
fi-skl-6700hq total:289 pass:261 dwarn:0 dfail:0 fail:2 skip:26 time:659s
fi-skl-6700k total:289 pass:263 dwarn:0 dfail:0 fail:2 skip:24 time:539s
fi-skl-6770hq total:289 pass:267 dwarn:0 dfail:0 fail:2 skip:20 time:518s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:458s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:560s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:418s
fi-bxt-dsi failed to connect after reboot
302b1723bec5e7f43e423c975b9b87705fb9fdd6 drm-tip: 2017y-10m-30d-18h-28m-39s UTC integration manifest
552a8b99dd3b drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6268/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
2017-10-27 22:32 [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat Michel Thierry
` (2 preceding siblings ...)
2017-10-30 20:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
@ 2017-10-31 19:47 ` Patchwork
2017-10-31 21:48 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-01 0:42 ` ✗ Fi.CI.BAT: failure " Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-31 19:47 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
URL : https://patchwork.freedesktop.org/series/32792/
State : success
== Summary ==
Series 32792v1 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
https://patchwork.freedesktop.org/api/1.0/series/32792/revisions/1/mbox/
Test gem_mmap_gtt:
Subgroup basic-read-no-prefault:
dmesg-warn -> PASS (fi-bsw-n3050)
Test kms_addfb_basic:
Subgroup invalid-set-prop:
incomplete -> PASS (fi-cnl-y)
Test kms_flip:
Subgroup basic-flip-vs-dpms:
notrun -> INCOMPLETE (fi-cnl-y)
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:438s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:449s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:378s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:544s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:276s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:514s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:504s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:505s
fi-byt-n2820 total:289 pass:249 dwarn:1 dfail:0 fail:0 skip:39 time:495s
fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:554s
fi-cnl-y total:217 pass:196 dwarn:0 dfail:0 fail:0 skip:20
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:429s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:263s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:589s
fi-glk-dsi total:289 pass:258 dwarn:0 dfail:0 fail:1 skip:30 time:489s
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:432s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:431s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:430s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:499s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:465s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:485s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:573s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:479s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:588s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:569s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:468s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:597s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:649s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:519s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:502s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:458s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:569s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:421s
411ec53a58b3cf22efe7e8c7e6af94945c15568d drm-tip: 2017y-10m-31d-18h-16m-29s UTC integration manifest
09a3dfdecca8 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6281/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
2017-10-27 22:32 [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat Michel Thierry
` (3 preceding siblings ...)
2017-10-31 19:47 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2017-10-31 21:48 ` Patchwork
2017-11-01 0:42 ` ✗ Fi.CI.BAT: failure " Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-10-31 21:48 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
URL : https://patchwork.freedesktop.org/series/32792/
State : success
== Summary ==
Test kms_cursor_legacy:
Subgroup flip-vs-cursor-toggle:
fail -> PASS (shard-hsw) fdo#102670
Test kms_flip:
Subgroup plain-flip-ts-check-interruptible:
pass -> FAIL (shard-hsw) fdo#100368
fdo#102670 https://bugs.freedesktop.org/show_bug.cgi?id=102670
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
shard-hsw total:2539 pass:1431 dwarn:1 dfail:0 fail:10 skip:1097 time:9304s
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6281/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
2017-10-30 17:41 ` [PATCH] " Daniele Ceraolo Spurio
@ 2017-10-31 23:04 ` Rodrigo Vivi
0 siblings, 0 replies; 8+ messages in thread
From: Rodrigo Vivi @ 2017-10-31 23:04 UTC (permalink / raw)
To: Daniele Ceraolo Spurio; +Cc: intel-gfx
On Mon, Oct 30, 2017 at 05:41:50PM +0000, Daniele Ceraolo Spurio wrote:
>
>
> On 27/10/17 15:32, Michel Thierry wrote:
> > There is no need check if PPGTT is disabled because that not possible
> > in CNL. Execlists and GuC submission modes rely on at least aliasing
> > PPGTT and even intel_sanitize_enable_ppgtt says: "We don't allow disabling
> > PPGTT for gen9+ as it's a requirement for execlists, the sole mechanism
> > available to submit work."
> >
> > Suggested-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: Michel Thierry <michel.thierry@intel.com>
> > ---
>
> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Merged to dinq. Thanks for the patch and review.
>
> > drivers/gpu/drm/i915/i915_gem_gtt.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > index 7ebfc8ee479e..302ffe0cf3c7 100644
> > --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> > +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> > @@ -3206,12 +3206,6 @@ static void cnl_setup_private_ppat(struct intel_ppat *ppat)
> > ppat->match = bdw_private_pat_match;
> > ppat->clear_value = GEN8_PPAT_WB | GEN8_PPAT_LLCELLC | GEN8_PPAT_AGE(3);
> > - /* XXX: spec is unclear if this is still needed for CNL+ */
> > - if (!USES_PPGTT(ppat->i915)) {
> > - __alloc_ppat_entry(ppat, 0, GEN8_PPAT_UC);
> > - return;
> > - }
> > -
> > __alloc_ppat_entry(ppat, 0, GEN8_PPAT_WB | GEN8_PPAT_LLC);
> > __alloc_ppat_entry(ppat, 1, GEN8_PPAT_WC | GEN8_PPAT_LLCELLC);
> > __alloc_ppat_entry(ppat, 2, GEN8_PPAT_WT | GEN8_PPAT_LLCELLC);
> >
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
* ✗ Fi.CI.BAT: failure for drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
2017-10-27 22:32 [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat Michel Thierry
` (4 preceding siblings ...)
2017-10-31 21:48 ` ✓ Fi.CI.IGT: " Patchwork
@ 2017-11-01 0:42 ` Patchwork
5 siblings, 0 replies; 8+ messages in thread
From: Patchwork @ 2017-11-01 0:42 UTC (permalink / raw)
To: Michel Thierry; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
URL : https://patchwork.freedesktop.org/series/32792/
State : failure
== Summary ==
Series 32792v1 drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
https://patchwork.freedesktop.org/api/1.0/series/32792/revisions/1/mbox/
Test chamelium:
Subgroup dp-crc-fast:
fail -> PASS (fi-kbl-7500u) fdo#102514
Test gem_exec_flush:
Subgroup basic-batch-kernel-default-uc:
pass -> INCOMPLETE (fi-glk-dsi)
Test kms_pipe_crc_basic:
Subgroup suspend-read-crc-pipe-b:
dmesg-warn -> PASS (fi-byt-n2820) fdo#101705
Test drv_module_reload:
Subgroup basic-no-display:
fail -> PASS (fi-hsw-4770r)
fdo#102514 https://bugs.freedesktop.org/show_bug.cgi?id=102514
fdo#101705 https://bugs.freedesktop.org/show_bug.cgi?id=101705
fi-bdw-5557u total:289 pass:268 dwarn:0 dfail:0 fail:0 skip:21 time:445s
fi-bdw-gvtdvm total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:458s
fi-blb-e6850 total:289 pass:223 dwarn:1 dfail:0 fail:0 skip:65 time:380s
fi-bsw-n3050 total:289 pass:243 dwarn:0 dfail:0 fail:0 skip:46 time:537s
fi-bwr-2160 total:289 pass:183 dwarn:0 dfail:0 fail:0 skip:106 time:275s
fi-bxt-dsi total:289 pass:259 dwarn:0 dfail:0 fail:0 skip:30 time:505s
fi-bxt-j4205 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:502s
fi-byt-j1900 total:289 pass:253 dwarn:1 dfail:0 fail:0 skip:35 time:502s
fi-byt-n2820 total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:489s
fi-cfl-s total:289 pass:253 dwarn:4 dfail:0 fail:0 skip:32 time:551s
fi-cnl-y total:217 pass:196 dwarn:0 dfail:0 fail:0 skip:20
fi-elk-e7500 total:289 pass:229 dwarn:0 dfail:0 fail:0 skip:60 time:424s
fi-gdg-551 total:289 pass:178 dwarn:1 dfail:0 fail:1 skip:109 time:263s
fi-glk-1 total:289 pass:261 dwarn:0 dfail:0 fail:0 skip:28 time:581s
fi-glk-dsi total:61 pass:44 dwarn:0 dfail:0 fail:0 skip:16
fi-hsw-4770 total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:429s
fi-hsw-4770r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:429s
fi-ilk-650 total:289 pass:228 dwarn:0 dfail:0 fail:0 skip:61 time:426s
fi-ivb-3520m total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:500s
fi-ivb-3770 total:289 pass:260 dwarn:0 dfail:0 fail:0 skip:29 time:471s
fi-kbl-7500u total:289 pass:264 dwarn:1 dfail:0 fail:0 skip:24 time:493s
fi-kbl-7560u total:289 pass:270 dwarn:0 dfail:0 fail:0 skip:19 time:576s
fi-kbl-7567u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:483s
fi-kbl-r total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:587s
fi-pnv-d510 total:289 pass:222 dwarn:1 dfail:0 fail:0 skip:66 time:571s
fi-skl-6260u total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:460s
fi-skl-6600u total:289 pass:262 dwarn:0 dfail:0 fail:0 skip:27 time:593s
fi-skl-6700hq total:289 pass:263 dwarn:0 dfail:0 fail:0 skip:26 time:649s
fi-skl-6700k total:289 pass:265 dwarn:0 dfail:0 fail:0 skip:24 time:520s
fi-skl-6770hq total:289 pass:269 dwarn:0 dfail:0 fail:0 skip:20 time:513s
fi-skl-gvtdvm total:289 pass:266 dwarn:0 dfail:0 fail:0 skip:23 time:458s
fi-snb-2520m total:289 pass:250 dwarn:0 dfail:0 fail:0 skip:39 time:570s
fi-snb-2600 total:289 pass:249 dwarn:0 dfail:0 fail:0 skip:40 time:424s
98f067e087ab9294555a9bdd6a056c4156777117 drm-tip: 2017y-10m-31d-20h-56m-13s UTC integration manifest
fc7c19c1505e drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_6285/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2017-11-01 0:42 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-27 22:32 [PATCH] drm/i915/cnl: Remove unnecessary check in cnl_setup_private_ppat Michel Thierry
2017-10-27 23:06 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-30 17:41 ` [PATCH] " Daniele Ceraolo Spurio
2017-10-31 23:04 ` Rodrigo Vivi
2017-10-30 20:23 ` ✗ Fi.CI.BAT: failure for " Patchwork
2017-10-31 19:47 ` ✓ Fi.CI.BAT: success " Patchwork
2017-10-31 21:48 ` ✓ Fi.CI.IGT: " Patchwork
2017-11-01 0:42 ` ✗ Fi.CI.BAT: failure " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.