From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: Pintu Kumar <pintu.ping@gmail.com>,
shuah@kernel.org, Laura Abbott <labbott@redhat.com>,
kernel test robot <xiaolong.ye@intel.com>,
linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
dvhart@infradead.org,
Bamvor Zhang Jian <bamvor.zhangjian@linaro.org>,
Pintu Kumar <pintu_agarwal@yahoo.com>,
lkp@01.org
Subject: Re: [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail
Date: Thu, 2 Nov 2017 09:53:57 +0100 [thread overview]
Message-ID: <20171102085357.GA14531@kroah.com> (raw)
In-Reply-To: <13c66c9d-485f-7615-7a85-47bad9af30d1@osg.samsung.com>
On Wed, Nov 01, 2017 at 04:38:02PM -0600, Shuah Khan wrote:
> > For me also, if I have to test my code outside kernel tree, I usually
> > copy ion.h header file locally and test it.
> >
> > But, still I have one question about staging tree kernel headers.
> > How the kernel headers are created in case of Android where it uses
> > the ion and other headers heavily?
> >
>
> So this is a question for Greg KH? How do we handle staging headers?
We don't :)
Don't work too hard, or at all, for staging headers, someone should be
working to get the code out of staging. No need to provide "full
functionality" for all of the different kselftest options for staging
code, as that's just going to be a pain.
> We have couple of options here:
>
> - add a staging header install as part of kselftest
No.
> - add a kselftest source tar-ball utility that covers the staging header
> dependencies.
No.
Just don't install them, as they are not part of the normal process,
don't do anything special here please.
> I am reluctant to add a local ion.h. I would rather solve the bigger issue.
> I think this might not be the only time we will run into this type of dependency
For any other kernel code, stuff should go into uapi headers, but
staging is "special" here, so don't worry about it. Use relative paths
and all should be fine for the limited amount of testing possible.
I really do not like to see any staging dependancies out of
drivers/staging/ at all, as staging code should be self-contained and
could be deleted tomorrow with no other side effects at all. So maybe
there should not be any kselftests allowed for staging code...
thanks,
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: lkp@lists.01.org
Subject: Re: [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail
Date: Thu, 02 Nov 2017 09:53:57 +0100 [thread overview]
Message-ID: <20171102085357.GA14531@kroah.com> (raw)
In-Reply-To: <13c66c9d-485f-7615-7a85-47bad9af30d1@osg.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 1713 bytes --]
On Wed, Nov 01, 2017 at 04:38:02PM -0600, Shuah Khan wrote:
> > For me also, if I have to test my code outside kernel tree, I usually
> > copy ion.h header file locally and test it.
> >
> > But, still I have one question about staging tree kernel headers.
> > How the kernel headers are created in case of Android where it uses
> > the ion and other headers heavily?
> >
>
> So this is a question for Greg KH? How do we handle staging headers?
We don't :)
Don't work too hard, or at all, for staging headers, someone should be
working to get the code out of staging. No need to provide "full
functionality" for all of the different kselftest options for staging
code, as that's just going to be a pain.
> We have couple of options here:
>
> - add a staging header install as part of kselftest
No.
> - add a kselftest source tar-ball utility that covers the staging header
> dependencies.
No.
Just don't install them, as they are not part of the normal process,
don't do anything special here please.
> I am reluctant to add a local ion.h. I would rather solve the bigger issue.
> I think this might not be the only time we will run into this type of dependency
For any other kernel code, stuff should go into uapi headers, but
staging is "special" here, so don't worry about it. Use relative paths
and all should be fine for the limited amount of testing possible.
I really do not like to see any staging dependancies out of
drivers/staging/ at all, as staging code should be self-contained and
could be deleted tomorrow with no other side effects at all. So maybe
there should not be any kselftests allowed for staging code...
thanks,
greg k-h
next prev parent reply other threads:[~2017-11-02 8:53 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-26 18:08 [PATCH 1/1] [tools]: android/ion: userspace test utility for ion buffer sharing Pintu Agarwal
2017-09-26 18:50 ` Pintu Kumar
2017-09-26 19:22 ` Laura Abbott
2017-09-27 14:24 ` Pintu Kumar
2017-09-28 18:11 ` Pintu Kumar
2017-09-28 18:16 ` Pintu Kumar
2017-09-30 4:04 ` Pintu Kumar
2017-10-03 16:48 ` [PATCHv2 " Pintu Agarwal
2017-10-04 0:12 ` Laura Abbott
2017-10-04 11:29 ` Pintu Kumar
2017-10-04 22:07 ` Laura Abbott
2017-10-06 14:28 ` Pintu Kumar
2017-10-09 14:17 ` Pintu Kumar
2017-10-09 21:19 ` Laura Abbott
2017-10-04 7:20 ` Greg KH
2017-10-04 10:54 ` Pintu Kumar
2017-10-14 11:36 ` [PATCHv3 1/1] [tools/selftests]: " Pintu Agarwal
2017-10-17 14:18 ` Shuah Khan
2017-10-17 20:21 ` Laura Abbott
2017-10-17 20:58 ` Shuah Khan
2017-10-18 10:38 ` Pintu Kumar
2017-10-20 14:40 ` Shuah Khan
2017-10-20 15:18 ` Pintu Kumar
2017-10-20 19:21 ` Shuah Khan
2017-10-23 13:41 ` Pintu Kumar
2017-10-23 23:26 ` [PATCHv4 " Pintu Agarwal
2017-10-27 5:34 ` Pintu Kumar
2017-10-27 8:45 ` Greg Kroah-Hartman
2017-10-27 10:00 ` Pintu Kumar
2017-10-29 14:21 ` [lkp-robot] [android/ion] 5fb70554d6: kernel_selftests.android.make_fail kernel test robot
2017-10-29 14:21 ` kernel test robot
2017-10-30 7:12 ` Pintu Kumar
2017-10-30 21:02 ` Laura Abbott
2017-10-30 21:02 ` Laura Abbott
2017-10-31 10:21 ` Pintu Kumar
2017-10-31 21:58 ` Laura Abbott
2017-10-31 21:58 ` Laura Abbott
2017-11-01 10:12 ` Pintu Kumar
2017-11-01 10:30 ` Greg Kroah-Hartman
2017-11-01 10:30 ` Greg Kroah-Hartman
2017-11-01 15:04 ` Shuah Khan
2017-11-01 15:04 ` Shuah Khan
2017-11-01 16:26 ` Pintu Kumar
2017-11-01 16:57 ` Shuah Khan
2017-11-01 16:57 ` Shuah Khan
2017-11-01 17:14 ` Pintu Kumar
2017-11-01 22:38 ` Shuah Khan
2017-11-01 22:38 ` Shuah Khan
2017-11-02 8:53 ` Greg Kroah-Hartman [this message]
2017-11-02 8:53 ` Greg Kroah-Hartman
2017-11-02 14:50 ` Shuah Khan
2017-11-02 14:50 ` Shuah Khan
2017-10-30 22:56 ` [PATCHv4 1/1] [tools/selftests]: android/ion: userspace test utility for ion buffer sharing Laura Abbott
2017-10-31 9:49 ` Pintu Kumar
2017-11-01 17:00 ` [PATCHv5 " Pintu Agarwal
2017-11-02 15:07 ` Shuah Khan
2017-11-02 16:15 ` Pintu Kumar
2017-11-02 16:19 ` Shuah Khan
2017-11-02 17:53 ` Shuah Khan
2017-11-02 23:54 ` Laura Abbott
2017-11-03 0:32 ` Shuah Khan
2017-11-03 4:36 ` Pintu Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171102085357.GA14531@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bamvor.zhangjian@linaro.org \
--cc=dvhart@infradead.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lkp@01.org \
--cc=pintu.ping@gmail.com \
--cc=pintu_agarwal@yahoo.com \
--cc=shuah@kernel.org \
--cc=shuahkh@osg.samsung.com \
--cc=xiaolong.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.