All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>, <bcousson@baylibre.com>,
	Santosh Shilimkar <ssantosh@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>, <linux-mmc@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-omap@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <nsekhar@ti.com>,
	<kishon@ti.com>
Subject: [PATCH 11/14] ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default mode
Date: Thu, 14 Dec 2017 19:10:51 +0530	[thread overview]
Message-ID: <20171214134054.7749-12-kishon@ti.com> (raw)
In-Reply-To: <20171214134054.7749-1-kishon@ti.com>

During a short period when the bus voltage is switched from 3.3v to 1.8v,
(to enumerate UHS mode), the mmc module is disabled and the mmc IO lines
are kept in a state according to the programmed pad mux pull type.

According to 4.2.4.2 Timing to Switch Signal Voltage in "SD Specifications
Part 1 Physical Layer Specification Version 5.00 February 22, 2016", the
host should hold CLK low for at least 5ms.

In order to keep the card line low during voltage switch, the pad mux of
mmc1_clk line should be configured to pull down.

This is specific only to dra71-evm (and not all dra72 based boards) since
mmc1_clk line in dra71-evm is not connected to an external pullup.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/dra71-evm.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
index 64363f75c01a..ebc4bbae981e 100644
--- a/arch/arm/boot/dts/dra71-evm.dts
+++ b/arch/arm/boot/dts/dra71-evm.dts
@@ -50,6 +50,19 @@
 	};
 };
 
+&dra7_pmx_core {
+	mmc1_pins_default: mmc1_pins_default {
+		pinctrl-single,pins = <
+			DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLDOWN | MUX_MODE0) /* mmc1_clk.clk */
+			DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */
+			DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */
+			DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */
+			DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */
+			DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */
+		>;
+	};
+};
+
 &i2c1 {
 	status = "okay";
 	clock-frequency = <400000>;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: Kishon Vijay Abraham I <kishon@ti.com>
To: Tony Lindgren <tony@atomide.com>,
	bcousson@baylibre.com, Santosh Shilimkar <ssantosh@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, nsekhar@ti.com,
	kishon@ti.com
Subject: [PATCH 11/14] ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default mode
Date: Thu, 14 Dec 2017 19:10:51 +0530	[thread overview]
Message-ID: <20171214134054.7749-12-kishon@ti.com> (raw)
In-Reply-To: <20171214134054.7749-1-kishon@ti.com>

During a short period when the bus voltage is switched from 3.3v to 1.8v,
(to enumerate UHS mode), the mmc module is disabled and the mmc IO lines
are kept in a state according to the programmed pad mux pull type.

According to 4.2.4.2 Timing to Switch Signal Voltage in "SD Specifications
Part 1 Physical Layer Specification Version 5.00 February 22, 2016", the
host should hold CLK low for at least 5ms.

In order to keep the card line low during voltage switch, the pad mux of
mmc1_clk line should be configured to pull down.

This is specific only to dra71-evm (and not all dra72 based boards) since
mmc1_clk line in dra71-evm is not connected to an external pullup.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/dra71-evm.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
index 64363f75c01a..ebc4bbae981e 100644
--- a/arch/arm/boot/dts/dra71-evm.dts
+++ b/arch/arm/boot/dts/dra71-evm.dts
@@ -50,6 +50,19 @@
 	};
 };
 
+&dra7_pmx_core {
+	mmc1_pins_default: mmc1_pins_default {
+		pinctrl-single,pins = <
+			DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLDOWN | MUX_MODE0) /* mmc1_clk.clk */
+			DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */
+			DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */
+			DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */
+			DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */
+			DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */
+		>;
+	};
+};
+
 &i2c1 {
 	status = "okay";
 	clock-frequency = <400000>;
-- 
2.11.0

WARNING: multiple messages have this Message-ID (diff)
From: kishon@ti.com (Kishon Vijay Abraham I)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 11/14] ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default mode
Date: Thu, 14 Dec 2017 19:10:51 +0530	[thread overview]
Message-ID: <20171214134054.7749-12-kishon@ti.com> (raw)
In-Reply-To: <20171214134054.7749-1-kishon@ti.com>

During a short period when the bus voltage is switched from 3.3v to 1.8v,
(to enumerate UHS mode), the mmc module is disabled and the mmc IO lines
are kept in a state according to the programmed pad mux pull type.

According to 4.2.4.2 Timing to Switch Signal Voltage in "SD Specifications
Part 1 Physical Layer Specification Version 5.00 February 22, 2016", the
host should hold CLK low for at least 5ms.

In order to keep the card line low during voltage switch, the pad mux of
mmc1_clk line should be configured to pull down.

This is specific only to dra71-evm (and not all dra72 based boards) since
mmc1_clk line in dra71-evm is not connected to an external pullup.

Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
 arch/arm/boot/dts/dra71-evm.dts | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/arch/arm/boot/dts/dra71-evm.dts b/arch/arm/boot/dts/dra71-evm.dts
index 64363f75c01a..ebc4bbae981e 100644
--- a/arch/arm/boot/dts/dra71-evm.dts
+++ b/arch/arm/boot/dts/dra71-evm.dts
@@ -50,6 +50,19 @@
 	};
 };
 
+&dra7_pmx_core {
+	mmc1_pins_default: mmc1_pins_default {
+		pinctrl-single,pins = <
+			DRA7XX_CORE_IOPAD(0x3754, PIN_INPUT_PULLDOWN | MUX_MODE0) /* mmc1_clk.clk */
+			DRA7XX_CORE_IOPAD(0x3758, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_cmd.cmd */
+			DRA7XX_CORE_IOPAD(0x375c, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat0.dat0 */
+			DRA7XX_CORE_IOPAD(0x3760, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat1.dat1 */
+			DRA7XX_CORE_IOPAD(0x3764, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat2.dat2 */
+			DRA7XX_CORE_IOPAD(0x3768, PIN_INPUT_PULLUP | MUX_MODE0) /* mmc1_dat3.dat3 */
+		>;
+	};
+};
+
 &i2c1 {
 	status = "okay";
 	clock-frequency = <400000>;
-- 
2.11.0

  parent reply	other threads:[~2017-12-14 13:43 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-12-14 13:40 [PATCH 00/14] ARM: dra7/k2g: Use sdhci-omap for MMC/SD controller Kishon Vijay Abraham I
2017-12-14 13:40 ` Kishon Vijay Abraham I
2017-12-14 13:40 ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 01/14] ARM: multi_v7_defconfig: Enable CONFIG_MMC_SDHCI_OMAP Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 02/14] ARM: omap2plus_defconfig: " Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 03/14] ARM: configs: keystone: " Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 04/14] ARM: dts: dra76x: Create a common file with MMC/SD IOdelay data Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 15:15   ` Tony Lindgren
2017-12-14 15:15     ` Tony Lindgren
2017-12-15  6:09     ` Kishon Vijay Abraham I
2017-12-15  6:09       ` Kishon Vijay Abraham I
2017-12-15  6:09       ` Kishon Vijay Abraham I
2017-12-15 16:32       ` Tony Lindgren
2017-12-15 16:32         ` Tony Lindgren
2017-12-14 13:40 ` [PATCH 05/14] ARM: dts: dra76-evm: Shift to using common " Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 06/14] ARM: dts: dra76-evm: Add pinctrl data for higher speed MMC/SD modes Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 07/14] ARM: dts: am57xx-beagle-x15: Add "vqmmc-supply" property for mmc2 Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 08/14] ARM: dts: am57xx-idk: " Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 09/14] ARM: dts: dra76-evm: " Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 10/14] ARM: dts: dra71-evm: Correct evm_sd regulator max voltage Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` Kishon Vijay Abraham I [this message]
2017-12-14 13:40   ` [PATCH 11/14] ARM: dts: dra71-evm: Select pull down for mmc1_clk line in default mode Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 12/14] ARM: dts: am57xx-idk: " Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 13/14] ARM: dts: dra7: Use sdhci-omap programming model Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40 ` [PATCH 14/14] ARM: dts: keystone-k2g: " Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I
2017-12-14 13:40   ` Kishon Vijay Abraham I

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20171214134054.7749-12-kishon@ti.com \
    --to=kishon@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=nsekhar@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=ssantosh@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.