* [PATCH v1] ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly
@ 2018-01-22 12:55 Andy Shevchenko
2018-01-29 15:01 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2018-01-22 12:55 UTC (permalink / raw)
To: linux-arm-kernel
Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied type,
use PROPERTY_ENTRY_U32() dedicated macro.
It will help modify internals of built-in device properties API.
No functional change intended.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
arch/arm/mach-pxa/raumfeld.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-pxa/raumfeld.c
index 9d662fed03ec..0bf5419a9d10 100644
--- a/arch/arm/mach-pxa/raumfeld.c
+++ b/arch/arm/mach-pxa/raumfeld.c
@@ -378,9 +378,9 @@ static struct gpiod_lookup_table raumfeld_rotary_gpios_table = {
};
static const struct property_entry raumfeld_rotary_properties[] __initconst = {
- PROPERTY_ENTRY_INTEGER("rotary-encoder,steps-per-period", u32, 24),
- PROPERTY_ENTRY_INTEGER("linux,axis", u32, REL_X),
- PROPERTY_ENTRY_INTEGER("rotary-encoder,relative_axis", u32, 1),
+ PROPERTY_ENTRY_U32("rotary-encoder,steps-per-period", 24),
+ PROPERTY_ENTRY_U32("linux,axis", REL_X),
+ PROPERTY_ENTRY_U32("rotary-encoder,relative_axis", 1),
{ },
};
--
2.15.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v1] ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly
2018-01-22 12:55 [PATCH v1] ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly Andy Shevchenko
@ 2018-01-29 15:01 ` Andy Shevchenko
2018-01-29 17:31 ` Robert Jarzmik
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2018-01-29 15:01 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2018-01-22 at 14:55 +0200, Andy Shevchenko wrote:
> Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied
> type,
> use PROPERTY_ENTRY_U32() dedicated macro.
>
> It will help modify internals of built-in device properties API.
>
> No functional change intended.
>
Can someone apply that, or at least Ack? It's needed as a prerequisite
to fix one bug in device property core API.
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/arm/mach-pxa/raumfeld.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/mach-pxa/raumfeld.c b/arch/arm/mach-
> pxa/raumfeld.c
> index 9d662fed03ec..0bf5419a9d10 100644
> --- a/arch/arm/mach-pxa/raumfeld.c
> +++ b/arch/arm/mach-pxa/raumfeld.c
> @@ -378,9 +378,9 @@ static struct gpiod_lookup_table
> raumfeld_rotary_gpios_table = {
> };
>
> static const struct property_entry raumfeld_rotary_properties[]
> __initconst = {
> - PROPERTY_ENTRY_INTEGER("rotary-encoder,steps-per-period",
> u32, 24),
> - PROPERTY_ENTRY_INTEGER("linux,axis",
> u32, REL_X),
> - PROPERTY_ENTRY_INTEGER("rotary-encoder,relative_axis",
> u32, 1),
> + PROPERTY_ENTRY_U32("rotary-encoder,steps-per-period", 24),
> + PROPERTY_ENTRY_U32("linux,axis", REL_X),
> + PROPERTY_ENTRY_U32("rotary-encoder,relative_axis", 1),
> { },
> };
>
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly
2018-01-29 15:01 ` Andy Shevchenko
@ 2018-01-29 17:31 ` Robert Jarzmik
2018-01-29 17:37 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Robert Jarzmik @ 2018-01-29 17:31 UTC (permalink / raw)
To: linux-arm-kernel
Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> On Mon, 2018-01-22 at 14:55 +0200, Andy Shevchenko wrote:
>> Instead of using PROPERTY_ENTRY_INTEGER() with explicitly supplied
>> type,
>> use PROPERTY_ENTRY_U32() dedicated macro.
>>
>> It will help modify internals of built-in device properties API.
>>
>> No functional change intended.
>>
>
> Can someone apply that, or at least Ack? It's needed as a prerequisite
> to fix one bug in device property core API.
I can certainly ack it :
Acked-by: Robert Jarzmik <robert.jarzmik@free.fr>
I would have gladly taken it into my pxa/for-next branch, but for a reason your
original mail did not land in my mailbox ... computers can be deceiving
sometimes.
I you send it to me again I'll apply it to my tree.
Cheers.
--
Robert
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v1] ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly
2018-01-29 17:31 ` Robert Jarzmik
@ 2018-01-29 17:37 ` Andy Shevchenko
0 siblings, 0 replies; 4+ messages in thread
From: Andy Shevchenko @ 2018-01-29 17:37 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2018-01-29 at 18:31 +0100, Robert Jarzmik wrote:
> I would have gladly taken it into my pxa/for-next branch, but for a
> reason your
> original mail did not land in my mailbox ... computers can be
> deceiving
> sometimes.
>
> I you send it to me again I'll apply it to my tree.
Done!
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-01-29 17:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-22 12:55 [PATCH v1] ARM: pxa/raumfeld: use PROPERTY_ENTRY_U32() directly Andy Shevchenko
2018-01-29 15:01 ` Andy Shevchenko
2018-01-29 17:31 ` Robert Jarzmik
2018-01-29 17:37 ` Andy Shevchenko
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.