All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org,
	x86@kernel.org, shuah@kernel.org
Cc: Dmitry Safonov <dsafonov@virtuozzo.com>,
	Andy Lutomirski <luto@kernel.org>
Subject: [PATCH 3/5] selftests/x86: do not rely on int $0x80 in test_mremap_vdso.c
Date: Sun, 11 Feb 2018 12:10:11 +0100	[thread overview]
Message-ID: <20180211111013.16888-4-linux@dominikbrodowski.net> (raw)
In-Reply-To: <20180211111013.16888-1-linux@dominikbrodowski.net>

On 64bit builds, we should not rely on int $0x80 working (it only does if
CONFIG_IA32_EMULATION is enabled). Without this patch, the move test may
succeed, but the int $0x80 cause a segfault, resulting in a false negative
output of this selftest.

CC: Dmitry Safonov <dsafonov@virtuozzo.com>
CC: Andy Lutomirski <luto@kernel.org>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
---
 tools/testing/selftests/x86/test_mremap_vdso.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testing/selftests/x86/test_mremap_vdso.c
index bf0d687c7db7..64f11c8d9b76 100644
--- a/tools/testing/selftests/x86/test_mremap_vdso.c
+++ b/tools/testing/selftests/x86/test_mremap_vdso.c
@@ -90,8 +90,12 @@ int main(int argc, char **argv, char **envp)
 			vdso_size += PAGE_SIZE;
 		}
 
+#ifdef __i386__
 		/* Glibc is likely to explode now - exit with raw syscall */
 		asm volatile ("int $0x80" : : "a" (__NR_exit), "b" (!!ret));
+#else /* __x86_64__ */
+		syscall(SYS_exit, ret);
+#endif
 	} else {
 		int status;
 
-- 
2.16.1


WARNING: multiple messages have this Message-ID (diff)
From: linux at dominikbrodowski.net (Dominik Brodowski)
Subject: [Linux-kselftest-mirror] [PATCH 3/5] selftests/x86: do not rely on int $0x80 in test_mremap_vdso.c
Date: Sun, 11 Feb 2018 12:10:11 +0100	[thread overview]
Message-ID: <20180211111013.16888-4-linux@dominikbrodowski.net> (raw)
In-Reply-To: <20180211111013.16888-1-linux@dominikbrodowski.net>

On 64bit builds, we should not rely on int $0x80 working (it only does if
CONFIG_IA32_EMULATION is enabled). Without this patch, the move test may
succeed, but the int $0x80 cause a segfault, resulting in a false negative
output of this selftest.

CC: Dmitry Safonov <dsafonov at virtuozzo.com>
CC: Andy Lutomirski <luto at kernel.org>
Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>
---
 tools/testing/selftests/x86/test_mremap_vdso.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testing/selftests/x86/test_mremap_vdso.c
index bf0d687c7db7..64f11c8d9b76 100644
--- a/tools/testing/selftests/x86/test_mremap_vdso.c
+++ b/tools/testing/selftests/x86/test_mremap_vdso.c
@@ -90,8 +90,12 @@ int main(int argc, char **argv, char **envp)
 			vdso_size += PAGE_SIZE;
 		}
 
+#ifdef __i386__
 		/* Glibc is likely to explode now - exit with raw syscall */
 		asm volatile ("int $0x80" : : "a" (__NR_exit), "b" (!!ret));
+#else /* __x86_64__ */
+		syscall(SYS_exit, ret);
+#endif
 	} else {
 		int status;
 
-- 
2.16.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: linux@dominikbrodowski.net (Dominik Brodowski)
Subject: [Linux-kselftest-mirror] [PATCH 3/5] selftests/x86: do not rely on int $0x80 in test_mremap_vdso.c
Date: Sun, 11 Feb 2018 12:10:11 +0100	[thread overview]
Message-ID: <20180211111013.16888-4-linux@dominikbrodowski.net> (raw)
Message-ID: <20180211111011.zzmYRvdhAXgYdonyHp1zX2WpX99osxUMIoSdjasg5iE@z> (raw)
In-Reply-To: <20180211111013.16888-1-linux@dominikbrodowski.net>

On 64bit builds, we should not rely on int $0x80 working (it only does if
CONFIG_IA32_EMULATION is enabled). Without this patch, the move test may
succeed, but the int $0x80 cause a segfault, resulting in a false negative
output of this selftest.

CC: Dmitry Safonov <dsafonov at virtuozzo.com>
CC: Andy Lutomirski <luto at kernel.org>
Signed-off-by: Dominik Brodowski <linux at dominikbrodowski.net>
---
 tools/testing/selftests/x86/test_mremap_vdso.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/testing/selftests/x86/test_mremap_vdso.c
index bf0d687c7db7..64f11c8d9b76 100644
--- a/tools/testing/selftests/x86/test_mremap_vdso.c
+++ b/tools/testing/selftests/x86/test_mremap_vdso.c
@@ -90,8 +90,12 @@ int main(int argc, char **argv, char **envp)
 			vdso_size += PAGE_SIZE;
 		}
 
+#ifdef __i386__
 		/* Glibc is likely to explode now - exit with raw syscall */
 		asm volatile ("int $0x80" : : "a" (__NR_exit), "b" (!!ret));
+#else /* __x86_64__ */
+		syscall(SYS_exit, ret);
+#endif
 	} else {
 		int status;
 
-- 
2.16.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kselftest" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2018-02-11 11:11 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-11 11:10 [PATCH 0/5] selftests/x86: fixes for !CONFIG_IA32_EMULATION and vsyscall=none Dominik Brodowski
2018-02-11 11:10 ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 11:10 ` linux
2018-02-11 11:10 ` [PATCH 1/5] selftests/x86: 5lvl test has been moved Dominik Brodowski
2018-02-11 11:10   ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 11:10   ` linux
2018-02-11 12:13   ` [tip:x86/urgent] selftests/x86: Fix build bug caused by the 5lvl test which has been moved to the VM directory tip-bot for Dominik Brodowski
2018-02-13  9:05   ` [tip:x86/pti] " tip-bot for Dominik Brodowski
2018-02-11 11:10 ` [PATCH 2/5] selftests/x86: fix vDSO selftest segfault for vsyscall=none Dominik Brodowski
2018-02-11 11:10   ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 11:10   ` linux
2018-02-11 11:21   ` Ingo Molnar
2018-02-11 11:21     ` [Linux-kselftest-mirror] " Ingo Molnar
2018-02-11 11:21     ` mingo
2018-02-11 12:17     ` Dominik Brodowski
2018-02-11 12:17       ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 12:17       ` linux
2018-02-11 13:00       ` Dominik Brodowski
2018-02-11 13:00         ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 13:00         ` linux
2018-02-11 18:24         ` Ingo Molnar
2018-02-11 18:24           ` [Linux-kselftest-mirror] " Ingo Molnar
2018-02-11 18:24           ` mingo
2018-02-11 20:59           ` [PATCH] selftests/x86: clarify that there is no buffer overflow on sscanf usage Dominik Brodowski
2018-02-11 20:59             ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 20:59             ` linux
2018-02-12 17:58             ` Shuah Khan
2018-02-12 17:58               ` [Linux-kselftest-mirror] " Shuah Khan
2018-02-12 17:58               ` shuah
2018-02-13  9:04             ` [tip:x86/pti] selftests/x86: Clean up and document sscanf() usage tip-bot for Dominik Brodowski
2018-02-13  9:04   ` [tip:x86/pti] selftests/x86: Fix vDSO selftest segfault for vsyscall=none tip-bot for Dominik Brodowski
2018-02-11 11:10 ` Dominik Brodowski [this message]
2018-02-11 11:10   ` [Linux-kselftest-mirror] [PATCH 3/5] selftests/x86: do not rely on int $0x80 in test_mremap_vdso.c Dominik Brodowski
2018-02-11 11:10   ` linux
2018-02-11 12:13   ` [tip:x86/urgent] selftests/x86: Do not rely on "int $0x80" " tip-bot for Dominik Brodowski
2018-02-13  9:06   ` [tip:x86/pti] " tip-bot for Dominik Brodowski
2018-02-11 11:10 ` [PATCH 4/5] selftests/x86: do not rely on int $0x80 in single_step_syscall.c Dominik Brodowski
2018-02-11 11:10   ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 11:10   ` linux
2018-02-11 12:14   ` [tip:x86/urgent] selftests/x86: Do not rely on "int $0x80" " tip-bot for Dominik Brodowski
2018-02-13  9:06   ` [tip:x86/pti] " tip-bot for Ingo Molnar
2018-02-15  0:25   ` tip-bot for Dominik Brodowski
2018-02-11 11:10 ` [PATCH 5/5] selftests/x86: disable tests requiring 32bit support on pure 64bit systems Dominik Brodowski
2018-02-11 11:10   ` [Linux-kselftest-mirror] " Dominik Brodowski
2018-02-11 11:10   ` linux
2018-02-11 12:14   ` [tip:x86/urgent] selftests/x86: Disable tests requiring 32-bit support on pure 64-bit systems tip-bot for Dominik Brodowski
2018-02-13  9:07   ` [tip:x86/pti] " tip-bot for Ingo Molnar
2018-02-15  0:25   ` tip-bot for Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180211111013.16888-4-linux@dominikbrodowski.net \
    --to=linux@dominikbrodowski.net \
    --cc=dsafonov@virtuozzo.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=shuah@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.