All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: wim@linux-watchdog.org, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
	rwright@hpe.com, maurice.a.saldivar@hpe.com, mingo@kernel.org,
	marcus.folkesson@gmail.com, Jerry Hoemann <jerry.hoemann@hpe.com>
Subject: [PATCH v3 09/11] watchdog/hpwdt: condition early return of NMI handler on iLO5
Date: Thu, 15 Feb 2018 16:43:58 -0700	[thread overview]
Message-ID: <20180215234400.5022-10-jerry.hoemann@hpe.com> (raw)
In-Reply-To: <20180215234400.5022-1-jerry.hoemann@hpe.com>

Modify prior change to not claim an NMI unless originated
from iLO to apply only to iLO5 and later going forward.
This restores hpwdt traditional behavior of calling panic
if the NMI is NMI_IO_CHECK, NMI_SERR, or NMI_UNKNOWN for
legacy hardware.

Signed-off-by: Jerry Hoemann <jerry.hoemann@hpe.com>
---
 drivers/watchdog/hpwdt.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c
index dc0ad20738ed..654e22b84c80 100644
--- a/drivers/watchdog/hpwdt.c
+++ b/drivers/watchdog/hpwdt.c
@@ -38,6 +38,7 @@ static bool pretimeout = 1;
 #else
 static bool pretimeout;
 #endif
+static bool iLO5;
 
 static void __iomem *pci_mem_addr;		/* the PCI-memory address */
 static unsigned long __iomem *hpwdt_nmistat;
@@ -135,14 +136,14 @@ static int hpwdt_pretimeout(unsigned int ulReason, struct pt_regs *regs)
 		"3. OA Forward Progress Log\n"
 		"4. iLO Event Log";
 
-	if ((ulReason == NMI_UNKNOWN) && !mynmi)
-		return NMI_DONE;
-
 	pr_debug("nmi: ulReason=%d, mynmi=0x%0x\n", ulReason, mynmi);
 
 	if (!pretimeout)
 		return NMI_DONE;
 
+	if (iLO5 && (ulReason == NMI_UNKNOWN) && !mynmi)
+		return NMI_DONE;
+
 	if (allow_kdump)
 		hpwdt_stop(&hpwdt_dev);
 
@@ -275,6 +276,9 @@ static int hpwdt_probe(struct pci_dev *dev, const struct pci_device_id *ent)
 			", timer margin: %d seconds (nowayout=%d).\n",
 			HPWDT_VERSION, hpwdt_dev.timeout, nowayout);
 
+	if (dev->subsystem_vendor == PCI_VENDOR_ID_HP_3PAR)
+		iLO5 = 1;
+
 	return 0;
 
 error_wd_register:
-- 
2.13.6

  parent reply	other threads:[~2018-02-15 23:45 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-15 23:43 [PATCH v3 00/11] watchdog/hpwdt: Update driver to use watchdog core Jerry Hoemann
2018-02-15 23:43 ` [PATCH v3 01/11] watchdog/hpwdt: Remove legacy NMI sourcing Jerry Hoemann
2018-02-16  7:22   ` Ingo Molnar
2018-02-17 16:08   ` [v3,01/11] " Guenter Roeck
2018-02-15 23:43 ` [PATCH v3 02/11] watchdog/hpwdt: remove include files no longer needed Jerry Hoemann
2018-02-17 16:10   ` [v3,02/11] " Guenter Roeck
2018-02-15 23:43 ` [PATCH v3 03/11] watchdog/hpwdt: Update nmi_panic message Jerry Hoemann
2018-02-17 16:14   ` [v3,03/11] " Guenter Roeck
2018-02-15 23:43 ` [PATCH v3 04/11] watchdog/hpwdt: white space changes Jerry Hoemann
2018-02-17 16:17   ` [v3,04/11] " Guenter Roeck
2018-02-17 19:32     ` Jerry Hoemann
2018-02-17 20:27       ` Marcus Folkesson
2018-02-17 20:33         ` Jerry Hoemann
2018-02-19 16:46       ` Guenter Roeck
2018-02-20  7:31     ` Philippe Ombredanne
2018-02-15 23:43 ` [PATCH v3 05/11] watchdog/hpwdt: Update Module info Jerry Hoemann
2018-02-17 16:19   ` [v3,05/11] " Guenter Roeck
2018-02-17 20:39     ` Jerry Hoemann
2018-02-15 23:43 ` [PATCH v3 06/11] watchdog/hpwdt: Select WATCHDOG_CORE Jerry Hoemann
2018-02-17 16:21   ` [v3,06/11] " Guenter Roeck
2018-02-17 20:08     ` Jerry Hoemann
2018-02-15 23:43 ` [PATCH v3 07/11] watchdog/hpwdt: Modify to use watchdog core Jerry Hoemann
2018-02-17 16:49   ` [v3,07/11] " Guenter Roeck
2018-02-17 20:51     ` Jerry Hoemann
2018-02-15 23:43 ` [PATCH v3 08/11] watchdog/hpwdt: Programable Pretimeout NMI Jerry Hoemann
2018-02-16 20:34   ` Guenter Roeck
2018-02-16 23:46     ` Jerry Hoemann
2018-02-16 23:55       ` Guenter Roeck
2018-02-17  1:56         ` Jerry Hoemann
2018-02-17  2:29           ` Guenter Roeck
2018-02-15 23:43 ` Jerry Hoemann [this message]
2018-02-15 23:43 ` [PATCH v3 10/11] watchdog/hpwdt: remove allow_kdump module parameter Jerry Hoemann
2018-02-15 23:44 ` [PATCH v3 11/11] watchdog/hpwdt: Update driver version Jerry Hoemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180215234400.5022-10-jerry.hoemann@hpe.com \
    --to=jerry.hoemann@hpe.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=marcus.folkesson@gmail.com \
    --cc=maurice.a.saldivar@hpe.com \
    --cc=mingo@kernel.org \
    --cc=rwright@hpe.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.