From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: "Mylène Josserand" <mylene.josserand@bootlin.com>,
lgirdwood@gmail.com, robh+dt@kernel.org, mark.rutland@arm.com,
perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
thomas.petazzoni@bootlin.com, michael@amarulasolutions.com
Subject: Re: [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789
Date: Mon, 5 Mar 2018 15:59:38 +0000 [thread overview]
Message-ID: <20180305155938.GL8588@sirena.org.uk> (raw)
In-Reply-To: <20180305155715.GJ3035@piout.net>
[-- Attachment #1: Type: text/plain, Size: 509 bytes --]
On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote:
> On 05/03/2018 at 15:49:10 +0000, Mark Brown wrote:
> > Please don't mix C and C++ style comments in a single comment like this
> > - it looks unintentional. Just use the same style for the whole thing.
> > You also don't need to include all the boilerplate with the SPDX header.
> I think Linus made it clear that he wants the SPDX header to be a
> C++ comment, the documentation has:
Sure, so make the entire thing a C++ comment then.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, michael@amarulasolutions.com,
linux-kernel@vger.kernel.org, tiwai@suse.com,
lgirdwood@gmail.com, robh+dt@kernel.org,
thomas.petazzoni@bootlin.com,
"Mylène Josserand" <mylene.josserand@bootlin.com>
Subject: Re: [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789
Date: Mon, 5 Mar 2018 15:59:38 +0000 [thread overview]
Message-ID: <20180305155938.GL8588@sirena.org.uk> (raw)
In-Reply-To: <20180305155715.GJ3035@piout.net>
[-- Attachment #1.1: Type: text/plain, Size: 509 bytes --]
On Mon, Mar 05, 2018 at 04:57:15PM +0100, Alexandre Belloni wrote:
> On 05/03/2018 at 15:49:10 +0000, Mark Brown wrote:
> > Please don't mix C and C++ style comments in a single comment like this
> > - it looks unintentional. Just use the same style for the whole thing.
> > You also don't need to include all the boilerplate with the SPDX header.
> I think Linus made it clear that he wants the SPDX header to be a
> C++ comment, the documentation has:
Sure, so make the entire thing a C++ comment then.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-03-05 15:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-05 12:48 [PATCH v2 0/2] ASoC: Add support for DAC PCM1789 Mylène Josserand
2018-03-05 12:48 ` Mylène Josserand
2018-03-05 12:48 ` [PATCH v2 1/2] ASoC: codecs: Add support for PCM1789 Mylène Josserand
2018-03-05 12:48 ` Mylène Josserand
2018-03-05 15:49 ` Mark Brown
2018-03-05 15:57 ` Alexandre Belloni
2018-03-05 15:59 ` Mark Brown [this message]
2018-03-05 15:59 ` Mark Brown
2018-03-07 14:34 ` Mylène Josserand
2018-03-07 14:34 ` Mylène Josserand
2018-03-05 12:48 ` [PATCH v2 2/2] ASoC: Add bindings " Mylène Josserand
2018-03-07 22:30 ` Rob Herring
2018-03-08 8:54 ` Mylène Josserand
2018-03-08 8:54 ` Mylène Josserand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180305155938.GL8588@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=michael@amarulasolutions.com \
--cc=mylene.josserand@bootlin.com \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=thomas.petazzoni@bootlin.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.