All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Corbet <corbet@lwn.net>
To: Mimi Zohar <zohar@linux.vnet.ibm.com>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	"Winkler, Tomas" <tomas.winkler@intel.com>,
	Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	"Usyskin, Alexander" <alexander.usyskin@intel.com>,
	"linux-integrity@vger.kernel.org"
	<linux-integrity@vger.kernel.org>,
	linux-security-module@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.
Date: Wed, 7 Mar 2018 11:24:47 -0700	[thread overview]
Message-ID: <20180307112447.1eff794a@lwn.net> (raw)
In-Reply-To: <1520440503.10396.534.camel@linux.vnet.ibm.com>

On Wed, 07 Mar 2018 11:35:03 -0500
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> Some maintainers are saying to put the Changelog after the "---" so
> that it isn't included in the patch description.
> 
> One of the reasons for including the Changelog in the patch
> description, is to credit people with bug fixes, important rework of
> the patch, etc.
> 
> Do you have any thoughts on this?

Not sure I have a strong opinion there.  We do have various tags meant to
ensure proper credit; I would lean toward using those when possible rather
than including long change histories that, in the long term, don't help
readers to understand why the patch was applied.

Thanks,

jon

WARNING: multiple messages have this Message-ID (diff)
From: corbet@lwn.net (Jonathan Corbet)
To: linux-security-module@vger.kernel.org
Subject: [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands.
Date: Wed, 7 Mar 2018 11:24:47 -0700	[thread overview]
Message-ID: <20180307112447.1eff794a@lwn.net> (raw)
In-Reply-To: <1520440503.10396.534.camel@linux.vnet.ibm.com>

On Wed, 07 Mar 2018 11:35:03 -0500
Mimi Zohar <zohar@linux.vnet.ibm.com> wrote:

> Some maintainers are saying to put the Changelog after the "---" so
> that it isn't included in the patch description.
> 
> One of the reasons for including the Changelog in the patch
> description, is to credit people with bug fixes, important rework of
> the patch, etc.
> 
> Do you have any thoughts on this?

Not sure I have a strong opinion there.  We do have various tags meant to
ensure proper credit; I would lean toward using those when possible rather
than including long change histories that, in the long term, don't help
readers to understand why the patch was applied.

Thanks,

jon
--
To unsubscribe from this list: send the line "unsubscribe linux-security-module" in
the body of a message to majordomo at vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2018-03-07 18:24 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-04 12:12 [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Tomas Winkler
2018-03-04 12:12 ` Tomas Winkler
2018-03-04 12:12 ` [PATCH 2/3] tpm: add new tpm2 commands according to TCG 1.36 Tomas Winkler
2018-03-04 12:12   ` Tomas Winkler
2018-03-05 13:02   ` Jarkko Sakkinen
2018-03-05 13:02     ` Jarkko Sakkinen
2018-03-04 12:12 ` [PATCH 3/3] tpm_crb: use __le64 annotated variable for response buffer address Tomas Winkler
2018-03-04 12:12   ` Tomas Winkler
2018-03-05 13:03   ` Jarkko Sakkinen
2018-03-05 13:03     ` Jarkko Sakkinen
2018-03-06  8:28     ` Jarkko Sakkinen
2018-03-06  8:28       ` Jarkko Sakkinen
2018-03-06  8:34       ` Winkler, Tomas
2018-03-06  8:34         ` Winkler, Tomas
2018-03-06 15:39       ` Jason Gunthorpe
2018-03-06 15:39         ` Jason Gunthorpe
2018-03-05 12:56 ` [PATCH 1/3 RESEND] tpm: add longer timeouts for creation commands Jarkko Sakkinen
2018-03-05 12:56   ` Jarkko Sakkinen
2018-03-05 13:09   ` Winkler, Tomas
2018-03-05 13:09     ` Winkler, Tomas
2018-03-05 17:59     ` Jarkko Sakkinen
2018-03-05 17:59       ` Jarkko Sakkinen
2018-03-05 18:04       ` Winkler, Tomas
2018-03-05 18:04         ` Winkler, Tomas
2018-03-06  8:02         ` Jarkko Sakkinen
2018-03-06  8:02           ` Jarkko Sakkinen
2018-03-06  8:09           ` Winkler, Tomas
2018-03-06  8:09             ` Winkler, Tomas
2018-03-06  7:49     ` Jarkko Sakkinen
2018-03-06  7:49       ` Jarkko Sakkinen
2018-03-06  8:06       ` Winkler, Tomas
2018-03-06  8:06         ` Winkler, Tomas
2018-03-06 16:32         ` James Bottomley
2018-03-06 16:32           ` James Bottomley
2018-03-06 16:32           ` James Bottomley
2018-03-06 16:45           ` Winkler, Tomas
2018-03-06 16:45             ` Winkler, Tomas
2018-03-06 16:45             ` Winkler, Tomas
2018-03-06 18:36           ` Mimi Zohar
2018-03-06 18:36             ` Mimi Zohar
2018-03-06 18:36             ` Mimi Zohar
2018-03-06 21:59             ` Jason Gunthorpe
2018-03-06 21:59               ` Jason Gunthorpe
2018-03-06 21:59               ` Jason Gunthorpe
2018-03-07 15:22               ` Mimi Zohar
2018-03-07 15:22                 ` Mimi Zohar
2018-03-07 15:22                 ` Mimi Zohar
2018-03-07 15:41                 ` Winkler, Tomas
2018-03-07 15:41                   ` Winkler, Tomas
2018-03-07 15:41                   ` Winkler, Tomas
2018-03-07 15:54             ` Jonathan Corbet
2018-03-07 15:54               ` Jonathan Corbet
2018-03-07 16:04               ` Winkler, Tomas
2018-03-07 16:35               ` Mimi Zohar
2018-03-07 16:35                 ` Mimi Zohar
2018-03-07 18:24                 ` Jonathan Corbet [this message]
2018-03-07 18:24                   ` Jonathan Corbet
2018-03-10 12:46                 ` Jarkko Sakkinen
2018-03-10 12:46                   ` Jarkko Sakkinen
2018-03-10 12:44               ` Jarkko Sakkinen
2018-03-10 12:44                 ` Jarkko Sakkinen
2018-03-10 12:37             ` Jarkko Sakkinen
2018-03-10 12:37               ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180307112447.1eff794a@lwn.net \
    --to=corbet@lwn.net \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=alexander.usyskin@intel.com \
    --cc=jarkko.sakkinen@linux.intel.com \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=tomas.winkler@intel.com \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.