From: Christoph Hellwig <hch@infradead.org> To: Mikulas Patocka <mpatocka@redhat.com> Cc: Christoph Hellwig <hch@infradead.org>, Mike Snitzer <msnitzer@redhat.com>, dm-devel@redhat.com, "Alasdair G. Kergon" <agk@redhat.com>, linux-nvdimm@lists.01.org Subject: Re: [dm-devel] [PATCH] dm-writecache Date: Mon, 12 Mar 2018 00:50:29 -0700 [thread overview] Message-ID: <20180312075029.GC30695@infradead.org> (raw) In-Reply-To: <alpine.LRH.2.02.1803082213080.2200@file01.intranet.prod.int.rdu2.redhat.com> On Thu, Mar 08, 2018 at 10:26:17PM -0500, Mikulas Patocka wrote: > > no business having this around. > > It's the default setting of the flag wc->writeback_fua (it can be changed > with target parameters). The flag selects whether the target uses FUA > requests when doing writeback or whether it uses non-FUA requests and > FLUSH afterwards. For some block devices, FUA is faster, for some > nonFUA+FLUSH is faster. So just use true as the default flag, adding a name for it in addition to the field it is assigned to makes no sense at all. > > > +#ifndef bio_set_dev > > > +#define bio_set_dev(bio, dev) ((bio)->bi_bdev = (dev)) > > > +#endif > > > +#ifndef timer_setup > > > +#define timer_setup(t, c, f) setup_timer(t, c, (unsigned long)(t)) > > > +#endif > > > > no business in mainline. > > People removed dax support for ramdisk in 4.15. > > If I need to test it on non-x86 architecture, I need ramdisk as a fake dax > device - and that only works up to 4.14. These defines are for 4.14 > compatibility. So add them when you backport, or use the existing automated backport frameworks. But do not add dead code to an upstream submission. > > > +#if defined(CONFIG_X86_64) > > > +#define NT_STORE(dest, src) \ > > > +do { \ > > > + typeof(src) val = (src); \ > > > + memcpy_flushcache(&(dest), &val, sizeof(src)); \ > > > +} while (0) > > > +#define COMMIT_FLUSHED() wmb() > > > +#else > > > +#define NT_STORE(dest, src) WRITE_ONCE(dest, src) > > > +#define FLUSH_RANGE dax_flush > > > +#define COMMIT_FLUSHED() do { } while (0) > > > +#endif > > > > Please use proper APIs for this, this has no business in a driver. > > > > And that's it for now. This is clearly not submission ready, and I > > should got back to my backlog of other things. > > Why is memcpy_flushcache and dax_flush "improper"? What should I use > instead of them? They are proper and should be used directly instead of through your hacky macros. _______________________________________________ Linux-nvdimm mailing list Linux-nvdimm@lists.01.org https://lists.01.org/mailman/listinfo/linux-nvdimm
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> To: Mikulas Patocka <mpatocka-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: Christoph Hellwig <hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>, Mike Snitzer <msnitzer-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "Alasdair G. Kergon" <agk-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>, linux-nvdimm-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Subject: Re: [dm-devel] [PATCH] dm-writecache Date: Mon, 12 Mar 2018 00:50:29 -0700 [thread overview] Message-ID: <20180312075029.GC30695@infradead.org> (raw) In-Reply-To: <alpine.LRH.2.02.1803082213080.2200-Hpncn10jQN4oNljnaZt3ZvA+iT7yCHsGwRM8/txMwJMAicBL8TP8PQ@public.gmane.org> On Thu, Mar 08, 2018 at 10:26:17PM -0500, Mikulas Patocka wrote: > > no business having this around. > > It's the default setting of the flag wc->writeback_fua (it can be changed > with target parameters). The flag selects whether the target uses FUA > requests when doing writeback or whether it uses non-FUA requests and > FLUSH afterwards. For some block devices, FUA is faster, for some > nonFUA+FLUSH is faster. So just use true as the default flag, adding a name for it in addition to the field it is assigned to makes no sense at all. > > > +#ifndef bio_set_dev > > > +#define bio_set_dev(bio, dev) ((bio)->bi_bdev = (dev)) > > > +#endif > > > +#ifndef timer_setup > > > +#define timer_setup(t, c, f) setup_timer(t, c, (unsigned long)(t)) > > > +#endif > > > > no business in mainline. > > People removed dax support for ramdisk in 4.15. > > If I need to test it on non-x86 architecture, I need ramdisk as a fake dax > device - and that only works up to 4.14. These defines are for 4.14 > compatibility. So add them when you backport, or use the existing automated backport frameworks. But do not add dead code to an upstream submission. > > > +#if defined(CONFIG_X86_64) > > > +#define NT_STORE(dest, src) \ > > > +do { \ > > > + typeof(src) val = (src); \ > > > + memcpy_flushcache(&(dest), &val, sizeof(src)); \ > > > +} while (0) > > > +#define COMMIT_FLUSHED() wmb() > > > +#else > > > +#define NT_STORE(dest, src) WRITE_ONCE(dest, src) > > > +#define FLUSH_RANGE dax_flush > > > +#define COMMIT_FLUSHED() do { } while (0) > > > +#endif > > > > Please use proper APIs for this, this has no business in a driver. > > > > And that's it for now. This is clearly not submission ready, and I > > should got back to my backlog of other things. > > Why is memcpy_flushcache and dax_flush "improper"? What should I use > instead of them? They are proper and should be used directly instead of through your hacky macros.
next prev parent reply other threads:[~2018-03-12 7:44 UTC|newest] Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-08 13:25 [PATCH] dm-writecache Mikulas Patocka 2018-03-08 14:51 ` [dm-devel] " Christoph Hellwig 2018-03-08 14:51 ` Christoph Hellwig 2018-03-08 17:08 ` Dan Williams 2018-03-08 17:08 ` Dan Williams 2018-03-12 7:48 ` Christoph Hellwig 2018-03-12 7:48 ` Christoph Hellwig 2018-03-12 12:15 ` Mikulas Patocka 2018-03-12 12:15 ` Mikulas Patocka 2018-05-18 15:44 ` dm-writecache Mike Snitzer 2018-05-18 15:44 ` dm-writecache Mike Snitzer 2018-05-18 15:54 ` dm-writecache Dan Williams 2018-05-18 15:54 ` dm-writecache Dan Williams 2018-05-18 20:12 ` dm-writecache Mikulas Patocka 2018-05-18 20:12 ` dm-writecache Mikulas Patocka 2018-05-18 20:14 ` dm-writecache Dan Williams 2018-05-18 20:14 ` dm-writecache Dan Williams 2018-05-18 22:00 ` dm-writecache Mikulas Patocka 2018-05-18 22:00 ` dm-writecache Mikulas Patocka 2018-05-18 22:10 ` dm-writecache Dan Williams 2018-05-18 22:10 ` dm-writecache Dan Williams 2018-03-09 3:26 ` [dm-devel] [PATCH] dm-writecache Mikulas Patocka 2018-03-09 3:26 ` Mikulas Patocka 2018-03-12 7:50 ` Christoph Hellwig [this message] 2018-03-12 7:50 ` Christoph Hellwig 2018-03-12 12:12 ` Mikulas Patocka 2018-03-12 12:12 ` Mikulas Patocka
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180312075029.GC30695@infradead.org \ --to=hch@infradead.org \ --cc=agk@redhat.com \ --cc=dm-devel@redhat.com \ --cc=linux-nvdimm@lists.01.org \ --cc=mpatocka@redhat.com \ --cc=msnitzer@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.