From: Mark Brown <broonie@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] ASoC: max9759: Add Amplifier Driver
Date: Mon, 12 Mar 2018 09:18:59 -0700 [thread overview]
Message-ID: <20180312161859.GE2186@sirena.org.uk> (raw)
In-Reply-To: <1520679916-13517-3-git-send-email-narmstrong@baylibre.com>
[-- Attachment #1: Type: text/plain, Size: 591 bytes --]
On Sat, Mar 10, 2018 at 12:05:16PM +0100, Neil Armstrong wrote:
> @@ -0,0 +1,207 @@
> +// SPDX-Licence-Identifier: GPL-2.0
> +/*
> + * MAX9759 Amplifier Driver
> + *
Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed. Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing. If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: Neil Armstrong <narmstrong@baylibre.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH 2/2] ASoC: max9759: Add Amplifier Driver
Date: Mon, 12 Mar 2018 09:18:59 -0700 [thread overview]
Message-ID: <20180312161859.GE2186@sirena.org.uk> (raw)
In-Reply-To: <1520679916-13517-3-git-send-email-narmstrong@baylibre.com>
[-- Attachment #1.1: Type: text/plain, Size: 591 bytes --]
On Sat, Mar 10, 2018 at 12:05:16PM +0100, Neil Armstrong wrote:
> @@ -0,0 +1,207 @@
> +// SPDX-Licence-Identifier: GPL-2.0
> +/*
> + * MAX9759 Amplifier Driver
> + *
Please don't ignore review comments, people are generally making them
for a reason and are likely to have the same concerns if issues remain
unaddressed. Having to repeat the same comments can get repetitive and
make people question the value of time spent reviewing. If you disagree
with the review comments that's fine but you need to reply and discuss
your concerns so that the reviewer can understand your decisions.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-03-12 16:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-10 11:05 [RESEND PATCH 0/2] ASoC: Add support for max9759 Amplifier Driver Neil Armstrong
2018-03-10 11:05 ` [RESEND PATCH 1/2] ASoC: Add DT bindings documentation for max9759 amplifier Neil Armstrong
2018-03-10 11:05 ` Neil Armstrong
2018-03-10 11:05 ` [RESEND PATCH 2/2] ASoC: max9759: Add Amplifier Driver Neil Armstrong
2018-03-10 11:05 ` Neil Armstrong
2018-03-12 16:18 ` Mark Brown [this message]
2018-03-12 16:18 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180312161859.GE2186@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.