* [PATCH] Input: usbtouchscreen - double lock typo in usbtouch_close(()
@ 2018-03-19 14:43 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-03-19 14:43 UTC (permalink / raw)
To: kernel-janitors
There is a typo so we deadlock here instead of unlocking.
Fixes: 5648f00809c3 ("Input: usbtouchscreen - fix deadlock in autosuspend")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c
index 4ae1cbf9e858..c6cf90868503 100644
--- a/drivers/input/touchscreen/usbtouchscreen.c
+++ b/drivers/input/touchscreen/usbtouchscreen.c
@@ -1479,7 +1479,7 @@ static void usbtouch_close(struct input_dev *input)
if (!usbtouch->type->irq_always)
usb_kill_urb(usbtouch->irq);
usbtouch->is_open = false;
- mutex_lock(&usbtouch->pm_mutex);
+ mutex_unlock(&usbtouch->pm_mutex);
r = usb_autopm_get_interface(usbtouch->interface);
usbtouch->interface->needs_remote_wakeup = 0;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2018-03-19 14:43 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-03-19 14:43 [PATCH] Input: usbtouchscreen - double lock typo in usbtouch_close(() Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.