From: Jonathan Cameron <Jonathan.Cameron@huawei.com> To: "Hernán Gonzalez" <hernan@vanguardiasur.com.ar> Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>, <jic23@kernel.org>, <knaack.h@gmx.de>, <pmeerw@pmeerw.net>, <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 07/11] staging: iio: ad7746: Add remove() Date: Fri, 23 Mar 2018 12:48:37 +0000 [thread overview] Message-ID: <20180323134837.00002ab0@huawei.com> (raw) In-Reply-To: <1521642539-4845-8-git-send-email-hernan@vanguardiasur.com.ar> On Wed, 21 Mar 2018 11:28:55 -0300 Hernán Gonzalez <hernan@vanguardiasur.com.ar> wrote: > This allows the driver to be probed and removed as a module. > > Signed-off-by: Hernán Gonzalez <hernan@vanguardiasur.com.ar> > --- > drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c > index 815573c..8abba71 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -768,6 +768,15 @@ static int ad7746_probe(struct i2c_client *client, > return 0; > } > > +static int ad7746_remove(struct i2c_client *client) > +{ > + struct iio_dev *indio_dev = i2c_get_clientdata(client); > + > + iio_device_unregister(indio_dev); Remove is not required to allow a driver to be removed.. It's required to clean up anything that needs cleaning up when the remove happens. If all you have is the device unregister then it should be possible to use. devm_iio_device_register and rely on managed cleanup to automatically call the unregister code for you. Hence there would be no need to have a remove function. Jonathan > + > + return 0; > +} > + > static const struct i2c_device_id ad7746_id[] = { > { "ad7745", 7745 }, > { "ad7746", 7746 }, > @@ -792,6 +801,7 @@ static struct i2c_driver ad7746_driver = { > .of_match_table = of_match_ptr(ad7746_of_match), > }, > .probe = ad7746_probe, > + .remove = ad7746_remove, > .id_table = ad7746_id, > }; > module_i2c_driver(ad7746_driver);
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com> To: "Hernán Gonzalez" <hernan@vanguardiasur.com.ar> Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>, <jic23@kernel.org>, <knaack.h@gmx.de>, <pmeerw@pmeerw.net>, <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 07/11] staging: iio: ad7746: Add remove() Date: Fri, 23 Mar 2018 12:48:37 +0000 [thread overview] Message-ID: <20180323134837.00002ab0@huawei.com> (raw) In-Reply-To: <1521642539-4845-8-git-send-email-hernan@vanguardiasur.com.ar> On Wed, 21 Mar 2018 11:28:55 -0300 Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar> wrote: > This allows the driver to be probed and removed as a module. >=20 > Signed-off-by: Hern=E1n Gonzalez <hernan@vanguardiasur.com.ar> > --- > drivers/staging/iio/cdc/ad7746.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) >=20 > diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/a= d7746.c > index 815573c..8abba71 100644 > --- a/drivers/staging/iio/cdc/ad7746.c > +++ b/drivers/staging/iio/cdc/ad7746.c > @@ -768,6 +768,15 @@ static int ad7746_probe(struct i2c_client *client, > return 0; > } > =20 > +static int ad7746_remove(struct i2c_client *client) > +{ > + struct iio_dev *indio_dev =3D i2c_get_clientdata(client); > + > + iio_device_unregister(indio_dev); Remove is not required to allow a driver to be removed.. It's required to clean up anything that needs cleaning up when the remove happens. If all you have is the device unregister then it should be possible to use. devm_iio_device_register and rely on managed cleanup to automatically call the unregister code for you. Hence there would be no need to have a remove function. Jonathan > + > + return 0; > +} > + > static const struct i2c_device_id ad7746_id[] =3D { > { "ad7745", 7745 }, > { "ad7746", 7746 }, > @@ -792,6 +801,7 @@ static struct i2c_driver ad7746_driver =3D { > .of_match_table =3D of_match_ptr(ad7746_of_match), > }, > .probe =3D ad7746_probe, > + .remove =3D ad7746_remove, > .id_table =3D ad7746_id, > }; > module_i2c_driver(ad7746_driver);
next prev parent reply other threads:[~2018-03-23 12:48 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-03-21 14:28 [PATCH 00/11] Move ad7746 out of staging Hernán Gonzalez 2018-03-21 14:28 ` [PATCH 01/11] staging: iio: ad7746: Adjust arguments to match open parenthesis Hernán Gonzalez 2018-03-23 12:36 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 02/11] staging: iio: ad7746: Fix multiple line dereference Hernán Gonzalez 2018-03-21 14:28 ` [PATCH 03/11] staging: iio: ad7746: Reorder includes alphabetically Hernán Gonzalez 2018-03-21 14:28 ` [PATCH 04/11] staging: iio: ad7746: Reorder variable declarations Hernán Gonzalez 2018-03-23 12:40 ` Jonathan Cameron 2018-03-23 12:40 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 05/11] staging: iio: ad7746: Remove unused defines Hernán Gonzalez 2018-03-23 12:44 ` Jonathan Cameron 2018-03-23 12:44 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 06/11] staging: iio: ad7746: Add dt-bindings Hernán Gonzalez 2018-03-23 12:46 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 07/11] staging: iio: ad7746: Add remove() Hernán Gonzalez 2018-03-23 12:48 ` Jonathan Cameron [this message] 2018-03-23 12:48 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 08/11] staging: iio: ad7746: Add comments Hernán Gonzalez 2018-03-23 12:52 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 09/11] staging: iio: ad7746: Add devicetree bindings documentation Hernán Gonzalez 2018-03-23 12:54 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 10/11] staging: iio: ad7746: Rename sysfs attrs to comply with the ABI Hernán Gonzalez 2018-03-23 12:57 ` Jonathan Cameron 2018-03-23 12:57 ` Jonathan Cameron 2018-03-21 14:28 ` [PATCH 11/11] Move cdc ad7746 driver out of staging to mainline iio Hernán Gonzalez 2018-03-23 10:21 ` kbuild test robot 2018-03-23 12:33 ` Jonathan Cameron 2018-03-23 12:59 ` Jonathan Cameron 2018-03-23 13:04 ` [PATCH 00/11] Move ad7746 out of staging Jonathan Cameron 2018-03-23 13:04 ` Jonathan Cameron
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180323134837.00002ab0@huawei.com \ --to=jonathan.cameron@huawei.com \ --cc=Michael.Hennerich@analog.com \ --cc=hernan@vanguardiasur.com.ar \ --cc=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.