[RFC PATCH gabbayo] drm/amdkfd: kfd_dev_is_large_bar() can be static

[RFC PATCH gabbayo] drm/amdkfd: kfd_dev_is_large_bar() can be static

[kbuild test robot]

Fixes: 5ec7e02854b3 ("drm/amdkfd: Add ioctls for GPUVM memory management")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---
 kfd_chardev.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
index a563ff2..2a36592 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
@@ -1091,7 +1091,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, struct kfd_process *p,
 	return ret;
 }
 
-bool kfd_dev_is_large_bar(struct kfd_dev *dev)
+static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
 {
 	struct kfd_local_mem_info mem_info;
 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[gabbayo:amdkfd-next 14/18] drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1094:6: sparse: symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?

[kbuild test robot]

tree:   git://people.freedesktop.org/~gabbayo/linux amdkfd-next
head:   1679ae8f8f4148766423066aeb3dbb0a985a373a
commit: 5ec7e02854b3b9b55936c3b44b8acfb85e333f49 [14/18] drm/amdkfd: Add ioctls for GPUVM memory management
reproduce:
        # apt-get install sparse
        git checkout 5ec7e02854b3b9b55936c3b44b8acfb85e333f49
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/gpu/drm/amd/amdkfd/kfd_chardev.c:1094:6: sparse: symbol 'kfd_dev_is_large_bar' was not declared. Should it be static?

Please review and possibly fold the followup patch.

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

Re: [RFC PATCH gabbayo] drm/amdkfd: kfd_dev_is_large_bar() can be static

[Oded Gabbay]

On Tue, Mar 27, 2018 at 7:55 PM, kbuild test robot
<fengguang.wu@intel.com> wrote:
>
>
> Fixes: 5ec7e02854b3 ("drm/amdkfd: Add ioctls for GPUVM memory management")
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
>  kfd_chardev.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index a563ff2..2a36592 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -1091,7 +1091,7 @@ static int kfd_ioctl_acquire_vm(struct file *filep, struct kfd_process *p,
>         return ret;
>  }
>
> -bool kfd_dev_is_large_bar(struct kfd_dev *dev)
> +static bool kfd_dev_is_large_bar(struct kfd_dev *dev)
>  {
>         struct kfd_local_mem_info mem_info;
>

Thanks,
applied to -fixes
Oded
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel