From: Marc Zyngier <marc.zyngier@arm.com> To: Alexander Kurz <akurz@blala.de> Cc: David Miller <davem@davemloft.net>, <afd@ti.com>, <linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>, <freddy@asix.com.tw> Subject: Re: [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code Date: Mon, 2 Apr 2018 20:06:50 +0100 [thread overview] Message-ID: <20180402200650.72309de6@why.wild-wind.fr.eu.org> (raw) In-Reply-To: <alpine.DEB.2.20.1804021513340.14675@blala.de> [dropping Freddy as I'm getting bounces from asix.com.tw] On Mon, 2 Apr 2018 15:21:08 +0000 Alexander Kurz <akurz@blala.de> wrote: Alexander, > Hi Marc, David, > with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") > I made an embarrasly stupid mistake of removing the wrong function. > The v2 patch accidentially changed ax88179_link_reset() instead of > ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate > code") is just utterly wrong. OK, that explains what I saw here. > ax88179_bind() and ax88179_reset() were the correct targets to be > de-duplicated, as done in the v3 patch. > > Sorry for this, Alexander We all make mistakes, so let's try to learn from them. You can improve your process by testing what you're about to send (a very basic requirement), and documenting the changes you make on each version you send (a cover letter is a good place to put it). Answering reviewer questions helps building trust between the contributor and the maintainer on the receiving end of the patch, and you probably want to answer them before sending a new version so that a proper discussion can take place, specially if the reviewer doesn't quite see what you're aiming for. I'll comment on the patch separately. Hope this helps, M. -- Without deviation from the norm, progress is not possible.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com> To: Alexander Kurz <akurz@blala.de> Cc: David Miller <davem@davemloft.net>, afd@ti.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, freddy@asix.com.tw Subject: [v3,2/2] net: usb: asix88179_178a: de-duplicate code Date: Mon, 2 Apr 2018 20:06:50 +0100 [thread overview] Message-ID: <20180402200650.72309de6@why.wild-wind.fr.eu.org> (raw) [dropping Freddy as I'm getting bounces from asix.com.tw] On Mon, 2 Apr 2018 15:21:08 +0000 Alexander Kurz <akurz@blala.de> wrote: Alexander, > Hi Marc, David, > with the v2 patch ("net: usb: asix88179_178a: de-duplicate code") > I made an embarrasly stupid mistake of removing the wrong function. > The v2 patch accidentially changed ax88179_link_reset() instead of > ax88179_reset(). Hunk 6 of v2 ("net: usb: asix88179_178a: de-duplicate > code") is just utterly wrong. OK, that explains what I saw here. > ax88179_bind() and ax88179_reset() were the correct targets to be > de-duplicated, as done in the v3 patch. > > Sorry for this, Alexander We all make mistakes, so let's try to learn from them. You can improve your process by testing what you're about to send (a very basic requirement), and documenting the changes you make on each version you send (a cover letter is a good place to put it). Answering reviewer questions helps building trust between the contributor and the maintainer on the receiving end of the patch, and you probably want to answer them before sending a new version so that a proper discussion can take place, specially if the reviewer doesn't quite see what you're aiming for. I'll comment on the patch separately. Hope this helps, M.
next prev parent reply other threads:[~2018-04-02 19:06 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-04-02 7:43 [PATCH v3 1/2] net: usb: asix88179_178a: set permanent address once only Alexander Kurz 2018-04-02 7:43 ` [v3,1/2] " Alexander Kurz 2018-04-02 7:43 ` [PATCH v3 2/2] net: usb: asix88179_178a: de-duplicate code Alexander Kurz 2018-04-02 7:43 ` [v3,2/2] " Alexander Kurz 2018-04-02 9:45 ` [PATCH v3 2/2] " Marc Zyngier 2018-04-02 9:45 ` [v3,2/2] " Marc Zyngier 2018-04-02 14:14 ` [PATCH v3 2/2] " David Miller 2018-04-02 14:14 ` [v3,2/2] " David Miller 2018-04-02 15:21 ` [PATCH v3 2/2] " Alexander Kurz 2018-04-02 15:21 ` [v3,2/2] " Alexander Kurz 2018-04-02 19:06 ` Marc Zyngier [this message] 2018-04-02 19:06 ` Marc Zyngier 2018-04-02 20:25 ` [PATCH v3 2/2] " Marc Zyngier 2018-04-02 20:25 ` [v3,2/2] " Marc Zyngier
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180402200650.72309de6@why.wild-wind.fr.eu.org \ --to=marc.zyngier@arm.com \ --cc=afd@ti.com \ --cc=akurz@blala.de \ --cc=davem@davemloft.net \ --cc=freddy@asix.com.tw \ --cc=linux-usb@vger.kernel.org \ --cc=netdev@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.