* [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 2:44 ` Sridhar Pitchai
0 siblings, 0 replies; 14+ messages in thread
From: Sridhar Pitchai @ 2018-04-12 2:44 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Haiyang Zhang, Dexuan Cui
Cc: Stephen Hemminger, linux-pci, linux-kernel, Michael Kelley (EOSG),
Jake Oshins, devel
When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI
bus to the guest, Hyper-V always provides unique PCI domain.
commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
overrode unique domain with the serial number of the first device added to
the virtual PCI bus.
The reason for that patch was to have a consistent and short name for the
device, but Hyper-V doesn't provide unique serial numbers. Using non-unique
serial numbers as domain IDs leads to duplicate device addresses, which
causes PCI bus registration to fail.
Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
domain") so we can reliably support multiple devices being assigned to
a guest.
Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
Cc: stable@vger.kernel.org
Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
---
Changes in v7:
* fix the commit comment. [Bjorn Helgaas]
---
drivers/pci/host/pci-hyperv.c | 11 -----------
1 file changed, 11 deletions(-)
diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
index 2faf38eab785..ac67e56e451a 100644
--- a/drivers/pci/host/pci-hyperv.c
+++ b/drivers/pci/host/pci-hyperv.c
@@ -1518,17 +1518,6 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
get_pcichild(hpdev, hv_pcidev_ref_childlist);
spin_lock_irqsave(&hbus->device_list_lock, flags);
- /*
- * When a device is being added to the bus, we set the PCI domain
- * number to be the device serial number, which is non-zero and
- * unique on the same VM. The serial numbers start with 1, and
- * increase by 1 for each device. So device names including this
- * can have shorter names than based on the bus instance UUID.
- * Only the first device serial number is used for domain, so the
- * domain number will not change after the first device is added.
- */
- if (list_empty(&hbus->children))
- hbus->sysdata.domain = desc->ser;
list_add_tail(&hpdev->list_entry, &hbus->children);
spin_unlock_irqrestore(&hbus->device_list_lock, flags);
return hpdev;
--
2.14.1
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 2:44 ` Sridhar Pitchai
0 siblings, 0 replies; 14+ messages in thread
From: Sridhar Pitchai @ 2018-04-12 2:44 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi, Haiyang Zhang, Dexuan Cui
Cc: Stephen Hemminger, Jake Oshins, KY Srinivasan,
Michael Kelley (EOSG),
devel, linux-pci, linux-kernel
V2hlbiBMaW51eCBydW5zIGFzIGEgZ3Vlc3QgVk0gaW4gSHlwZXItViBhbmQgSHlwZXItViBhZGRz
IHRoZSB2aXJ0dWFsIFBDSQ0KYnVzIHRvIHRoZSBndWVzdCwgSHlwZXItViBhbHdheXMgcHJvdmlk
ZXMgdW5pcXVlIFBDSSBkb21haW4uDQoNCmNvbW1pdCA0YTliMDkzM2JkZmMgKCJQQ0k6IGh2OiBV
c2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJIGRvbWFpbiIpDQpvdmVycm9kZSB1bmlxdWUg
ZG9tYWluIHdpdGggdGhlIHNlcmlhbCBudW1iZXIgb2YgdGhlIGZpcnN0IGRldmljZSBhZGRlZCB0
bw0KdGhlIHZpcnR1YWwgUENJIGJ1cy4NCg0KVGhlIHJlYXNvbiBmb3IgdGhhdCBwYXRjaCB3YXMg
dG8gaGF2ZSBhIGNvbnNpc3RlbnQgYW5kIHNob3J0IG5hbWUgZm9yIHRoZQ0KZGV2aWNlLCBidXQg
SHlwZXItViBkb2Vzbid0IHByb3ZpZGUgdW5pcXVlIHNlcmlhbCBudW1iZXJzLiBVc2luZyBub24t
dW5pcXVlDQpzZXJpYWwgbnVtYmVycyBhcyBkb21haW4gSURzIGxlYWRzIHRvIGR1cGxpY2F0ZSBk
ZXZpY2UgYWRkcmVzc2VzLCB3aGljaA0KY2F1c2VzIFBDSSBidXMgcmVnaXN0cmF0aW9uIHRvIGZh
aWwuDQoNClJldmVydCBjb21taXQgNGE5YjA5MzNiZGZjICgiUENJOiBodjogVXNlIGRldmljZSBz
ZXJpYWwgbnVtYmVyIGFzIFBDSQ0KZG9tYWluIikgc28gd2UgY2FuIHJlbGlhYmx5IHN1cHBvcnQg
bXVsdGlwbGUgZGV2aWNlcyBiZWluZyBhc3NpZ25lZCB0bw0KYSBndWVzdC4NCg0KRml4ZXM6IDRh
OWIwOTMzYmRmYyAoIlBDSTogaHY6IFVzZSBkZXZpY2Ugc2VyaWFsIG51bWJlciBhcyBQQ0kgZG9t
YWluIikNClNpZ25lZC1vZmYtYnk6IFNyaWRoYXIgUGl0Y2hhaSA8c3JpZGhhci5waXRjaGFpQG1p
Y3Jvc29mdC5jb20+DQpDYzogc3RhYmxlQHZnZXIua2VybmVsLm9yZw0KUmV2aWV3ZWQtYnk6IEJq
b3JuIEhlbGdhYXMgPGJoZWxnYWFzQGdvb2dsZS5jb20+DQoNCi0tLQ0KQ2hhbmdlcyBpbiB2NzoN
CiogZml4IHRoZSBjb21taXQgY29tbWVudC4gW0Jqb3JuIEhlbGdhYXNdDQotLS0NCiBkcml2ZXJz
L3BjaS9ob3N0L3BjaS1oeXBlcnYuYyB8IDExIC0tLS0tLS0tLS0tDQogMSBmaWxlIGNoYW5nZWQs
IDExIGRlbGV0aW9ucygtKQ0KDQpkaWZmIC0tZ2l0IGEvZHJpdmVycy9wY2kvaG9zdC9wY2ktaHlw
ZXJ2LmMgYi9kcml2ZXJzL3BjaS9ob3N0L3BjaS1oeXBlcnYuYw0KaW5kZXggMmZhZjM4ZWFiNzg1
Li5hYzY3ZTU2ZTQ1MWEgMTAwNjQ0DQotLS0gYS9kcml2ZXJzL3BjaS9ob3N0L3BjaS1oeXBlcnYu
Yw0KKysrIGIvZHJpdmVycy9wY2kvaG9zdC9wY2ktaHlwZXJ2LmMNCkBAIC0xNTE4LDE3ICsxNTE4
LDYgQEAgc3RhdGljIHN0cnVjdCBodl9wY2lfZGV2ICpuZXdfcGNpY2hpbGRfZGV2aWNlKHN0cnVj
dCBodl9wY2lidXNfZGV2aWNlICpoYnVzLA0KIAlnZXRfcGNpY2hpbGQoaHBkZXYsIGh2X3BjaWRl
dl9yZWZfY2hpbGRsaXN0KTsNCiAJc3Bpbl9sb2NrX2lycXNhdmUoJmhidXMtPmRldmljZV9saXN0
X2xvY2ssIGZsYWdzKTsNCiANCi0JLyoNCi0JICogV2hlbiBhIGRldmljZSBpcyBiZWluZyBhZGRl
ZCB0byB0aGUgYnVzLCB3ZSBzZXQgdGhlIFBDSSBkb21haW4NCi0JICogbnVtYmVyIHRvIGJlIHRo
ZSBkZXZpY2Ugc2VyaWFsIG51bWJlciwgd2hpY2ggaXMgbm9uLXplcm8gYW5kDQotCSAqIHVuaXF1
ZSBvbiB0aGUgc2FtZSBWTS4gIFRoZSBzZXJpYWwgbnVtYmVycyBzdGFydCB3aXRoIDEsIGFuZA0K
LQkgKiBpbmNyZWFzZSBieSAxIGZvciBlYWNoIGRldmljZS4gIFNvIGRldmljZSBuYW1lcyBpbmNs
dWRpbmcgdGhpcw0KLQkgKiBjYW4gaGF2ZSBzaG9ydGVyIG5hbWVzIHRoYW4gYmFzZWQgb24gdGhl
IGJ1cyBpbnN0YW5jZSBVVUlELg0KLQkgKiBPbmx5IHRoZSBmaXJzdCBkZXZpY2Ugc2VyaWFsIG51
bWJlciBpcyB1c2VkIGZvciBkb21haW4sIHNvIHRoZQ0KLQkgKiBkb21haW4gbnVtYmVyIHdpbGwg
bm90IGNoYW5nZSBhZnRlciB0aGUgZmlyc3QgZGV2aWNlIGlzIGFkZGVkLg0KLQkgKi8NCi0JaWYg
KGxpc3RfZW1wdHkoJmhidXMtPmNoaWxkcmVuKSkNCi0JCWhidXMtPnN5c2RhdGEuZG9tYWluID0g
ZGVzYy0+c2VyOw0KIAlsaXN0X2FkZF90YWlsKCZocGRldi0+bGlzdF9lbnRyeSwgJmhidXMtPmNo
aWxkcmVuKTsNCiAJc3Bpbl91bmxvY2tfaXJxcmVzdG9yZSgmaGJ1cy0+ZGV2aWNlX2xpc3RfbG9j
aywgZmxhZ3MpOw0KIAlyZXR1cm4gaHBkZXY7DQotLSANCjIuMTQuMQ0KDQo=
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
2018-04-12 2:44 ` Sridhar Pitchai
@ 2018-04-12 9:17 ` Lorenzo Pieralisi
-1 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Pieralisi @ 2018-04-12 9:17 UTC (permalink / raw)
To: Sridhar Pitchai
Cc: Stephen Hemminger, linux-pci, Haiyang Zhang, linux-kernel,
Michael Kelley (EOSG),
Bjorn Helgaas, Jake Oshins, devel
On Thu, Apr 12, 2018 at 02:44:42AM +0000, Sridhar Pitchai wrote:
> When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI
> bus to the guest, Hyper-V always provides unique PCI domain.
>
> commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> overrode unique domain with the serial number of the first device added to
> the virtual PCI bus.
>
> The reason for that patch was to have a consistent and short name for the
> device, but Hyper-V doesn't provide unique serial numbers. Using non-unique
> serial numbers as domain IDs leads to duplicate device addresses, which
> causes PCI bus registration to fail.
>
> Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
> domain") so we can reliably support multiple devices being assigned to
> a guest.
>
> Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
> Cc: stable@vger.kernel.org
I am still not happy with this patch.
- You do not explain at all the dependency on commit 0c195567a8f6 and
you should because that's fundamental, if that patch is not present
this revert breaks the kernel as per previous discussions[1].
- You are sending this patch to all stable kernels that contain the
commit you are fixing - some that may not contain the commit above
(that was merged in v4.14), you are breaking those kernels, if not
explain me why please
You must mark the stable kernels you want this revert to be applied to
eg:
Cc: <stable@vger.kernel.org> # v4.14+
and for kernels that do not contain the 0c195567a8f6 commit you have to
add the dependency. Please read the documentation Greg provided you in
relation to stable kernel rules.
Use:
git tag --contains
to detect in what kernel version the given commits are present.
[1] https://marc.info/?l=linux-pci&m=152158684221212&w=2
> Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
>
> ---
> Changes in v7:
> * fix the commit comment. [Bjorn Helgaas]
> ---
> drivers/pci/host/pci-hyperv.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
> index 2faf38eab785..ac67e56e451a 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -1518,17 +1518,6 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
> get_pcichild(hpdev, hv_pcidev_ref_childlist);
> spin_lock_irqsave(&hbus->device_list_lock, flags);
>
> - /*
> - * When a device is being added to the bus, we set the PCI domain
> - * number to be the device serial number, which is non-zero and
> - * unique on the same VM. The serial numbers start with 1, and
> - * increase by 1 for each device. So device names including this
> - * can have shorter names than based on the bus instance UUID.
> - * Only the first device serial number is used for domain, so the
> - * domain number will not change after the first device is added.
> - */
> - if (list_empty(&hbus->children))
> - hbus->sysdata.domain = desc->ser;
> list_add_tail(&hpdev->list_entry, &hbus->children);
> spin_unlock_irqrestore(&hbus->device_list_lock, flags);
> return hpdev;
> --
> 2.14.1
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 9:17 ` Lorenzo Pieralisi
0 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Pieralisi @ 2018-04-12 9:17 UTC (permalink / raw)
To: Sridhar Pitchai
Cc: Bjorn Helgaas, Haiyang Zhang, Dexuan Cui, Stephen Hemminger,
Jake Oshins, KY Srinivasan, Michael Kelley (EOSG),
devel, linux-pci, linux-kernel
On Thu, Apr 12, 2018 at 02:44:42AM +0000, Sridhar Pitchai wrote:
> When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI
> bus to the guest, Hyper-V always provides unique PCI domain.
>
> commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> overrode unique domain with the serial number of the first device added to
> the virtual PCI bus.
>
> The reason for that patch was to have a consistent and short name for the
> device, but Hyper-V doesn't provide unique serial numbers. Using non-unique
> serial numbers as domain IDs leads to duplicate device addresses, which
> causes PCI bus registration to fail.
>
> Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
> domain") so we can reliably support multiple devices being assigned to
> a guest.
>
> Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
> Cc: stable@vger.kernel.org
I am still not happy with this patch.
- You do not explain at all the dependency on commit 0c195567a8f6 and
you should because that's fundamental, if that patch is not present
this revert breaks the kernel as per previous discussions[1].
- You are sending this patch to all stable kernels that contain the
commit you are fixing - some that may not contain the commit above
(that was merged in v4.14), you are breaking those kernels, if not
explain me why please
You must mark the stable kernels you want this revert to be applied to
eg:
Cc: <stable@vger.kernel.org> # v4.14+
and for kernels that do not contain the 0c195567a8f6 commit you have to
add the dependency. Please read the documentation Greg provided you in
relation to stable kernel rules.
Use:
git tag --contains
to detect in what kernel version the given commits are present.
[1] https://marc.info/?l=linux-pci&m=152158684221212&w=2
> Reviewed-by: Bjorn Helgaas <bhelgaas@google.com>
>
> ---
> Changes in v7:
> * fix the commit comment. [Bjorn Helgaas]
> ---
> drivers/pci/host/pci-hyperv.c | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c
> index 2faf38eab785..ac67e56e451a 100644
> --- a/drivers/pci/host/pci-hyperv.c
> +++ b/drivers/pci/host/pci-hyperv.c
> @@ -1518,17 +1518,6 @@ static struct hv_pci_dev *new_pcichild_device(struct hv_pcibus_device *hbus,
> get_pcichild(hpdev, hv_pcidev_ref_childlist);
> spin_lock_irqsave(&hbus->device_list_lock, flags);
>
> - /*
> - * When a device is being added to the bus, we set the PCI domain
> - * number to be the device serial number, which is non-zero and
> - * unique on the same VM. The serial numbers start with 1, and
> - * increase by 1 for each device. So device names including this
> - * can have shorter names than based on the bus instance UUID.
> - * Only the first device serial number is used for domain, so the
> - * domain number will not change after the first device is added.
> - */
> - if (list_empty(&hbus->children))
> - hbus->sysdata.domain = desc->ser;
> list_add_tail(&hpdev->list_entry, &hbus->children);
> spin_unlock_irqrestore(&hbus->device_list_lock, flags);
> return hpdev;
> --
> 2.14.1
>
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
2018-04-12 9:17 ` Lorenzo Pieralisi
@ 2018-04-12 13:20 ` Bjorn Helgaas
-1 siblings, 0 replies; 14+ messages in thread
From: Bjorn Helgaas @ 2018-04-12 13:20 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Stephen Hemminger, Sridhar Pitchai, linux-pci, Haiyang Zhang,
linux-kernel, Michael Kelley (EOSG),
Jake Oshins, devel
On Thu, Apr 12, 2018 at 10:17:42AM +0100, Lorenzo Pieralisi wrote:
> On Thu, Apr 12, 2018 at 02:44:42AM +0000, Sridhar Pitchai wrote:
> > When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI
> > bus to the guest, Hyper-V always provides unique PCI domain.
> >
> > commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> > overrode unique domain with the serial number of the first device added to
> > the virtual PCI bus.
> >
> > The reason for that patch was to have a consistent and short name for the
> > device, but Hyper-V doesn't provide unique serial numbers. Using non-unique
> > serial numbers as domain IDs leads to duplicate device addresses, which
> > causes PCI bus registration to fail.
> >
> > Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
> > domain") so we can reliably support multiple devices being assigned to
> > a guest.
> >
> > Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> > Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
> > Cc: stable@vger.kernel.org
>
> I am still not happy with this patch.
>
> - You do not explain at all the dependency on commit 0c195567a8f6 and
> you should because that's fundamental, if that patch is not present
> this revert breaks the kernel as per previous discussions[1].
> - You are sending this patch to all stable kernels that contain the
> commit you are fixing - some that may not contain the commit above
> (that was merged in v4.14), you are breaking those kernels, if not
> explain me why please
If there's a dependency on 0c195567a8f6, I totally agree that
needs to be cleared up. I was assuming that turned out to be
irrelevant.
> [1] https://marc.info/?l=linux-pci&m=152158684221212&w=2
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 13:20 ` Bjorn Helgaas
0 siblings, 0 replies; 14+ messages in thread
From: Bjorn Helgaas @ 2018-04-12 13:20 UTC (permalink / raw)
To: Lorenzo Pieralisi
Cc: Sridhar Pitchai, Haiyang Zhang, Dexuan Cui, Stephen Hemminger,
Jake Oshins, KY Srinivasan, Michael Kelley (EOSG),
devel, linux-pci, linux-kernel
On Thu, Apr 12, 2018 at 10:17:42AM +0100, Lorenzo Pieralisi wrote:
> On Thu, Apr 12, 2018 at 02:44:42AM +0000, Sridhar Pitchai wrote:
> > When Linux runs as a guest VM in Hyper-V and Hyper-V adds the virtual PCI
> > bus to the guest, Hyper-V always provides unique PCI domain.
> >
> > commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> > overrode unique domain with the serial number of the first device added to
> > the virtual PCI bus.
> >
> > The reason for that patch was to have a consistent and short name for the
> > device, but Hyper-V doesn't provide unique serial numbers. Using non-unique
> > serial numbers as domain IDs leads to duplicate device addresses, which
> > causes PCI bus registration to fail.
> >
> > Revert commit 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI
> > domain") so we can reliably support multiple devices being assigned to
> > a guest.
> >
> > Fixes: 4a9b0933bdfc ("PCI: hv: Use device serial number as PCI domain")
> > Signed-off-by: Sridhar Pitchai <sridhar.pitchai@microsoft.com>
> > Cc: stable@vger.kernel.org
>
> I am still not happy with this patch.
>
> - You do not explain at all the dependency on commit 0c195567a8f6 and
> you should because that's fundamental, if that patch is not present
> this revert breaks the kernel as per previous discussions[1].
> - You are sending this patch to all stable kernels that contain the
> commit you are fixing - some that may not contain the commit above
> (that was merged in v4.14), you are breaking those kernels, if not
> explain me why please
If there's a dependency on 0c195567a8f6, I totally agree that
needs to be cleared up. I was assuming that turned out to be
irrelevant.
> [1] https://marc.info/?l=linux-pci&m=152158684221212&w=2
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
2018-04-12 13:20 ` Bjorn Helgaas
@ 2018-04-12 15:13 ` Sridhar Pitchai
-1 siblings, 0 replies; 14+ messages in thread
From: Sridhar Pitchai @ 2018-04-12 15:13 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi
Cc: Stephen Hemminger, linux-pci, Haiyang Zhang, linux-kernel,
Michael Kelley (EOSG),
Jake Oshins, devel
>> I am still not happy with this patch.
>>
>> - You do not explain at all the dependency on commit 0c195567a8f6 and
>> you should because that's fundamental, if that patch is not present
>> this revert breaks the kernel as per previous discussions[1].
>> - You are sending this patch to all stable kernels that contain the
>> commit you are fixing - some that may not contain the commit above
>> (that was merged in v4.14), you are breaking those kernels, if not
>> explain me why please
>If there's a dependency on 0c195567a8f6, I totally agree that
>needs to be cleared up. I was assuming that turned out to be
>irrelevant.
That is right. There is no dependency on 0c195567a8f6. We just need
to revert 4a9b0933bdfc.
Thanks
Sridhar Pitchai
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 15:13 ` Sridhar Pitchai
0 siblings, 0 replies; 14+ messages in thread
From: Sridhar Pitchai @ 2018-04-12 15:13 UTC (permalink / raw)
To: Bjorn Helgaas, Lorenzo Pieralisi
Cc: Haiyang Zhang, Dexuan Cui, Stephen Hemminger, Jake Oshins,
KY Srinivasan, Michael Kelley (EOSG),
devel, linux-pci, linux-kernel
ICAgID4+IEkgYW0gc3RpbGwgbm90IGhhcHB5IHdpdGggdGhpcyBwYXRjaC4NCiAgICA+PiANCiAg
ICA+PiAtICBZb3UgZG8gbm90IGV4cGxhaW4gYXQgYWxsIHRoZSBkZXBlbmRlbmN5IG9uIGNvbW1p
dCAwYzE5NTU2N2E4ZjYgYW5kDQogICAgPj4gICAgeW91IHNob3VsZCBiZWNhdXNlIHRoYXQncyBm
dW5kYW1lbnRhbCwgaWYgdGhhdCBwYXRjaCBpcyBub3QgcHJlc2VudA0KICAgID4+ICAgIHRoaXMg
cmV2ZXJ0IGJyZWFrcyB0aGUga2VybmVsIGFzIHBlciBwcmV2aW91cyBkaXNjdXNzaW9uc1sxXS4N
CiAgICA+PiAtICBZb3UgYXJlIHNlbmRpbmcgdGhpcyBwYXRjaCB0byBhbGwgc3RhYmxlIGtlcm5l
bHMgdGhhdCBjb250YWluIHRoZQ0KICAgID4+ICAgIGNvbW1pdCB5b3UgYXJlIGZpeGluZyAtIHNv
bWUgdGhhdCBtYXkgbm90IGNvbnRhaW4gdGhlIGNvbW1pdCBhYm92ZQ0KICAgID4+ICAgICh0aGF0
IHdhcyBtZXJnZWQgaW4gdjQuMTQpLCB5b3UgYXJlIGJyZWFraW5nIHRob3NlIGtlcm5lbHMsIGlm
IG5vdA0KICAgID4+ICAgIGV4cGxhaW4gbWUgd2h5IHBsZWFzZQ0KICAgIA0KICAgID5JZiB0aGVy
ZSdzIGEgZGVwZW5kZW5jeSBvbiAwYzE5NTU2N2E4ZjYsIEkgdG90YWxseSBhZ3JlZSB0aGF0DQog
ICAgPm5lZWRzIHRvIGJlIGNsZWFyZWQgdXAuICBJIHdhcyBhc3N1bWluZyB0aGF0IHR1cm5lZCBv
dXQgdG8gYmUNCiAgICA+aXJyZWxldmFudC4NClRoYXQgaXMgcmlnaHQuIFRoZXJlIGlzIG5vIGRl
cGVuZGVuY3kgb24gMGMxOTU1NjdhOGY2LiBXZSBqdXN0IG5lZWQNCnRvIHJldmVydCA0YTliMDkz
M2JkZmMuDQoNClRoYW5rcw0KU3JpZGhhciBQaXRjaGFpDQogDQoNCg==
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
2018-04-12 15:13 ` Sridhar Pitchai
@ 2018-04-12 15:46 ` Haiyang Zhang
-1 siblings, 0 replies; 14+ messages in thread
From: Haiyang Zhang @ 2018-04-12 15:46 UTC (permalink / raw)
To: Sridhar Pitchai, Bjorn Helgaas, Lorenzo Pieralisi
Cc: Stephen Hemminger, linux-pci, linux-kernel, Michael Kelley (EOSG),
Jake Oshins, devel
> -----Original Message-----
> From: Sridhar Pitchai
> Sent: Thursday, April 12, 2018 11:14 AM
> To: Bjorn Helgaas <helgaas@kernel.org>; Lorenzo Pieralisi
> <lorenzo.pieralisi@arm.com>
> Cc: Haiyang Zhang <haiyangz@microsoft.com>; Dexuan Cui
> <decui@microsoft.com>; Stephen Hemminger <sthemmin@microsoft.com>;
> Jake Oshins <jakeo@microsoft.com>; KY Srinivasan <kys@microsoft.com>;
> Michael Kelley (EOSG) <Michael.H.Kelley@microsoft.com>;
> devel@linuxdriverproject.org; linux-pci@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI
> domain"
>
> >> I am still not happy with this patch.
> >>
> >> - You do not explain at all the dependency on commit 0c195567a8f6 and
> >> you should because that's fundamental, if that patch is not present
> >> this revert breaks the kernel as per previous discussions[1].
> >> - You are sending this patch to all stable kernels that contain the
> >> commit you are fixing - some that may not contain the commit above
> >> (that was merged in v4.14), you are breaking those kernels, if not
> >> explain me why please
>
> >If there's a dependency on 0c195567a8f6, I totally agree that
> >needs to be cleared up. I was assuming that turned out to be
> >irrelevant.
> That is right. There is no dependency on 0c195567a8f6. We just need to revert
> 4a9b0933bdfc.
This patch should only be applied to later versions after 0c195567a8f6" (transparent VF). Otherwise it causes long & random names of VF NICs for bonding. That will make bonding config difficult, especially for auto config.
Thanks,
- Haiyang
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* RE: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 15:46 ` Haiyang Zhang
0 siblings, 0 replies; 14+ messages in thread
From: Haiyang Zhang @ 2018-04-12 15:46 UTC (permalink / raw)
To: Sridhar Pitchai, Bjorn Helgaas, Lorenzo Pieralisi
Cc: Dexuan Cui, Stephen Hemminger, Jake Oshins, KY Srinivasan,
Michael Kelley (EOSG),
devel, linux-pci, linux-kernel
DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogU3JpZGhhciBQaXRjaGFp
DQo+IFNlbnQ6IFRodXJzZGF5LCBBcHJpbCAxMiwgMjAxOCAxMToxNCBBTQ0KPiBUbzogQmpvcm4g
SGVsZ2FhcyA8aGVsZ2Fhc0BrZXJuZWwub3JnPjsgTG9yZW56byBQaWVyYWxpc2kNCj4gPGxvcmVu
em8ucGllcmFsaXNpQGFybS5jb20+DQo+IENjOiBIYWl5YW5nIFpoYW5nIDxoYWl5YW5nekBtaWNy
b3NvZnQuY29tPjsgRGV4dWFuIEN1aQ0KPiA8ZGVjdWlAbWljcm9zb2Z0LmNvbT47IFN0ZXBoZW4g
SGVtbWluZ2VyIDxzdGhlbW1pbkBtaWNyb3NvZnQuY29tPjsNCj4gSmFrZSBPc2hpbnMgPGpha2Vv
QG1pY3Jvc29mdC5jb20+OyBLWSBTcmluaXZhc2FuIDxreXNAbWljcm9zb2Z0LmNvbT47DQo+IE1p
Y2hhZWwgS2VsbGV5IChFT1NHKSA8TWljaGFlbC5ILktlbGxleUBtaWNyb3NvZnQuY29tPjsNCj4g
ZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZzsgbGludXgtcGNpQHZnZXIua2VybmVsLm9yZzsg
bGludXgtDQo+IGtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcNCj4gU3ViamVjdDogUmU6IFtQQVRDSCB2
N10gUmV2ZXJ0ICJQQ0k6IGh2OiBVc2UgZGV2aWNlIHNlcmlhbCBudW1iZXIgYXMgUENJDQo+IGRv
bWFpbiINCj4gDQo+ICAgICA+PiBJIGFtIHN0aWxsIG5vdCBoYXBweSB3aXRoIHRoaXMgcGF0Y2gu
DQo+ICAgICA+Pg0KPiAgICAgPj4gLSAgWW91IGRvIG5vdCBleHBsYWluIGF0IGFsbCB0aGUgZGVw
ZW5kZW5jeSBvbiBjb21taXQgMGMxOTU1NjdhOGY2IGFuZA0KPiAgICAgPj4gICAgeW91IHNob3Vs
ZCBiZWNhdXNlIHRoYXQncyBmdW5kYW1lbnRhbCwgaWYgdGhhdCBwYXRjaCBpcyBub3QgcHJlc2Vu
dA0KPiAgICAgPj4gICAgdGhpcyByZXZlcnQgYnJlYWtzIHRoZSBrZXJuZWwgYXMgcGVyIHByZXZp
b3VzIGRpc2N1c3Npb25zWzFdLg0KPiAgICAgPj4gLSAgWW91IGFyZSBzZW5kaW5nIHRoaXMgcGF0
Y2ggdG8gYWxsIHN0YWJsZSBrZXJuZWxzIHRoYXQgY29udGFpbiB0aGUNCj4gICAgID4+ICAgIGNv
bW1pdCB5b3UgYXJlIGZpeGluZyAtIHNvbWUgdGhhdCBtYXkgbm90IGNvbnRhaW4gdGhlIGNvbW1p
dCBhYm92ZQ0KPiAgICAgPj4gICAgKHRoYXQgd2FzIG1lcmdlZCBpbiB2NC4xNCksIHlvdSBhcmUg
YnJlYWtpbmcgdGhvc2Uga2VybmVscywgaWYgbm90DQo+ICAgICA+PiAgICBleHBsYWluIG1lIHdo
eSBwbGVhc2UNCj4gDQo+ICAgICA+SWYgdGhlcmUncyBhIGRlcGVuZGVuY3kgb24gMGMxOTU1Njdh
OGY2LCBJIHRvdGFsbHkgYWdyZWUgdGhhdA0KPiAgICAgPm5lZWRzIHRvIGJlIGNsZWFyZWQgdXAu
ICBJIHdhcyBhc3N1bWluZyB0aGF0IHR1cm5lZCBvdXQgdG8gYmUNCj4gICAgID5pcnJlbGV2YW50
Lg0KPiBUaGF0IGlzIHJpZ2h0LiBUaGVyZSBpcyBubyBkZXBlbmRlbmN5IG9uIDBjMTk1NTY3YThm
Ni4gV2UganVzdCBuZWVkIHRvIHJldmVydA0KPiA0YTliMDkzM2JkZmMuDQoNClRoaXMgcGF0Y2gg
c2hvdWxkIG9ubHkgYmUgYXBwbGllZCB0byBsYXRlciB2ZXJzaW9ucyBhZnRlciAgMGMxOTU1Njdh
OGY2IiAodHJhbnNwYXJlbnQgVkYpLiBPdGhlcndpc2UgaXQgY2F1c2VzIGxvbmcgJiByYW5kb20g
bmFtZXMgb2YgVkYgTklDcyBmb3IgYm9uZGluZy4gVGhhdCB3aWxsIG1ha2UgYm9uZGluZyBjb25m
aWcgZGlmZmljdWx0LCBlc3BlY2lhbGx5IGZvciBhdXRvIGNvbmZpZy4NCg0KVGhhbmtzLA0KLSBI
YWl5YW5nDQo=
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
2018-04-12 15:46 ` Haiyang Zhang
@ 2018-04-12 15:56 ` Sridhar Pitchai
-1 siblings, 0 replies; 14+ messages in thread
From: Sridhar Pitchai @ 2018-04-12 15:56 UTC (permalink / raw)
To: Haiyang Zhang, Bjorn Helgaas, Lorenzo Pieralisi
Cc: Stephen Hemminger, linux-pci, linux-kernel, Michael Kelley (EOSG),
Jake Oshins, devel
>
> >> I am still not happy with this patch.
> >>
> >> - You do not explain at all the dependency on commit 0c195567a8f6 and
> >> you should because that's fundamental, if that patch is not present
> >> this revert breaks the kernel as per previous discussions[1].
> >> - You are sending this patch to all stable kernels that contain the
> >> commit you are fixing - some that may not contain the commit above
> >> (that was merged in v4.14), you are breaking those kernels, if not
> >> explain me why please
>
> >If there's a dependency on 0c195567a8f6, I totally agree that
> >needs to be cleared up. I was assuming that turned out to be
> >irrelevant.
> That is right. There is no dependency on 0c195567a8f6. We just need to revert
> 4a9b0933bdfc.
> This patch should only be applied to later versions after 0c195567a8f6" (transparent VF).
> Otherwise it causes long & random names of VF NICs for bonding. That will make bonding
> config difficult, especially for auto config.
>Thanks,
>- Haiyang
Ok. I will update the patch, as Lorenzo suggested.
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 15:56 ` Sridhar Pitchai
0 siblings, 0 replies; 14+ messages in thread
From: Sridhar Pitchai @ 2018-04-12 15:56 UTC (permalink / raw)
To: Haiyang Zhang, Bjorn Helgaas, Lorenzo Pieralisi
Cc: Dexuan Cui, Stephen Hemminger, Jake Oshins, KY Srinivasan,
Michael Kelley (EOSG),
devel, linux-pci, linux-kernel
ICAgID4gDQogICAgPiAgICAgPj4gSSBhbSBzdGlsbCBub3QgaGFwcHkgd2l0aCB0aGlzIHBhdGNo
Lg0KICAgID4gICAgID4+DQogICAgPiAgICAgPj4gLSAgWW91IGRvIG5vdCBleHBsYWluIGF0IGFs
bCB0aGUgZGVwZW5kZW5jeSBvbiBjb21taXQgMGMxOTU1NjdhOGY2IGFuZA0KICAgID4gICAgID4+
ICAgIHlvdSBzaG91bGQgYmVjYXVzZSB0aGF0J3MgZnVuZGFtZW50YWwsIGlmIHRoYXQgcGF0Y2gg
aXMgbm90IHByZXNlbnQNCiAgICA+ICAgICA+PiAgICB0aGlzIHJldmVydCBicmVha3MgdGhlIGtl
cm5lbCBhcyBwZXIgcHJldmlvdXMgZGlzY3Vzc2lvbnNbMV0uDQogICAgPiAgICAgPj4gLSAgWW91
IGFyZSBzZW5kaW5nIHRoaXMgcGF0Y2ggdG8gYWxsIHN0YWJsZSBrZXJuZWxzIHRoYXQgY29udGFp
biB0aGUNCiAgICA+ICAgICA+PiAgICBjb21taXQgeW91IGFyZSBmaXhpbmcgLSBzb21lIHRoYXQg
bWF5IG5vdCBjb250YWluIHRoZSBjb21taXQgYWJvdmUNCiAgICA+ICAgICA+PiAgICAodGhhdCB3
YXMgbWVyZ2VkIGluIHY0LjE0KSwgeW91IGFyZSBicmVha2luZyB0aG9zZSBrZXJuZWxzLCBpZiBu
b3QNCiAgICA+ICAgICA+PiAgICBleHBsYWluIG1lIHdoeSBwbGVhc2UNCiAgICA+IA0KICAgID4g
ICAgID5JZiB0aGVyZSdzIGEgZGVwZW5kZW5jeSBvbiAwYzE5NTU2N2E4ZjYsIEkgdG90YWxseSBh
Z3JlZSB0aGF0DQogICAgPiAgICAgPm5lZWRzIHRvIGJlIGNsZWFyZWQgdXAuICBJIHdhcyBhc3N1
bWluZyB0aGF0IHR1cm5lZCBvdXQgdG8gYmUNCiAgICA+ICAgICA+aXJyZWxldmFudC4NCiAgICA+
IFRoYXQgaXMgcmlnaHQuIFRoZXJlIGlzIG5vIGRlcGVuZGVuY3kgb24gMGMxOTU1NjdhOGY2LiBX
ZSBqdXN0IG5lZWQgdG8gcmV2ZXJ0DQogICAgPiA0YTliMDkzM2JkZmMuDQogICAgDQogICAgPiBU
aGlzIHBhdGNoIHNob3VsZCBvbmx5IGJlIGFwcGxpZWQgdG8gbGF0ZXIgdmVyc2lvbnMgYWZ0ZXIg
IDBjMTk1NTY3YThmNiIgKHRyYW5zcGFyZW50IFZGKS4NCiAgICA+IE90aGVyd2lzZSBpdCBjYXVz
ZXMgbG9uZyAmIHJhbmRvbSBuYW1lcyBvZiBWRiBOSUNzIGZvciBib25kaW5nLiBUaGF0IHdpbGwg
bWFrZSBib25kaW5nDQogICAgPiBjb25maWcgZGlmZmljdWx0LCBlc3BlY2lhbGx5IGZvciBhdXRv
IGNvbmZpZy4NCiAgICANCiAgICA+VGhhbmtzLA0KICAgID4tIEhhaXlhbmcNCk9rLiBJIHdpbGwg
dXBkYXRlIHRoZSBwYXRjaCwgYXMgTG9yZW56byBzdWdnZXN0ZWQuIA0KDQogICAgDQoNCg==
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
2018-04-12 15:56 ` Sridhar Pitchai
@ 2018-04-12 16:13 ` Lorenzo Pieralisi
-1 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Pieralisi @ 2018-04-12 16:13 UTC (permalink / raw)
To: Sridhar Pitchai
Cc: Stephen Hemminger, linux-pci, Haiyang Zhang, linux-kernel,
Michael Kelley (EOSG),
Bjorn Helgaas, Jake Oshins, devel
On Thu, Apr 12, 2018 at 03:56:42PM +0000, Sridhar Pitchai wrote:
> >
> > >> I am still not happy with this patch.
> > >>
> > >> - You do not explain at all the dependency on commit 0c195567a8f6 and
> > >> you should because that's fundamental, if that patch is not present
> > >> this revert breaks the kernel as per previous discussions[1].
> > >> - You are sending this patch to all stable kernels that contain the
> > >> commit you are fixing - some that may not contain the commit above
> > >> (that was merged in v4.14), you are breaking those kernels, if not
> > >> explain me why please
> >
> > >If there's a dependency on 0c195567a8f6, I totally agree that
> > >needs to be cleared up. I was assuming that turned out to be
> > >irrelevant.
> > That is right. There is no dependency on 0c195567a8f6. We just need to revert
> > 4a9b0933bdfc.
>
> > This patch should only be applied to later versions after 0c195567a8f6" (transparent VF).
> > Otherwise it causes long & random names of VF NICs for bonding. That will make bonding
> > config difficult, especially for auto config.
>
> >Thanks,
> >- Haiyang
> Ok. I will update the patch, as Lorenzo suggested.
Please update your email client quoting policy so that it does not add
unnecessary indentation spaces, for long threads this gets messy.
If you send a patch to a specific stable version you have to test it
first thing on that stable version before adding a stable tag, reverting
a patch from stable kernels is the last thing we want to do - that's the
reason why I keep complaining.
Thanks,
Lorenzo
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain"
@ 2018-04-12 16:13 ` Lorenzo Pieralisi
0 siblings, 0 replies; 14+ messages in thread
From: Lorenzo Pieralisi @ 2018-04-12 16:13 UTC (permalink / raw)
To: Sridhar Pitchai
Cc: Haiyang Zhang, Bjorn Helgaas, Dexuan Cui, Stephen Hemminger,
Jake Oshins, KY Srinivasan, Michael Kelley (EOSG),
devel, linux-pci, linux-kernel
On Thu, Apr 12, 2018 at 03:56:42PM +0000, Sridhar Pitchai wrote:
> >
> > >> I am still not happy with this patch.
> > >>
> > >> - You do not explain at all the dependency on commit 0c195567a8f6 and
> > >> you should because that's fundamental, if that patch is not present
> > >> this revert breaks the kernel as per previous discussions[1].
> > >> - You are sending this patch to all stable kernels that contain the
> > >> commit you are fixing - some that may not contain the commit above
> > >> (that was merged in v4.14), you are breaking those kernels, if not
> > >> explain me why please
> >
> > >If there's a dependency on 0c195567a8f6, I totally agree that
> > >needs to be cleared up. I was assuming that turned out to be
> > >irrelevant.
> > That is right. There is no dependency on 0c195567a8f6. We just need to revert
> > 4a9b0933bdfc.
>
> > This patch should only be applied to later versions after 0c195567a8f6" (transparent VF).
> > Otherwise it causes long & random names of VF NICs for bonding. That will make bonding
> > config difficult, especially for auto config.
>
> >Thanks,
> >- Haiyang
> Ok. I will update the patch, as Lorenzo suggested.
Please update your email client quoting policy so that it does not add
unnecessary indentation spaces, for long threads this gets messy.
If you send a patch to a specific stable version you have to test it
first thing on that stable version before adding a stable tag, reverting
a patch from stable kernels is the last thing we want to do - that's the
reason why I keep complaining.
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2018-04-12 16:13 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12 2:44 [PATCH v7] Revert "PCI: hv: Use device serial number as PCI domain" Sridhar Pitchai
2018-04-12 2:44 ` Sridhar Pitchai
2018-04-12 9:17 ` Lorenzo Pieralisi
2018-04-12 9:17 ` Lorenzo Pieralisi
2018-04-12 13:20 ` Bjorn Helgaas
2018-04-12 13:20 ` Bjorn Helgaas
2018-04-12 15:13 ` Sridhar Pitchai
2018-04-12 15:13 ` Sridhar Pitchai
2018-04-12 15:46 ` Haiyang Zhang
2018-04-12 15:46 ` Haiyang Zhang
2018-04-12 15:56 ` Sridhar Pitchai
2018-04-12 15:56 ` Sridhar Pitchai
2018-04-12 16:13 ` Lorenzo Pieralisi
2018-04-12 16:13 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.