* [U-Boot] [PATCH 1/1] video: if EFI_LOADER is enabled, enable CFB_CONSOLE_ANSI
@ 2018-04-29 20:43 Heinrich Schuchardt
2018-04-29 20:52 ` Alexander Graf
0 siblings, 1 reply; 4+ messages in thread
From: Heinrich Schuchardt @ 2018-04-29 20:43 UTC (permalink / raw)
To: u-boot
EFI applications like GRUB issue ANSI sequences for setting colors
and for positioning. So if the EFI subsystem is enabled, we should
also enable ANSI control sequences by default.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
drivers/video/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 2fc0defcd0..343ef31031 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -557,6 +557,7 @@ config CFB_CONSOLE
config CFB_CONSOLE_ANSI
bool "Support ANSI escape sequences"
depends on CFB_CONSOLE
+ default y if EFI_LOADER
help
This allows the colour buffer frame buffer driver to support
a limited number of ANSI escape sequences (cursor control,
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/1] video: if EFI_LOADER is enabled, enable CFB_CONSOLE_ANSI
2018-04-29 20:43 [U-Boot] [PATCH 1/1] video: if EFI_LOADER is enabled, enable CFB_CONSOLE_ANSI Heinrich Schuchardt
@ 2018-04-29 20:52 ` Alexander Graf
2018-04-29 20:58 ` Heinrich Schuchardt
2018-04-29 21:37 ` [U-Boot] [PATCH v2 1/1] efi_loader: " Heinrich Schuchardt
0 siblings, 2 replies; 4+ messages in thread
From: Alexander Graf @ 2018-04-29 20:52 UTC (permalink / raw)
To: u-boot
> Am 29.04.2018 um 22:43 schrieb Heinrich Schuchardt <xypron.glpk@gmx.de>:
>
> EFI applications like GRUB issue ANSI sequences for setting colors
> and for positioning. So if the EFI subsystem is enabled, we should
> also enable ANSI control sequences by default.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> drivers/video/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 2fc0defcd0..343ef31031 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -557,6 +557,7 @@ config CFB_CONSOLE
> config CFB_CONSOLE_ANSI
> bool "Support ANSI escape sequences"
> depends on CFB_CONSOLE
> + default y if EFI_LOADER
Isn‘t this what imply does?
Alex
> help
> This allows the colour buffer frame buffer driver to support
> a limited number of ANSI escape sequences (cursor control,
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH 1/1] video: if EFI_LOADER is enabled, enable CFB_CONSOLE_ANSI
2018-04-29 20:52 ` Alexander Graf
@ 2018-04-29 20:58 ` Heinrich Schuchardt
2018-04-29 21:37 ` [U-Boot] [PATCH v2 1/1] efi_loader: " Heinrich Schuchardt
1 sibling, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2018-04-29 20:58 UTC (permalink / raw)
To: u-boot
On 04/29/2018 10:52 PM, Alexander Graf wrote:
>
>
>> Am 29.04.2018 um 22:43 schrieb Heinrich Schuchardt <xypron.glpk@gmx.de>:
>>
>> EFI applications like GRUB issue ANSI sequences for setting colors
>> and for positioning. So if the EFI subsystem is enabled, we should
>> also enable ANSI control sequences by default.
>>
>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>> ---
>> drivers/video/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
>> index 2fc0defcd0..343ef31031 100644
>> --- a/drivers/video/Kconfig
>> +++ b/drivers/video/Kconfig
>> @@ -557,6 +557,7 @@ config CFB_CONSOLE
>> config CFB_CONSOLE_ANSI
>> bool "Support ANSI escape sequences"
>> depends on CFB_CONSOLE
>> + default y if EFI_LOADER
>
> Isn‘t this what imply does?
>
> Alex
Do you mean an existing imply? Or do you mean I should put an imply
somewhere else?
Regards
Heinrich
>
>> help
>> This allows the colour buffer frame buffer driver to support
>> a limited number of ANSI escape sequences (cursor control,
>> --
>> 2.11.0
>>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [U-Boot] [PATCH v2 1/1] efi_loader: if EFI_LOADER is enabled, enable CFB_CONSOLE_ANSI
2018-04-29 20:52 ` Alexander Graf
2018-04-29 20:58 ` Heinrich Schuchardt
@ 2018-04-29 21:37 ` Heinrich Schuchardt
1 sibling, 0 replies; 4+ messages in thread
From: Heinrich Schuchardt @ 2018-04-29 21:37 UTC (permalink / raw)
To: u-boot
EFI applications like GRUB issue ANSI sequences for setting colors
and for positioning. So if the EFI subsystem is enabled, we should
also enable ANSI control sequences by default.
Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
v2
Use 'imply' instead of 'default if'.
---
lib/efi_loader/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/efi_loader/Kconfig b/lib/efi_loader/Kconfig
index d38780b604e..c3c4783f394 100644
--- a/lib/efi_loader/Kconfig
+++ b/lib/efi_loader/Kconfig
@@ -10,6 +10,7 @@ config EFI_LOADER
default y
select LIB_UUID
select HAVE_BLOCK_DEVICE
+ imply CFB_CONSOLE_ANSI
help
Select this option if you want to run EFI applications (like grub2)
on top of U-Boot. If this option is enabled, U-Boot will expose EFI
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-29 21:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-29 20:43 [U-Boot] [PATCH 1/1] video: if EFI_LOADER is enabled, enable CFB_CONSOLE_ANSI Heinrich Schuchardt
2018-04-29 20:52 ` Alexander Graf
2018-04-29 20:58 ` Heinrich Schuchardt
2018-04-29 21:37 ` [U-Boot] [PATCH v2 1/1] efi_loader: " Heinrich Schuchardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.