All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: tsu.yubo@gmail.com
Cc: xiyou.wangcong@gmail.com, yuzibode@126.com,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c
Date: Wed, 02 May 2018 10:19:43 -0400 (EDT)	[thread overview]
Message-ID: <20180502.101943.1124614050601030061.davem@davemloft.net> (raw)
In-Reply-To: <20180502095421.GA15014@yubo-2>

From: Bo YU <tsu.yubo@gmail.com>
Date: Wed, 2 May 2018 05:54:24 -0400

> Optimization of command output: `cat /proc/net/netlink`
> 
> After the patch, we will get:
> 
> https://clbin.com/lnu4L
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> ---
>  net/netlink/af_netlink.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 55342c4d5cec..2e2dd88fc79f 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file
> *seq, void *v)
>  {
>  	if (v == SEQ_START_TOKEN) {
>  		seq_puts(seq,
> -			 "sk       Eth Pid    Groups   "
> -			 "Rmem     Wmem     Dump     Locks     Drops     Inode\n");
> +			 "sk               Eth Pid        Groups   "
> + "Rmem Wmem Dump Locks Drops Inode\n");

Please do not break the indentation of the code like this.

I wish to unfortunately say, that generally speaking, your patch
submissions are not of the best quality, and take up a lot of reviewer
time and resources as a result.

If you do not improve the quality of your submissions, I am giving
you a kind warning that the amount of care and review your patches
will receive will become lower.  Your submissions might even get to
the point wheere they are effectively ignored.

So please put more care into your work.

Thank you.

WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: tsu.yubo@gmail.com
Cc: xiyou.wangcong@gmail.com, yuzibode@126.com,
	netdev@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c
Date: Wed, 02 May 2018 14:19:43 +0000	[thread overview]
Message-ID: <20180502.101943.1124614050601030061.davem@davemloft.net> (raw)
In-Reply-To: <20180502095421.GA15014@yubo-2>

From: Bo YU <tsu.yubo@gmail.com>
Date: Wed, 2 May 2018 05:54:24 -0400

> Optimization of command output: `cat /proc/net/netlink`
> 
> After the patch, we will get:
> 
> https://clbin.com/lnu4L
> 
> Signed-off-by: Bo YU <tsu.yubo@gmail.com>
> ---
>  net/netlink/af_netlink.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
> index 55342c4d5cec..2e2dd88fc79f 100644
> --- a/net/netlink/af_netlink.c
> +++ b/net/netlink/af_netlink.c
> @@ -2606,13 +2606,13 @@ static int netlink_seq_show(struct seq_file
> *seq, void *v)
>  {
>  	if (v = SEQ_START_TOKEN) {
>  		seq_puts(seq,
> -			 "sk       Eth Pid    Groups   "
> -			 "Rmem     Wmem     Dump     Locks     Drops     Inode\n");
> +			 "sk               Eth Pid        Groups   "
> + "Rmem Wmem Dump Locks Drops Inode\n");

Please do not break the indentation of the code like this.

I wish to unfortunately say, that generally speaking, your patch
submissions are not of the best quality, and take up a lot of reviewer
time and resources as a result.

If you do not improve the quality of your submissions, I am giving
you a kind warning that the amount of care and review your patches
will receive will become lower.  Your submissions might even get to
the point wheere they are effectively ignored.

So please put more care into your work.

Thank you.

  reply	other threads:[~2018-05-02 14:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-02  9:54 [PATCH] NET/netlink: optimize output of seq_puts in af_netlink.c Bo YU
2018-05-02  9:54 ` Bo YU
2018-05-02 14:19 ` David Miller [this message]
2018-05-02 14:19   ` David Miller
2018-05-03  1:16   ` YU Bo
2018-05-03  1:16     ` YU Bo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502.101943.1124614050601030061.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=tsu.yubo@gmail.com \
    --cc=xiyou.wangcong@gmail.com \
    --cc=yuzibode@126.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.