All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Easton <kevin@guarana.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: David Miller <davem@davemloft.net>,
	linux-kernel@vger.kernel.org, jasowang@redhat.com,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH] vhost: make msg padding explicit
Date: Wed, 2 May 2018 10:40:15 -0400	[thread overview]
Message-ID: <20180502144015.GA18389@la.guarana.org> (raw)
In-Reply-To: <20180502171909-mutt-send-email-mst@kernel.org>

On Wed, May 02, 2018 at 05:19:27PM +0300, Michael S. Tsirkin wrote:
> On Wed, May 02, 2018 at 10:04:46AM -0400, David Miller wrote:
> > From: "Michael S. Tsirkin" <mst@redhat.com>
> > Date: Wed, 2 May 2018 16:36:37 +0300
> > 
> > > Ouch.  True - and in particular the 32 bit ABI on 64 bit kernels doesn't
> > > work at all. Hmm. It's relatively new and maybe there aren't any 32 bit
> > > users yet. Thoughts?
> > 
> > If it's been in a released kernel version, we really aren't at liberty
> > to play "maybe nobody uses this" UAPI changing games.
> > 
> > Please send me a revert.
> 
> Sent. Looking at compat mess now.

Just naming the padding field isn't sufficient anyway, there also needs to
be code in vhost_new_msg() to initialise it using the name.

    - Kevin

  reply	other threads:[~2018-05-02 14:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 16:02 [PATCH] vhost: make msg padding explicit Michael S. Tsirkin
2018-04-30  1:34 ` David Miller
2018-04-30  1:34 ` David Miller
2018-05-01 15:28 ` David Miller
2018-05-01 17:19   ` Michael S. Tsirkin
2018-05-01 17:19   ` Michael S. Tsirkin
2018-05-01 18:05     ` David Miller
2018-05-01 18:05     ` David Miller
2018-05-02  6:28       ` Kevin Easton
2018-05-02 13:36         ` Michael S. Tsirkin
2018-05-02 13:36         ` Michael S. Tsirkin
2018-05-02 14:04           ` David Miller
2018-05-02 14:04             ` David Miller
2018-05-02 14:19             ` Michael S. Tsirkin
2018-05-02 14:19               ` Michael S. Tsirkin
2018-05-02 14:40               ` Kevin Easton [this message]
2018-05-01 15:28 ` David Miller
2018-04-27 16:02 Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180502144015.GA18389@la.guarana.org \
    --to=kevin@guarana.org \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.