All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: <tony@atomide.com>
Cc: <bcousson@baylibre.com>, <linux-omap@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<j-keerthy@ti.com>
Subject: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type
Date: Tue, 8 May 2018 16:20:49 +0300	[thread overview]
Message-ID: <20180508132053.5471-1-peter.ujfalusi@ti.com> (raw)

Hi,

While based on the datasheet of tps65218 the INT is low active, the GIC_SPI
does not support anythin but IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING:

[    2.761814] genirq: Setting trigger mode 8 for irq 102 failed (irq_chip_set_type_parent+0x0/0x30)
[    2.770913] tps65218 0-0024: Failed to request IRQ 102 for tps65218: -22
[    2.777854] tps65218: probe of 0-0024 failed with error -22

Use LEVEL_HIGH for the interrupt as it looks to be the correct setting:
INTn of tps65218 is connected to NMIn of the SoC.

The offending patches are only in linux-next.

Regards,
Peter
---
Peter Ujfalusi (4):
  ARM: dts: am437x-gp-evm: Fixup (again) tps65218 irq type
  ARM: dts: am437x-cm-t43: Fixup (again) tps65218 irq type
  ARM: dts: am437x-epos-evm: Fixup (again) tps65218 irq type
  Revert "ARM: dts: am437x-sk-evm: Correct tps65218 irq type"

 arch/arm/boot/dts/am437x-cm-t43.dts  | 2 +-
 arch/arm/boot/dts/am437x-gp-evm.dts  | 2 +-
 arch/arm/boot/dts/am437x-sk-evm.dts  | 2 +-
 arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

WARNING: multiple messages have this Message-ID (diff)
From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: tony@atomide.com
Cc: bcousson@baylibre.com, linux-omap@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	j-keerthy@ti.com
Subject: [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type
Date: Tue, 8 May 2018 16:20:49 +0300	[thread overview]
Message-ID: <20180508132053.5471-1-peter.ujfalusi@ti.com> (raw)

Hi,

While based on the datasheet of tps65218 the INT is low active, the GIC_SPI
does not support anythin but IRQ_TYPE_LEVEL_HIGH or IRQ_TYPE_EDGE_RISING:

[    2.761814] genirq: Setting trigger mode 8 for irq 102 failed (irq_chip_set_type_parent+0x0/0x30)
[    2.770913] tps65218 0-0024: Failed to request IRQ 102 for tps65218: -22
[    2.777854] tps65218: probe of 0-0024 failed with error -22

Use LEVEL_HIGH for the interrupt as it looks to be the correct setting:
INTn of tps65218 is connected to NMIn of the SoC.

The offending patches are only in linux-next.

Regards,
Peter
---
Peter Ujfalusi (4):
  ARM: dts: am437x-gp-evm: Fixup (again) tps65218 irq type
  ARM: dts: am437x-cm-t43: Fixup (again) tps65218 irq type
  ARM: dts: am437x-epos-evm: Fixup (again) tps65218 irq type
  Revert "ARM: dts: am437x-sk-evm: Correct tps65218 irq type"

 arch/arm/boot/dts/am437x-cm-t43.dts  | 2 +-
 arch/arm/boot/dts/am437x-gp-evm.dts  | 2 +-
 arch/arm/boot/dts/am437x-sk-evm.dts  | 2 +-
 arch/arm/boot/dts/am43x-epos-evm.dts | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

             reply	other threads:[~2018-05-08 13:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 13:20 Peter Ujfalusi [this message]
2018-05-08 13:20 ` [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 1/4] ARM: dts: am437x-gp-evm: Fixup " Peter Ujfalusi
2018-05-08 13:20   ` Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 2/4] ARM: dts: am437x-cm-t43: " Peter Ujfalusi
2018-05-08 13:20   ` Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 3/4] ARM: dts: am437x-epos-evm: " Peter Ujfalusi
2018-05-08 13:20   ` Peter Ujfalusi
2018-05-08 13:20 ` [PATCH 4/4] Revert "ARM: dts: am437x-sk-evm: Correct tps65218 irq type" Peter Ujfalusi
2018-05-08 13:20   ` Peter Ujfalusi
2018-05-08 14:16 ` [PATCH 0/4] ARM: dts: am437x boards: Correct (again) tps65218 irq type Tony Lindgren
2018-05-09  4:00   ` Keerthy
2018-05-09  4:00     ` Keerthy
2018-05-15 18:15     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508132053.5471-1-peter.ujfalusi@ti.com \
    --to=peter.ujfalusi@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=j-keerthy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.