All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup
@ 2018-05-15  6:42 Peter Ujfalusi
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2018-05-15  6:42 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood, jarkko.nikula; +Cc: tony, alsa-devel, aaro.koskinen

Hi,

Changes since v1:
- Changed the MODULE_LICENSE from "GPL" to "GPL v2" to match the SPDX line.

Since the sdma-pcm can be built as module it must have MODULE_LICENSE defined,
whcih I have missed:

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information

The first patch also going to fix runtime issue with module loading:
snd_soc_sdma: Unknown symbol devm_kmalloc (err 0)
snd_soc_sdma: Unknown symbol omap_dma_filter_fn (err 0)
snd_soc_sdma: Unknown symbol snd_dmaengine_pcm_prepare_slave_config (err 0)
snd_soc_sdma: Unknown symbol devm_snd_dmaengine_pcm_register (err 0)

As these symbols are EXPORT_SYMBOL_GPL()...

Introduced by commit

  dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm")

The second patch is kust a small adjustement for the include files.

Regards,
Peter
---
Peter Ujfalusi (2):
  firmware: ti_sci: Correct the timeout type in ti_sci_do_xfer()
  ASoC: omap: sdma-pcm: Fix modpost warning

 drivers/firmware/ti_sci.c | 2 +-
 sound/soc/omap/sdma-pcm.c | 5 +++++
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup
@ 2018-05-15  6:43 Peter Ujfalusi
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Ujfalusi @ 2018-05-15  6:43 UTC (permalink / raw)
  To: Mark Brown, Liam Girdwood, jarkko.nikula; +Cc: tony, alsa-devel, aaro.koskinen

Hi,

Changes since v1:
- Changed the MODULE_LICENSE from "GPL" to "GPL v2" to match the SPDX line.

Since the sdma-pcm can be built as module it must have MODULE_LICENSE defined,
whcih I have missed:

After merging the sound-asoc tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information
WARNING: modpost: missing MODULE_LICENSE() in sound/soc/omap/snd-soc-sdma.o
see include/linux/module.h for more information

The first patch also going to fix runtime issue with module loading:
snd_soc_sdma: Unknown symbol devm_kmalloc (err 0)
snd_soc_sdma: Unknown symbol omap_dma_filter_fn (err 0)
snd_soc_sdma: Unknown symbol snd_dmaengine_pcm_prepare_slave_config (err 0)
snd_soc_sdma: Unknown symbol devm_snd_dmaengine_pcm_register (err 0)

As these symbols are EXPORT_SYMBOL_GPL()...

Introduced by commit

  dde637f2daf1 ("ASoC: omap: Introduce the generic_dmaengine_pcm based sdma-pcm")

The second patch is kust a small adjustement for the include files.

Regards,
Peter
---
Peter Ujfalusi (2):
  ASoC: omap: sdma-pcm: Fix modpost warning
  ASoC: omap: sdma-pcm: Correction for the include files

 sound/soc/omap/sdma-pcm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

-- 
Peter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-05-15  6:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-15  6:42 [PATCH v2 0/2] ASoC: omap: sdma-pcm: modpost warning fix and include cleanup Peter Ujfalusi
2018-05-15  6:43 Peter Ujfalusi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.