* [PATCH] ARM: dts: imx28-tx28: Fix alias DTC warnings
@ 2018-05-07 11:39 Fabio Estevam
2018-05-15 6:42 ` Shawn Guo
0 siblings, 1 reply; 3+ messages in thread
From: Fabio Estevam @ 2018-05-07 11:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Fabio Estevam <fabio.estevam@nxp.com>
Remove underscore from alias entries to fix the following DTC warnings
with W=1:
arch/arm/boot/dts/imx28-tx28.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
Cc: Lothar Wa?mann <LW@KARO-electronics.de>
Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
---
arch/arm/boot/dts/imx28-tx28.dts | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
index e4f19f9b..a5d6c97 100644
--- a/arch/arm/boot/dts/imx28-tx28.dts
+++ b/arch/arm/boot/dts/imx28-tx28.dts
@@ -56,11 +56,11 @@
ds1339 = &ds1339;
gpio5 = &gpio5;
lcdif = &lcdif;
- lcdif_23bit_pins = &tx28_lcdif_23bit_pins;
- lcdif_24bit_pins = &lcdif_24bit_pins_a;
- reg_can_xcvr = ®_can_xcvr;
- spi_gpio = &spi_gpio;
- spi_mxs = &ssp3;
+ lcdif-23bit-pins = &tx28_lcdif_23bit_pins;
+ lcdif-24bit-pins = &lcdif_24bit_pins_a;
+ reg-can-xcvr = ®_can_xcvr;
+ spigpio = &spi_gpio;
+ spi-mxs = &ssp3;
stk5led = &user_led;
usbotg = &usb0;
};
@@ -220,7 +220,7 @@
linux,no-autorepeat;
};
- spi_gpio: spi-gpio {
+ spi_gpio: spi {
compatible = "spi-gpio";
#address-cells = <1>;
#size-cells = <0>;
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: imx28-tx28: Fix alias DTC warnings
2018-05-07 11:39 [PATCH] ARM: dts: imx28-tx28: Fix alias DTC warnings Fabio Estevam
@ 2018-05-15 6:42 ` Shawn Guo
2018-05-15 16:57 ` Fabio Estevam
0 siblings, 1 reply; 3+ messages in thread
From: Shawn Guo @ 2018-05-15 6:42 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, May 07, 2018 at 08:39:52AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Remove underscore from alias entries to fix the following DTC warnings
> with W=1:
>
> arch/arm/boot/dts/imx28-tx28.dtb: Warning (alias_paths): /aliases: aliases property name must include only lowercase and '-'
>
> Cc: Lothar Wa?mann <LW@KARO-electronics.de>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> arch/arm/boot/dts/imx28-tx28.dts | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/arch/arm/boot/dts/imx28-tx28.dts b/arch/arm/boot/dts/imx28-tx28.dts
> index e4f19f9b..a5d6c97 100644
> --- a/arch/arm/boot/dts/imx28-tx28.dts
> +++ b/arch/arm/boot/dts/imx28-tx28.dts
> @@ -56,11 +56,11 @@
> ds1339 = &ds1339;
> gpio5 = &gpio5;
> lcdif = &lcdif;
> - lcdif_23bit_pins = &tx28_lcdif_23bit_pins;
> - lcdif_24bit_pins = &lcdif_24bit_pins_a;
> - reg_can_xcvr = ®_can_xcvr;
> - spi_gpio = &spi_gpio;
> - spi_mxs = &ssp3;
> + lcdif-23bit-pins = &tx28_lcdif_23bit_pins;
> + lcdif-24bit-pins = &lcdif_24bit_pins_a;
> + reg-can-xcvr = ®_can_xcvr;
> + spigpio = &spi_gpio;
> + spi-mxs = &ssp3;
> stk5led = &user_led;
> usbotg = &usb0;
> };
> @@ -220,7 +220,7 @@
> linux,no-autorepeat;
> };
>
> - spi_gpio: spi-gpio {
> + spi_gpio: spi {
Not sure why the node name needs to be changed here.
Shawn
> compatible = "spi-gpio";
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] ARM: dts: imx28-tx28: Fix alias DTC warnings
2018-05-15 6:42 ` Shawn Guo
@ 2018-05-15 16:57 ` Fabio Estevam
0 siblings, 0 replies; 3+ messages in thread
From: Fabio Estevam @ 2018-05-15 16:57 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, May 15, 2018 at 3:42 AM, Shawn Guo <shawnguo@kernel.org> wrote:
>> - spi_gpio: spi-gpio {
>> + spi_gpio: spi {
>
> Not sure why the node name needs to be changed here.
Yes, this is a different fix and should be part of a different patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-15 16:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-07 11:39 [PATCH] ARM: dts: imx28-tx28: Fix alias DTC warnings Fabio Estevam
2018-05-15 6:42 ` Shawn Guo
2018-05-15 16:57 ` Fabio Estevam
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.