* [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare
@ 2018-05-16 11:18 YueHaibing
2018-05-16 15:00 ` Tobias Klauser
2018-05-16 18:47 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: YueHaibing @ 2018-05-16 11:18 UTC (permalink / raw)
To: tklauser, davem; +Cc: netdev, linux-kernel, YueHaibing
clk_disable_unprepare() already checks that the clock pointer is valid.
No need to test it before calling it.
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/net/ethernet/ethoc.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c
index 8bb0db9..00a5727 100644
--- a/drivers/net/ethernet/ethoc.c
+++ b/drivers/net/ethernet/ethoc.c
@@ -1246,8 +1246,7 @@ static int ethoc_probe(struct platform_device *pdev)
mdiobus_unregister(priv->mdio);
mdiobus_free(priv->mdio);
free2:
- if (priv->clk)
- clk_disable_unprepare(priv->clk);
+ clk_disable_unprepare(priv->clk);
free:
free_netdev(netdev);
out:
@@ -1271,8 +1270,7 @@ static int ethoc_remove(struct platform_device *pdev)
mdiobus_unregister(priv->mdio);
mdiobus_free(priv->mdio);
}
- if (priv->clk)
- clk_disable_unprepare(priv->clk);
+ clk_disable_unprepare(priv->clk);
unregister_netdev(netdev);
free_netdev(netdev);
}
--
2.7.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare
2018-05-16 11:18 [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare YueHaibing
@ 2018-05-16 15:00 ` Tobias Klauser
2018-05-16 18:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Tobias Klauser @ 2018-05-16 15:00 UTC (permalink / raw)
To: YueHaibing; +Cc: davem, netdev, linux-kernel
On 2018-05-16 at 13:18:22 +0200, YueHaibing <yuehaibing@huawei.com> wrote:
> clk_disable_unprepare() already checks that the clock pointer is valid.
> No need to test it before calling it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Reviewed-by: Tobias Klauser <tklauser@distanz.ch>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare
2018-05-16 11:18 [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare YueHaibing
2018-05-16 15:00 ` Tobias Klauser
@ 2018-05-16 18:47 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2018-05-16 18:47 UTC (permalink / raw)
To: yuehaibing; +Cc: tklauser, netdev, linux-kernel
From: YueHaibing <yuehaibing@huawei.com>
Date: Wed, 16 May 2018 19:18:22 +0800
> clk_disable_unprepare() already checks that the clock pointer is valid.
> No need to test it before calling it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-16 18:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-16 11:18 [PATCH net-next] net: ethoc: Remove useless test before clk_disable_unprepare YueHaibing
2018-05-16 15:00 ` Tobias Klauser
2018-05-16 18:47 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.