From: Tiwei Bie <tiwei.bie@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, alex.williamson@redhat.com,
pbonzini@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
virtio-dev@lists.oasis-open.org, cunming.liang@intel.com,
dan.daly@intel.com, jianfeng.tan@intel.com,
zhihong.wang@intel.com, xiao.w.wang@intel.com
Subject: Re: [Qemu-devel] [PATCH v3 2/6] vhost-user: introduce shared vhost-user state
Date: Thu, 24 May 2018 15:03:28 +0800 [thread overview]
Message-ID: <20180524070328.GA15430@debian> (raw)
In-Reply-To: <20180524022440.GA20792@debian>
On Thu, May 24, 2018 at 10:24:40AM +0800, Tiwei Bie wrote:
[...]
> > > +
> > > qemu_purge_queued_packets(nc);
> > > }
> > >
> > > @@ -341,7 +342,6 @@ err:
> > > if (user) {
> > > vhost_user_cleanup(user);
> > > g_free(user);
> > > - s->vhost_user = NULL;
>
> I don't get why cannot zero it in this case.
Hmm.. Please just ignore above comment.
Thanks for catching this bug!
Best regards,
Tiwei Bie
WARNING: multiple messages have this Message-ID (diff)
From: Tiwei Bie <tiwei.bie@intel.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: jasowang@redhat.com, alex.williamson@redhat.com,
pbonzini@redhat.com, stefanha@redhat.com, qemu-devel@nongnu.org,
virtio-dev@lists.oasis-open.org, cunming.liang@intel.com,
dan.daly@intel.com, jianfeng.tan@intel.com,
zhihong.wang@intel.com, xiao.w.wang@intel.com
Subject: [virtio-dev] Re: [PATCH v3 2/6] vhost-user: introduce shared vhost-user state
Date: Thu, 24 May 2018 15:03:28 +0800 [thread overview]
Message-ID: <20180524070328.GA15430@debian> (raw)
In-Reply-To: <20180524022440.GA20792@debian>
On Thu, May 24, 2018 at 10:24:40AM +0800, Tiwei Bie wrote:
[...]
> > > +
> > > qemu_purge_queued_packets(nc);
> > > }
> > >
> > > @@ -341,7 +342,6 @@ err:
> > > if (user) {
> > > vhost_user_cleanup(user);
> > > g_free(user);
> > > - s->vhost_user = NULL;
>
> I don't get why cannot zero it in this case.
Hmm.. Please just ignore above comment.
Thanks for catching this bug!
Best regards,
Tiwei Bie
---------------------------------------------------------------------
To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org
For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2018-05-24 7:03 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-12 15:12 [Qemu-devel] [PATCH v3 0/6] Extend vhost-user to support registering external host notifiers Tiwei Bie
2018-04-12 15:12 ` [virtio-dev] " Tiwei Bie
2018-04-12 15:12 ` [Qemu-devel] [PATCH v3 1/6] vhost-user: add Net prefix to internal state structure Tiwei Bie
2018-04-12 15:12 ` [virtio-dev] " Tiwei Bie
2018-04-12 15:12 ` [Qemu-devel] [PATCH v3 2/6] vhost-user: introduce shared vhost-user state Tiwei Bie
2018-04-12 15:12 ` [virtio-dev] " Tiwei Bie
2018-05-23 13:44 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-23 13:44 ` [virtio-dev] " Michael S. Tsirkin
2018-05-23 15:36 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-23 15:36 ` [virtio-dev] " Michael S. Tsirkin
2018-05-23 15:43 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-23 15:43 ` [virtio-dev] " Michael S. Tsirkin
2018-05-23 23:21 ` [Qemu-devel] " Tiwei Bie
2018-05-23 23:21 ` [virtio-dev] " Tiwei Bie
2018-05-24 2:24 ` [Qemu-devel] " Tiwei Bie
2018-05-24 2:24 ` [virtio-dev] " Tiwei Bie
2018-05-24 7:03 ` Tiwei Bie [this message]
2018-05-24 7:03 ` Tiwei Bie
2018-05-24 10:59 ` [Qemu-devel] " Tiwei Bie
2018-05-24 10:59 ` [virtio-dev] " Tiwei Bie
2018-05-24 13:55 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-24 13:55 ` [virtio-dev] " Michael S. Tsirkin
2018-05-24 14:54 ` [Qemu-devel] " Tiwei Bie
2018-05-24 14:54 ` Tiwei Bie
2018-05-24 14:30 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-24 14:30 ` [virtio-dev] " Michael S. Tsirkin
2018-05-24 15:22 ` [Qemu-devel] " Tiwei Bie
2018-05-24 15:22 ` [virtio-dev] " Tiwei Bie
2018-05-24 13:50 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-24 13:50 ` [virtio-dev] " Michael S. Tsirkin
2018-04-12 15:12 ` [Qemu-devel] [PATCH v3 3/6] vhost-user: support receiving file descriptors in slave_read Tiwei Bie
2018-04-12 15:12 ` [virtio-dev] " Tiwei Bie
2018-05-23 21:25 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-23 21:25 ` [virtio-dev] " Michael S. Tsirkin
2018-05-23 23:12 ` [Qemu-devel] " Tiwei Bie
2018-05-23 23:12 ` Tiwei Bie
2018-05-24 13:48 ` [Qemu-devel] " Michael S. Tsirkin
2018-05-24 13:48 ` Michael S. Tsirkin
2018-05-24 14:56 ` [Qemu-devel] " Tiwei Bie
2018-05-24 14:56 ` Tiwei Bie
2018-04-12 15:12 ` [Qemu-devel] [PATCH v3 4/6] virtio: support setting memory region based host notifier Tiwei Bie
2018-04-12 15:12 ` [virtio-dev] " Tiwei Bie
2018-04-12 15:12 ` [Qemu-devel] [PATCH v3 5/6] vhost: allow backends to filter memory sections Tiwei Bie
2018-04-12 15:12 ` [virtio-dev] " Tiwei Bie
2018-04-12 15:12 ` [Qemu-devel] [PATCH v3 6/6] vhost-user: support registering external host notifiers Tiwei Bie
2018-04-12 15:12 ` [virtio-dev] " Tiwei Bie
2018-04-18 16:34 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-18 16:34 ` [virtio-dev] " Michael S. Tsirkin
2018-04-19 11:14 ` [Qemu-devel] " Tiwei Bie
2018-04-19 11:14 ` [virtio-dev] " Tiwei Bie
2018-04-19 12:43 ` [Qemu-devel] " Liang, Cunming
2018-04-19 12:43 ` [virtio-dev] " Liang, Cunming
2018-04-19 13:02 ` [Qemu-devel] " Paolo Bonzini
2018-04-19 13:02 ` Paolo Bonzini
2018-04-19 15:19 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 15:19 ` Michael S. Tsirkin
2018-04-19 15:51 ` [Qemu-devel] " Paolo Bonzini
2018-04-19 15:51 ` Paolo Bonzini
2018-04-19 15:59 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 15:59 ` Michael S. Tsirkin
2018-04-19 16:07 ` [Qemu-devel] " Paolo Bonzini
2018-04-19 16:07 ` Paolo Bonzini
2018-04-19 16:48 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 16:48 ` Michael S. Tsirkin
2018-04-19 16:24 ` [Qemu-devel] " Liang, Cunming
2018-04-19 16:24 ` Liang, Cunming
2018-04-19 16:55 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 16:55 ` Michael S. Tsirkin
2018-04-20 3:01 ` [Qemu-devel] " Liang, Cunming
2018-04-20 3:01 ` Liang, Cunming
2018-04-19 15:42 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 15:42 ` [virtio-dev] " Michael S. Tsirkin
2018-04-19 15:52 ` [Qemu-devel] " Paolo Bonzini
2018-04-19 15:52 ` [virtio-dev] " Paolo Bonzini
2018-04-19 16:34 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 16:34 ` [virtio-dev] " Michael S. Tsirkin
2018-04-19 16:52 ` [Qemu-devel] " Liang, Cunming
2018-04-19 16:52 ` [virtio-dev] " Liang, Cunming
2018-04-19 16:59 ` [Qemu-devel] " Paolo Bonzini
2018-04-19 16:59 ` Paolo Bonzini
2018-04-19 17:27 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 17:27 ` Michael S. Tsirkin
2018-04-19 17:35 ` [Qemu-devel] " Paolo Bonzini
2018-04-19 17:35 ` Paolo Bonzini
2018-04-19 17:39 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 17:39 ` Michael S. Tsirkin
2018-04-19 17:00 ` [Qemu-devel] " Michael S. Tsirkin
2018-04-19 17:00 ` [virtio-dev] " Michael S. Tsirkin
2018-04-19 23:05 ` [Qemu-devel] " Liang, Cunming
2018-04-19 23:05 ` [virtio-dev] " Liang, Cunming
2018-04-19 16:27 ` [Qemu-devel] " Liang, Cunming
2018-04-19 16:27 ` [virtio-dev] " Liang, Cunming
2018-05-02 10:32 ` [Qemu-devel] " Tiwei Bie
2018-05-02 10:32 ` [virtio-dev] " Tiwei Bie
2018-05-16 1:41 ` [Qemu-devel] [PATCH v3 0/6] Extend vhost-user to " Michael S. Tsirkin
2018-05-16 1:41 ` [virtio-dev] " Michael S. Tsirkin
2018-05-16 1:56 ` [Qemu-devel] " Tiwei Bie
2018-05-16 1:56 ` [virtio-dev] " Tiwei Bie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180524070328.GA15430@debian \
--to=tiwei.bie@intel.com \
--cc=alex.williamson@redhat.com \
--cc=cunming.liang@intel.com \
--cc=dan.daly@intel.com \
--cc=jasowang@redhat.com \
--cc=jianfeng.tan@intel.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=virtio-dev@lists.oasis-open.org \
--cc=xiao.w.wang@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.