From: Jason Yan <yanaijie@huawei.com> To: <martin.petersen@oracle.com>, <jejb@linux.vnet.ibm.com> Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <john.garry@huawei.com>, <zhaohongjiang@huawei.com>, <hare@suse.com>, <dan.j.williams@intel.com>, <jthumshirn@suse.de>, <hch@lst.de>, <huangdaode@hisilicon.com>, <chenxiang66@hisilicon.com>, <xiexiuqi@huawei.com>, <tj@kernel.org>, <miaoxie@huawei.com>, Jason Yan <yanaijie@huawei.com> Subject: [PATCH 0/8] libsas: Support swapping disks and SATA phy link rate matching the pathway Date: Tue, 29 May 2018 10:23:01 +0800 [thread overview] Message-ID: <20180529022309.21071-1-yanaijie@huawei.com> (raw) The work flow of revalidation now is scanning expander phy by the sequence of the phy and check if the phy have changed. This will leads to some issues of swapping disks or replacing a disk with a new one. And when an expander phy attached to a SATA phy is using a physical link rate greater than the expander host phys's linkrate, the disk will failed to be discovered(ATA commands all failed). This is described in sas protocal spec as: "If an expander phy attached to a SATA phy is using a physical link rate greater than the maximum connection rate supported by the pathway from an STP initiator port, a management application client should use the SMP PHY CONTROL function (see 10.4.3.10) to set the PROGRAMMED MAXIMUM PHYSICAL LINK RATE field of the expander phy to the maximum connection rate supported by the pathway from that STP initiator port." This patchset addresses the issues above by these main changes: 1. Let the revalidation first scan all phys, mark all changed phys, then revalidate in two steps. First check if we need to unregister some devices. if we need to unregister some devices, raise a new bcast and return. Second, if no devices need to be unregistered, discover new devices. 2. Check the SATA phy's linkrate to see if it is greater than any phy's linkrate it may pass through. Remember the minimum linkrate of the pathway and set the SATA phy linkrate to it using the SMP PHY CONTROL function. 3. Other changes such as checking the ata devices class and id to ensure the same device after flutter and so on. Jason Yan (8): scsi: libsas: delete dead code in scsi_transport_sas.c scsi: libsas: check the lldd callback correctly scsi: libsas: always unregister the old device if going to discover new scsi: libsas: trigger a new revalidation to discover the device scsi: libsas: check if the same sata device when flutter scsi: libsas: reset the phy state and address if discover failed scsi: libsas: fix issue of swapping two sas disks scsi: libsas: support SATA phy link rate unmatch the pathway drivers/ata/libata-core.c | 3 +- drivers/scsi/libsas/sas_ata.c | 131 ++++++++++++++++++++++++ drivers/scsi/libsas/sas_discover.c | 4 +- drivers/scsi/libsas/sas_expander.c | 198 +++++++++++++++++++++++++++++-------- drivers/scsi/libsas/sas_port.c | 2 + drivers/scsi/scsi_transport_sas.c | 2 - include/linux/libata.h | 2 + include/scsi/libsas.h | 1 + include/scsi/sas_ata.h | 6 ++ 9 files changed, 305 insertions(+), 44 deletions(-) -- 2.13.6
WARNING: multiple messages have this Message-ID (diff)
From: Jason Yan <yanaijie@huawei.com> To: martin.petersen@oracle.com, jejb@linux.vnet.ibm.com Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, john.garry@huawei.com, zhaohongjiang@huawei.com, hare@suse.com, dan.j.williams@intel.com, jthumshirn@suse.de, hch@lst.de, huangdaode@hisilicon.com, chenxiang66@hisilicon.com, xiexiuqi@huawei.com, tj@kernel.org, miaoxie@huawei.com, Jason Yan <yanaijie@huawei.com> Subject: [PATCH 0/8] libsas: Support swapping disks and SATA phy link rate matching the pathway Date: Tue, 29 May 2018 10:23:01 +0800 [thread overview] Message-ID: <20180529022309.21071-1-yanaijie@huawei.com> (raw) The work flow of revalidation now is scanning expander phy by the sequence of the phy and check if the phy have changed. This will leads to some issues of swapping disks or replacing a disk with a new one. And when an expander phy attached to a SATA phy is using a physical link rate greater than the expander host phys's linkrate, the disk will failed to be discovered(ATA commands all failed). This is described in sas protocal spec as: "If an expander phy attached to a SATA phy is using a physical link rate greater than the maximum connection rate supported by the pathway from an STP initiator port, a management application client should use the SMP PHY CONTROL function (see 10.4.3.10) to set the PROGRAMMED MAXIMUM PHYSICAL LINK RATE field of the expander phy to the maximum connection rate supported by the pathway from that STP initiator port." This patchset addresses the issues above by these main changes: 1. Let the revalidation first scan all phys, mark all changed phys, then revalidate in two steps. First check if we need to unregister some devices. if we need to unregister some devices, raise a new bcast and return. Second, if no devices need to be unregistered, discover new devices. 2. Check the SATA phy's linkrate to see if it is greater than any phy's linkrate it may pass through. Remember the minimum linkrate of the pathway and set the SATA phy linkrate to it using the SMP PHY CONTROL function. 3. Other changes such as checking the ata devices class and id to ensure the same device after flutter and so on. Jason Yan (8): scsi: libsas: delete dead code in scsi_transport_sas.c scsi: libsas: check the lldd callback correctly scsi: libsas: always unregister the old device if going to discover new scsi: libsas: trigger a new revalidation to discover the device scsi: libsas: check if the same sata device when flutter scsi: libsas: reset the phy state and address if discover failed scsi: libsas: fix issue of swapping two sas disks scsi: libsas: support SATA phy link rate unmatch the pathway drivers/ata/libata-core.c | 3 +- drivers/scsi/libsas/sas_ata.c | 131 ++++++++++++++++++++++++ drivers/scsi/libsas/sas_discover.c | 4 +- drivers/scsi/libsas/sas_expander.c | 198 +++++++++++++++++++++++++++++-------- drivers/scsi/libsas/sas_port.c | 2 + drivers/scsi/scsi_transport_sas.c | 2 - include/linux/libata.h | 2 + include/scsi/libsas.h | 1 + include/scsi/sas_ata.h | 6 ++ 9 files changed, 305 insertions(+), 44 deletions(-) -- 2.13.6
next reply other threads:[~2018-05-29 2:14 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-29 2:23 Jason Yan [this message] 2018-05-29 2:23 ` [PATCH 0/8] libsas: Support swapping disks and SATA phy link rate matching the pathway Jason Yan 2018-05-29 2:23 ` [PATCH 1/8] scsi: libsas: delete dead code in scsi_transport_sas.c Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-29 7:33 ` Johannes Thumshirn 2018-05-31 14:26 ` John Garry 2018-05-31 14:26 ` John Garry 2018-05-29 2:23 ` [PATCH 2/8] scsi: libsas: check the lldd callback correctly Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-29 7:34 ` Johannes Thumshirn 2018-05-31 14:09 ` John Garry 2018-05-31 14:09 ` John Garry 2018-06-01 0:15 ` Jason Yan 2018-06-01 0:15 ` Jason Yan 2018-05-29 2:23 ` [PATCH 3/8] scsi: libsas: always unregister the old device if going to discover new Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-29 7:37 ` Johannes Thumshirn 2018-05-31 15:09 ` John Garry 2018-05-31 15:09 ` John Garry 2018-06-01 0:28 ` Jason Yan 2018-06-01 0:28 ` Jason Yan 2018-05-29 2:23 ` [PATCH 4/8] scsi: libsas: trigger a new revalidation to discover the device Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-29 7:43 ` Johannes Thumshirn 2018-05-31 15:42 ` John Garry 2018-05-31 15:42 ` John Garry 2018-06-01 0:59 ` Jason Yan 2018-06-01 0:59 ` Jason Yan 2018-06-01 10:02 ` John Garry 2018-06-01 10:02 ` John Garry 2018-06-04 1:01 ` Jason Yan 2018-06-04 1:01 ` Jason Yan 2018-05-29 2:23 ` [PATCH 5/8] scsi: libsas: check if the same sata device when flutter Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-29 2:23 ` [PATCH 6/8] scsi: libsas: reset the phy state and address if discover failed Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-29 2:23 ` [PATCH 7/8] scsi: libsas: fix issue of swapping two sas disks Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-29 2:23 ` [PATCH 8/8] scsi: libsas: support SATA phy link rate unmatch the pathway Jason Yan 2018-05-29 2:23 ` Jason Yan 2018-05-31 16:05 ` John Garry 2018-05-31 16:05 ` John Garry 2018-06-01 1:21 ` Jason Yan 2018-06-01 1:21 ` Jason Yan 2018-06-01 10:13 ` John Garry 2018-06-01 10:13 ` John Garry
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180529022309.21071-1-yanaijie@huawei.com \ --to=yanaijie@huawei.com \ --cc=chenxiang66@hisilicon.com \ --cc=dan.j.williams@intel.com \ --cc=hare@suse.com \ --cc=hch@lst.de \ --cc=huangdaode@hisilicon.com \ --cc=jejb@linux.vnet.ibm.com \ --cc=john.garry@huawei.com \ --cc=jthumshirn@suse.de \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=miaoxie@huawei.com \ --cc=tj@kernel.org \ --cc=xiexiuqi@huawei.com \ --cc=zhaohongjiang@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.