* [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform
@ 2018-06-14 23:37 José Roberto de Souza
2018-06-14 23:37 ` [PATCH v2 2/2] drm/i915/aml: Introducing Amber " José Roberto de Souza
` (4 more replies)
0 siblings, 5 replies; 7+ messages in thread
From: José Roberto de Souza @ 2018-06-14 23:37 UTC (permalink / raw)
To: intel-gfx; +Cc: Rodrigo Vivi
Whiskey Lake uses the same gen graphics as Coffe Lake, including some
ids that were previously marked as reserved on Coffe Lake, but that
now are moved to WHL page.
So, let's just move them to WHL macros that will feed into CFL macro
just to keep it better organized to make easier future code review
but it will be handled as a CFL.
v2:
Fixing GT level of some ids
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_pci.c | 4 +++-
include/drm/i915_pciids.h | 28 ++++++++++++++++++----------
2 files changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 97a91e6af7e3..92e98773e53d 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -660,9 +660,11 @@ static const struct pci_device_id pciidlist[] = {
INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
- INTEL_CFL_U_GT1_IDS(&intel_coffeelake_gt1_info),
INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info),
INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info),
+ INTEL_WHL_U_GT1_IDS(&intel_coffeelake_gt1_info),
+ INTEL_WHL_U_GT2_IDS(&intel_coffeelake_gt2_info),
+ INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
INTEL_CNL_IDS(&intel_cannonlake_info),
INTEL_ICL_11_IDS(&intel_icelake_11_info),
{0, 0, 0}
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index bab70ff6e78b..d03350a38025 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -388,32 +388,40 @@
INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
-/* CFL U GT1 */
-#define INTEL_CFL_U_GT1_IDS(info) \
- INTEL_VGA_DEVICE(0x3EA1, info), \
- INTEL_VGA_DEVICE(0x3EA4, info)
-
/* CFL U GT2 */
#define INTEL_CFL_U_GT2_IDS(info) \
- INTEL_VGA_DEVICE(0x3EA0, info), \
- INTEL_VGA_DEVICE(0x3EA3, info), \
INTEL_VGA_DEVICE(0x3EA9, info)
/* CFL U GT3 */
#define INTEL_CFL_U_GT3_IDS(info) \
- INTEL_VGA_DEVICE(0x3EA2, info), /* ULT GT3 */ \
INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
+/* WHL/CFL U GT1 */
+#define INTEL_WHL_U_GT1_IDS(info) \
+ INTEL_VGA_DEVICE(0x3EA1, info)
+
+/* WHL/CFL U GT2 */
+#define INTEL_WHL_U_GT2_IDS(info) \
+ INTEL_VGA_DEVICE(0x3EA0, info)
+
+/* WHL/CFL U GT3 */
+#define INTEL_WHL_U_GT3_IDS(info) \
+ INTEL_VGA_DEVICE(0x3EA2, info), \
+ INTEL_VGA_DEVICE(0x3EA3, info), \
+ INTEL_VGA_DEVICE(0x3EA4, info)
+
#define INTEL_CFL_IDS(info) \
INTEL_CFL_S_GT1_IDS(info), \
INTEL_CFL_S_GT2_IDS(info), \
INTEL_CFL_H_GT2_IDS(info), \
- INTEL_CFL_U_GT1_IDS(info), \
INTEL_CFL_U_GT2_IDS(info), \
- INTEL_CFL_U_GT3_IDS(info)
+ INTEL_CFL_U_GT3_IDS(info), \
+ INTEL_WHL_U_GT1_IDS(info), \
+ INTEL_WHL_U_GT2_IDS(info), \
+ INTEL_WHL_U_GT3_IDS(info)
/* CNL */
#define INTEL_CNL_IDS(info) \
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH v2 2/2] drm/i915/aml: Introducing Amber Lake platform
2018-06-14 23:37 [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform José Roberto de Souza
@ 2018-06-14 23:37 ` José Roberto de Souza
2018-06-14 23:55 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey " Patchwork
` (3 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: José Roberto de Souza @ 2018-06-14 23:37 UTC (permalink / raw)
To: intel-gfx
Amber Lake uses the same gen graphics as Kaby Lake, including a id
that were previously marked as reserved on Kaby Lake, but that
now is moved to AML page.
So, let's just move it to AML macro that will feed into KBL macro
just to keep it better organized to make easier future code review
but it will be handled as a KBL.
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
---
drivers/gpu/drm/i915/i915_pci.c | 1 +
include/drm/i915_pciids.h | 9 +++++++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 92e98773e53d..55543f1b0236 100644
--- a/drivers/gpu/drm/i915/i915_pci.c
+++ b/drivers/gpu/drm/i915/i915_pci.c
@@ -657,6 +657,7 @@ static const struct pci_device_id pciidlist[] = {
INTEL_KBL_GT2_IDS(&intel_kabylake_gt2_info),
INTEL_KBL_GT3_IDS(&intel_kabylake_gt3_info),
INTEL_KBL_GT4_IDS(&intel_kabylake_gt3_info),
+ INTEL_AML_GT2_IDS(&intel_kabylake_gt2_info),
INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
index d03350a38025..fbf5cfc9b352 100644
--- a/include/drm/i915_pciids.h
+++ b/include/drm/i915_pciids.h
@@ -349,7 +349,6 @@
#define INTEL_KBL_GT2_IDS(info) \
INTEL_VGA_DEVICE(0x5916, info), /* ULT GT2 */ \
INTEL_VGA_DEVICE(0x5917, info), /* Mobile GT2 */ \
- INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
INTEL_VGA_DEVICE(0x5921, info), /* ULT GT2F */ \
INTEL_VGA_DEVICE(0x591E, info), /* ULX GT2 */ \
INTEL_VGA_DEVICE(0x5912, info), /* DT GT2 */ \
@@ -365,11 +364,17 @@
#define INTEL_KBL_GT4_IDS(info) \
INTEL_VGA_DEVICE(0x593B, info) /* Halo GT4 */
+/* AML/KBL Y GT2 */
+#define INTEL_AML_GT2_IDS(info) \
+ INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
+ INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
+
#define INTEL_KBL_IDS(info) \
INTEL_KBL_GT1_IDS(info), \
INTEL_KBL_GT2_IDS(info), \
INTEL_KBL_GT3_IDS(info), \
- INTEL_KBL_GT4_IDS(info)
+ INTEL_KBL_GT4_IDS(info), \
+ INTEL_AML_GT2_IDS(info)
/* CFL S */
#define INTEL_CFL_S_GT1_IDS(info) \
--
2.17.1
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey Lake platform
2018-06-14 23:37 [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform José Roberto de Souza
2018-06-14 23:37 ` [PATCH v2 2/2] drm/i915/aml: Introducing Amber " José Roberto de Souza
@ 2018-06-14 23:55 ` Patchwork
2018-06-14 23:59 ` [PATCH v2 1/2] " Rodrigo Vivi
` (2 subsequent siblings)
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-14 23:55 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey Lake platform
URL : https://patchwork.freedesktop.org/series/44787/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
7cf5c8bc3840 drm/i915/whl: Introducing Whiskey Lake platform
-:76: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#76: FILE: include/drm/i915_pciids.h:411:
+#define INTEL_WHL_U_GT3_IDS(info) \
+ INTEL_VGA_DEVICE(0x3EA2, info), \
+ INTEL_VGA_DEVICE(0x3EA3, info), \
+ INTEL_VGA_DEVICE(0x3EA4, info)
-:76: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#76: FILE: include/drm/i915_pciids.h:411:
+#define INTEL_WHL_U_GT3_IDS(info) \
+ INTEL_VGA_DEVICE(0x3EA2, info), \
+ INTEL_VGA_DEVICE(0x3EA3, info), \
+ INTEL_VGA_DEVICE(0x3EA4, info)
total: 1 errors, 0 warnings, 1 checks, 62 lines checked
06a369a6e01a drm/i915/aml: Introducing Amber Lake platform
-:49: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#49: FILE: include/drm/i915_pciids.h:368:
+#define INTEL_AML_GT2_IDS(info) \
+ INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
+ INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
-:49: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'info' - possible side-effects?
#49: FILE: include/drm/i915_pciids.h:368:
+#define INTEL_AML_GT2_IDS(info) \
+ INTEL_VGA_DEVICE(0x591C, info), /* ULX GT2 */ \
+ INTEL_VGA_DEVICE(0x87C0, info) /* ULX GT2 */
total: 1 errors, 0 warnings, 1 checks, 32 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform
2018-06-14 23:37 [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform José Roberto de Souza
2018-06-14 23:37 ` [PATCH v2 2/2] drm/i915/aml: Introducing Amber " José Roberto de Souza
2018-06-14 23:55 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey " Patchwork
@ 2018-06-14 23:59 ` Rodrigo Vivi
2018-06-18 17:51 ` Rodrigo Vivi
2018-06-15 0:15 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
2018-06-15 8:59 ` ✓ Fi.CI.IGT: " Patchwork
4 siblings, 1 reply; 7+ messages in thread
From: Rodrigo Vivi @ 2018-06-14 23:59 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Thu, Jun 14, 2018 at 04:37:19PM -0700, José Roberto de Souza wrote:
> Whiskey Lake uses the same gen graphics as Coffe Lake, including some
> ids that were previously marked as reserved on Coffe Lake, but that
> now are moved to WHL page.
>
> So, let's just move them to WHL macros that will feed into CFL macro
> just to keep it better organized to make easier future code review
> but it will be handled as a CFL.
>
> v2:
> Fixing GT level of some ids
>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> ---
> drivers/gpu/drm/i915/i915_pci.c | 4 +++-
> include/drm/i915_pciids.h | 28 ++++++++++++++++++----------
> 2 files changed, 21 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> index 97a91e6af7e3..92e98773e53d 100644
> --- a/drivers/gpu/drm/i915/i915_pci.c
> +++ b/drivers/gpu/drm/i915/i915_pci.c
> @@ -660,9 +660,11 @@ static const struct pci_device_id pciidlist[] = {
> INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
> INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
> INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
> - INTEL_CFL_U_GT1_IDS(&intel_coffeelake_gt1_info),
> INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info),
> INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info),
> + INTEL_WHL_U_GT1_IDS(&intel_coffeelake_gt1_info),
> + INTEL_WHL_U_GT2_IDS(&intel_coffeelake_gt2_info),
> + INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
> INTEL_CNL_IDS(&intel_cannonlake_info),
> INTEL_ICL_11_IDS(&intel_icelake_11_info),
> {0, 0, 0}
> diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> index bab70ff6e78b..d03350a38025 100644
> --- a/include/drm/i915_pciids.h
> +++ b/include/drm/i915_pciids.h
> @@ -388,32 +388,40 @@
> INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
> INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
>
> -/* CFL U GT1 */
> -#define INTEL_CFL_U_GT1_IDS(info) \
> - INTEL_VGA_DEVICE(0x3EA1, info), \
> - INTEL_VGA_DEVICE(0x3EA4, info)
> -
> /* CFL U GT2 */
> #define INTEL_CFL_U_GT2_IDS(info) \
> - INTEL_VGA_DEVICE(0x3EA0, info), \
> - INTEL_VGA_DEVICE(0x3EA3, info), \
> INTEL_VGA_DEVICE(0x3EA9, info)
>
> /* CFL U GT3 */
> #define INTEL_CFL_U_GT3_IDS(info) \
> - INTEL_VGA_DEVICE(0x3EA2, info), /* ULT GT3 */ \
> INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
> INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
> INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
> INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
>
> +/* WHL/CFL U GT1 */
> +#define INTEL_WHL_U_GT1_IDS(info) \
> + INTEL_VGA_DEVICE(0x3EA1, info)
> +
> +/* WHL/CFL U GT2 */
> +#define INTEL_WHL_U_GT2_IDS(info) \
> + INTEL_VGA_DEVICE(0x3EA0, info)
> +
> +/* WHL/CFL U GT3 */
> +#define INTEL_WHL_U_GT3_IDS(info) \
> + INTEL_VGA_DEVICE(0x3EA2, info), \
> + INTEL_VGA_DEVICE(0x3EA3, info), \
> + INTEL_VGA_DEVICE(0x3EA4, info)
> +
> #define INTEL_CFL_IDS(info) \
> INTEL_CFL_S_GT1_IDS(info), \
> INTEL_CFL_S_GT2_IDS(info), \
> INTEL_CFL_H_GT2_IDS(info), \
> - INTEL_CFL_U_GT1_IDS(info), \
> INTEL_CFL_U_GT2_IDS(info), \
> - INTEL_CFL_U_GT3_IDS(info)
> + INTEL_CFL_U_GT3_IDS(info), \
> + INTEL_WHL_U_GT1_IDS(info), \
> + INTEL_WHL_U_GT2_IDS(info), \
> + INTEL_WHL_U_GT3_IDS(info)
>
> /* CNL */
> #define INTEL_CNL_IDS(info) \
> --
> 2.17.1
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey Lake platform
2018-06-14 23:37 [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform José Roberto de Souza
` (2 preceding siblings ...)
2018-06-14 23:59 ` [PATCH v2 1/2] " Rodrigo Vivi
@ 2018-06-15 0:15 ` Patchwork
2018-06-15 8:59 ` ✓ Fi.CI.IGT: " Patchwork
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-15 0:15 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey Lake platform
URL : https://patchwork.freedesktop.org/series/44787/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4322 -> Patchwork_9315 =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9315 need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9315, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://patchwork.freedesktop.org/api/1.0/series/44787/revisions/1/mbox/
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9315:
=== IGT changes ===
==== Warnings ====
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
fi-glk-j4005: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9315 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_gttfill@basic:
fi-byt-n2820: PASS -> FAIL (fdo#106744)
igt@kms_flip@basic-flip-vs-modeset:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106000) +1
igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
fi-glk-j4005: PASS -> DMESG-WARN (fdo#106097) +1
==== Possible fixes ====
igt@drv_module_reload@basic-no-display:
fi-glk-j4005: DMESG-WARN (fdo#106725) -> PASS
igt@kms_flip@basic-flip-vs-wf_vblank:
fi-glk-j4005: FAIL (fdo#103928) -> PASS
igt@kms_flip@basic-plain-flip:
fi-glk-j4005: DMESG-WARN (fdo#106000) -> PASS
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#106000 https://bugs.freedesktop.org/show_bug.cgi?id=106000
fdo#106097 https://bugs.freedesktop.org/show_bug.cgi?id=106097
fdo#106725 https://bugs.freedesktop.org/show_bug.cgi?id=106725
fdo#106744 https://bugs.freedesktop.org/show_bug.cgi?id=106744
== Participating hosts (43 -> 38) ==
Missing (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u
== Build changes ==
* Linux: CI_DRM_4322 -> Patchwork_9315
CI_DRM_4322: 485f975b0c64f2a3c9b0bf116a63adc3c6389b1f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4519: 3381a56be31defb3b5c23a4fbc19ac26a000c35b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9315: 06a369a6e01a43eb549615bf08acd2651756b06d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
06a369a6e01a drm/i915/aml: Introducing Amber Lake platform
7cf5c8bc3840 drm/i915/whl: Introducing Whiskey Lake platform
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9315/issues.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.IGT: success for series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey Lake platform
2018-06-14 23:37 [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform José Roberto de Souza
` (3 preceding siblings ...)
2018-06-15 0:15 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
@ 2018-06-15 8:59 ` Patchwork
4 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2018-06-15 8:59 UTC (permalink / raw)
To: Souza, Jose; +Cc: intel-gfx
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey Lake platform
URL : https://patchwork.freedesktop.org/series/44787/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4322_full -> Patchwork_9315_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_9315_full need to be verified
manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_9315_full, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_9315_full:
=== IGT changes ===
==== Warnings ====
igt@gem_exec_schedule@deep-vebox:
shard-kbl: PASS -> SKIP
== Known issues ==
Here are the changes found in Patchwork_9315_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@drv_hangman@error-state-capture-render:
shard-snb: PASS -> FAIL (fdo#106847)
igt@gem_exec_suspend@basic-s3:
shard-kbl: PASS -> INCOMPLETE (fdo#103665)
igt@gem_ppgtt@blt-vs-render-ctx0:
shard-kbl: PASS -> INCOMPLETE (fdo#103665, fdo#106023)
igt@kms_flip_tiling@flip-x-tiled:
shard-glk: PASS -> FAIL (fdo#103822, fdo#104724) +1
==== Possible fixes ====
igt@drv_selftest@live_gtt:
shard-kbl: INCOMPLETE (fdo#103665) -> PASS
igt@gem_exec_big:
shard-hsw: INCOMPLETE (fdo#103540) -> PASS
igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
shard-hsw: FAIL (fdo#100368) -> PASS
shard-glk: FAIL (fdo#100368) -> PASS +1
igt@kms_flip@plain-flip-ts-check:
shard-hsw: FAIL (fdo#103928) -> PASS
igt@kms_setmode@basic:
shard-apl: FAIL (fdo#99912) -> PASS
igt@prime_busy@wait-after-bsd:
shard-snb: INCOMPLETE (fdo#105411) -> SKIP
igt@testdisplay:
shard-kbl: WARN (fdo#106354) -> PASS
fdo#100368 https://bugs.freedesktop.org/show_bug.cgi?id=100368
fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
fdo#103822 https://bugs.freedesktop.org/show_bug.cgi?id=103822
fdo#103928 https://bugs.freedesktop.org/show_bug.cgi?id=103928
fdo#104724 https://bugs.freedesktop.org/show_bug.cgi?id=104724
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
fdo#106354 https://bugs.freedesktop.org/show_bug.cgi?id=106354
fdo#106847 https://bugs.freedesktop.org/show_bug.cgi?id=106847
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (5 -> 5) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4322 -> Patchwork_9315
CI_DRM_4322: 485f975b0c64f2a3c9b0bf116a63adc3c6389b1f @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4519: 3381a56be31defb3b5c23a4fbc19ac26a000c35b @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_9315: 06a369a6e01a43eb549615bf08acd2651756b06d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_9315/shards.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform
2018-06-14 23:59 ` [PATCH v2 1/2] " Rodrigo Vivi
@ 2018-06-18 17:51 ` Rodrigo Vivi
0 siblings, 0 replies; 7+ messages in thread
From: Rodrigo Vivi @ 2018-06-18 17:51 UTC (permalink / raw)
To: José Roberto de Souza; +Cc: intel-gfx
On Thu, Jun 14, 2018 at 04:59:32PM -0700, Rodrigo Vivi wrote:
> On Thu, Jun 14, 2018 at 04:37:19PM -0700, José Roberto de Souza wrote:
> > Whiskey Lake uses the same gen graphics as Coffe Lake, including some
> > ids that were previously marked as reserved on Coffe Lake, but that
> > now are moved to WHL page.
> >
> > So, let's just move them to WHL macros that will feed into CFL macro
> > just to keep it better organized to make easier future code review
> > but it will be handled as a CFL.
> >
> > v2:
> > Fixing GT level of some ids
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
pushed to dinq, thanks.
>
> > ---
> > drivers/gpu/drm/i915/i915_pci.c | 4 +++-
> > include/drm/i915_pciids.h | 28 ++++++++++++++++++----------
> > 2 files changed, 21 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
> > index 97a91e6af7e3..92e98773e53d 100644
> > --- a/drivers/gpu/drm/i915/i915_pci.c
> > +++ b/drivers/gpu/drm/i915/i915_pci.c
> > @@ -660,9 +660,11 @@ static const struct pci_device_id pciidlist[] = {
> > INTEL_CFL_S_GT1_IDS(&intel_coffeelake_gt1_info),
> > INTEL_CFL_S_GT2_IDS(&intel_coffeelake_gt2_info),
> > INTEL_CFL_H_GT2_IDS(&intel_coffeelake_gt2_info),
> > - INTEL_CFL_U_GT1_IDS(&intel_coffeelake_gt1_info),
> > INTEL_CFL_U_GT2_IDS(&intel_coffeelake_gt2_info),
> > INTEL_CFL_U_GT3_IDS(&intel_coffeelake_gt3_info),
> > + INTEL_WHL_U_GT1_IDS(&intel_coffeelake_gt1_info),
> > + INTEL_WHL_U_GT2_IDS(&intel_coffeelake_gt2_info),
> > + INTEL_WHL_U_GT3_IDS(&intel_coffeelake_gt3_info),
> > INTEL_CNL_IDS(&intel_cannonlake_info),
> > INTEL_ICL_11_IDS(&intel_icelake_11_info),
> > {0, 0, 0}
> > diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h
> > index bab70ff6e78b..d03350a38025 100644
> > --- a/include/drm/i915_pciids.h
> > +++ b/include/drm/i915_pciids.h
> > @@ -388,32 +388,40 @@
> > INTEL_VGA_DEVICE(0x3E9B, info), /* Halo GT2 */ \
> > INTEL_VGA_DEVICE(0x3E94, info) /* Halo GT2 */
> >
> > -/* CFL U GT1 */
> > -#define INTEL_CFL_U_GT1_IDS(info) \
> > - INTEL_VGA_DEVICE(0x3EA1, info), \
> > - INTEL_VGA_DEVICE(0x3EA4, info)
> > -
> > /* CFL U GT2 */
> > #define INTEL_CFL_U_GT2_IDS(info) \
> > - INTEL_VGA_DEVICE(0x3EA0, info), \
> > - INTEL_VGA_DEVICE(0x3EA3, info), \
> > INTEL_VGA_DEVICE(0x3EA9, info)
> >
> > /* CFL U GT3 */
> > #define INTEL_CFL_U_GT3_IDS(info) \
> > - INTEL_VGA_DEVICE(0x3EA2, info), /* ULT GT3 */ \
> > INTEL_VGA_DEVICE(0x3EA5, info), /* ULT GT3 */ \
> > INTEL_VGA_DEVICE(0x3EA6, info), /* ULT GT3 */ \
> > INTEL_VGA_DEVICE(0x3EA7, info), /* ULT GT3 */ \
> > INTEL_VGA_DEVICE(0x3EA8, info) /* ULT GT3 */
> >
> > +/* WHL/CFL U GT1 */
> > +#define INTEL_WHL_U_GT1_IDS(info) \
> > + INTEL_VGA_DEVICE(0x3EA1, info)
> > +
> > +/* WHL/CFL U GT2 */
> > +#define INTEL_WHL_U_GT2_IDS(info) \
> > + INTEL_VGA_DEVICE(0x3EA0, info)
> > +
> > +/* WHL/CFL U GT3 */
> > +#define INTEL_WHL_U_GT3_IDS(info) \
> > + INTEL_VGA_DEVICE(0x3EA2, info), \
> > + INTEL_VGA_DEVICE(0x3EA3, info), \
> > + INTEL_VGA_DEVICE(0x3EA4, info)
> > +
> > #define INTEL_CFL_IDS(info) \
> > INTEL_CFL_S_GT1_IDS(info), \
> > INTEL_CFL_S_GT2_IDS(info), \
> > INTEL_CFL_H_GT2_IDS(info), \
> > - INTEL_CFL_U_GT1_IDS(info), \
> > INTEL_CFL_U_GT2_IDS(info), \
> > - INTEL_CFL_U_GT3_IDS(info)
> > + INTEL_CFL_U_GT3_IDS(info), \
> > + INTEL_WHL_U_GT1_IDS(info), \
> > + INTEL_WHL_U_GT2_IDS(info), \
> > + INTEL_WHL_U_GT3_IDS(info)
> >
> > /* CNL */
> > #define INTEL_CNL_IDS(info) \
> > --
> > 2.17.1
> >
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-06-18 17:51 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-06-14 23:37 [PATCH v2 1/2] drm/i915/whl: Introducing Whiskey Lake platform José Roberto de Souza
2018-06-14 23:37 ` [PATCH v2 2/2] drm/i915/aml: Introducing Amber " José Roberto de Souza
2018-06-14 23:55 ` ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/2] drm/i915/whl: Introducing Whiskey " Patchwork
2018-06-14 23:59 ` [PATCH v2 1/2] " Rodrigo Vivi
2018-06-18 17:51 ` Rodrigo Vivi
2018-06-15 0:15 ` ✓ Fi.CI.BAT: success for series starting with [v2,1/2] " Patchwork
2018-06-15 8:59 ` ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.