From: kbuild test robot <lkp@intel.com> To: Rick Edgecombe <rick.p.edgecombe@intel.com> Cc: kbuild-all@01.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-hardening@lists.openwall.com, kristen.c.accardi@intel.com, dave.hansen@intel.com, arjan.van.de.ven@intel.com, Rick Edgecombe <rick.p.edgecombe@intel.com> Subject: Re: [PATCH 3/3] vmalloc: Add debugfs modfraginfo Date: Thu, 21 Jun 2018 08:53:06 +0800 [thread overview] Message-ID: <201806210843.zy4xVRmf%fengguang.wu@intel.com> (raw) In-Reply-To: <1529532570-21765-4-git-send-email-rick.p.edgecombe@intel.com> [-- Attachment #1: Type: text/plain, Size: 3149 bytes --] Hi Rick, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.18-rc1 next-20180620] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rick-Edgecombe/KASLR-feature-to-randomize-each-loadable-module/20180621-061051 base: git://git.cmpxchg.org/linux-mmotm.git master config: mips-fuloong2e_defconfig (attached as .config) compiler: mips64el-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=mips All errors (new ones prefixed by >>): mm/vmalloc.c: In function 'modulefraginfo_debug_show': >> mm/vmalloc.c:2821:27: error: 'MODULES_VADDR' undeclared (first use in this function); did you mean 'MODULE_END'? unsigned long last_end = MODULES_VADDR; ^~~~~~~~~~~~~ MODULE_END mm/vmalloc.c:2821:27: note: each undeclared identifier is reported only once for each function it appears in >> mm/vmalloc.c:2834:22: error: 'MODULES_END' undeclared (first use in this function); did you mean 'MODULE_END'? && obj->va_end <= MODULES_END) { ^~~~~~~~~~~ MODULE_END vim +2821 mm/vmalloc.c 2817 2818 static int modulefraginfo_debug_show(struct seq_file *m, void *v) 2819 { 2820 struct list_head *i; > 2821 unsigned long last_end = MODULES_VADDR; 2822 unsigned long total_free = 0; 2823 unsigned long largest_free = 0; 2824 unsigned long backup_cnt = 0; 2825 unsigned long gap; 2826 2827 spin_lock(&vmap_area_lock); 2828 2829 list_for_each(i, &vmap_area_list) { 2830 struct vmap_area *obj = list_entry(i, struct vmap_area, list); 2831 2832 if (!(obj->flags & VM_LAZY_FREE) 2833 && obj->va_start >= MODULES_VADDR > 2834 && obj->va_end <= MODULES_END) { 2835 2836 if (obj->va_start >= get_backup_start()) 2837 backup_cnt++; 2838 2839 gap = (obj->va_start - last_end); 2840 if (gap > largest_free) 2841 largest_free = gap; 2842 total_free += gap; 2843 2844 last_end = obj->va_end; 2845 } 2846 } 2847 2848 gap = (MODULES_END - last_end); 2849 if (gap > largest_free) 2850 largest_free = gap; 2851 total_free += gap; 2852 2853 spin_unlock(&vmap_area_lock); 2854 2855 seq_printf(m, "Largest free space:\t\t%lu\n", largest_free); 2856 if (total_free) 2857 seq_printf(m, "External Memory Fragementation:\t%lu%%\n", 2858 100-(100*largest_free/total_free)); 2859 else 2860 seq_puts(m, "External Memory Fragementation:\t0%%\n"); 2861 2862 print_backup_area(m, backup_cnt); 2863 2864 return 0; 2865 } 2866 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 17648 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kbuild test robot <lkp@intel.com> To: Rick Edgecombe <rick.p.edgecombe@intel.com> Cc: kbuild-all@01.org, tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel-hardening@lists.openwall.com, kristen.c.accardi@intel.com, dave.hansen@intel.com, arjan.van.de.ven@intel.com Subject: Re: [PATCH 3/3] vmalloc: Add debugfs modfraginfo Date: Thu, 21 Jun 2018 08:53:06 +0800 [thread overview] Message-ID: <201806210843.zy4xVRmf%fengguang.wu@intel.com> (raw) In-Reply-To: <1529532570-21765-4-git-send-email-rick.p.edgecombe@intel.com> [-- Attachment #1: Type: text/plain, Size: 3149 bytes --] Hi Rick, Thank you for the patch! Yet something to improve: [auto build test ERROR on mmotm/master] [also build test ERROR on v4.18-rc1 next-20180620] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Rick-Edgecombe/KASLR-feature-to-randomize-each-loadable-module/20180621-061051 base: git://git.cmpxchg.org/linux-mmotm.git master config: mips-fuloong2e_defconfig (attached as .config) compiler: mips64el-linux-gnuabi64-gcc (Debian 7.2.0-11) 7.2.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree GCC_VERSION=7.2.0 make.cross ARCH=mips All errors (new ones prefixed by >>): mm/vmalloc.c: In function 'modulefraginfo_debug_show': >> mm/vmalloc.c:2821:27: error: 'MODULES_VADDR' undeclared (first use in this function); did you mean 'MODULE_END'? unsigned long last_end = MODULES_VADDR; ^~~~~~~~~~~~~ MODULE_END mm/vmalloc.c:2821:27: note: each undeclared identifier is reported only once for each function it appears in >> mm/vmalloc.c:2834:22: error: 'MODULES_END' undeclared (first use in this function); did you mean 'MODULE_END'? && obj->va_end <= MODULES_END) { ^~~~~~~~~~~ MODULE_END vim +2821 mm/vmalloc.c 2817 2818 static int modulefraginfo_debug_show(struct seq_file *m, void *v) 2819 { 2820 struct list_head *i; > 2821 unsigned long last_end = MODULES_VADDR; 2822 unsigned long total_free = 0; 2823 unsigned long largest_free = 0; 2824 unsigned long backup_cnt = 0; 2825 unsigned long gap; 2826 2827 spin_lock(&vmap_area_lock); 2828 2829 list_for_each(i, &vmap_area_list) { 2830 struct vmap_area *obj = list_entry(i, struct vmap_area, list); 2831 2832 if (!(obj->flags & VM_LAZY_FREE) 2833 && obj->va_start >= MODULES_VADDR > 2834 && obj->va_end <= MODULES_END) { 2835 2836 if (obj->va_start >= get_backup_start()) 2837 backup_cnt++; 2838 2839 gap = (obj->va_start - last_end); 2840 if (gap > largest_free) 2841 largest_free = gap; 2842 total_free += gap; 2843 2844 last_end = obj->va_end; 2845 } 2846 } 2847 2848 gap = (MODULES_END - last_end); 2849 if (gap > largest_free) 2850 largest_free = gap; 2851 total_free += gap; 2852 2853 spin_unlock(&vmap_area_lock); 2854 2855 seq_printf(m, "Largest free space:\t\t%lu\n", largest_free); 2856 if (total_free) 2857 seq_printf(m, "External Memory Fragementation:\t%lu%%\n", 2858 100-(100*largest_free/total_free)); 2859 else 2860 seq_puts(m, "External Memory Fragementation:\t0%%\n"); 2861 2862 print_backup_area(m, backup_cnt); 2863 2864 return 0; 2865 } 2866 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation [-- Attachment #2: .config.gz --] [-- Type: application/gzip, Size: 17648 bytes --]
next prev parent reply other threads:[~2018-06-21 0:54 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-20 22:09 [PATCH 0/3] KASLR feature to randomize each loadable module Rick Edgecombe 2018-06-20 22:09 ` [PATCH 1/3] vmalloc: Add __vmalloc_node_try_addr function Rick Edgecombe 2018-06-20 22:16 ` Randy Dunlap 2018-06-20 22:35 ` Kees Cook 2018-06-20 22:44 ` Randy Dunlap 2018-06-20 23:05 ` Kees Cook 2018-06-20 23:16 ` Randy Dunlap 2018-06-20 22:26 ` Matthew Wilcox 2018-06-21 22:02 ` Edgecombe, Rick P 2018-06-21 22:02 ` Edgecombe, Rick P 2018-06-20 22:09 ` [PATCH 2/3] x86/modules: Increase randomization for modules Rick Edgecombe 2018-06-20 22:09 ` [PATCH 3/3] vmalloc: Add debugfs modfraginfo Rick Edgecombe 2018-06-21 0:53 ` kbuild test robot [this message] 2018-06-21 0:53 ` kbuild test robot 2018-06-21 1:17 ` kbuild test robot 2018-06-21 1:17 ` kbuild test robot 2018-06-21 12:32 ` Jann Horn 2018-06-21 18:56 ` Edgecombe, Rick P 2018-06-21 18:56 ` Edgecombe, Rick P 2018-06-20 22:33 ` [PATCH 0/3] KASLR feature to randomize each loadable module Kees Cook 2018-06-21 13:37 ` Jann Horn 2018-06-21 13:39 ` Jann Horn 2018-06-21 18:59 ` Edgecombe, Rick P 2018-06-21 18:59 ` Edgecombe, Rick P 2018-06-21 21:23 ` Daniel Borkmann 2018-06-21 21:23 ` Daniel Borkmann 2018-06-21 21:23 ` Daniel Borkmann 2018-06-21 18:56 ` Edgecombe, Rick P 2018-06-21 18:56 ` Edgecombe, Rick P 2018-07-07 0:35 [PATCH RFC V2 " Rick Edgecombe 2018-07-07 0:35 ` [PATCH 3/3] vmalloc: Add debugfs modfraginfo Rick Edgecombe 2018-07-19 5:24 ` kbuild test robot 2018-07-19 5:24 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201806210843.zy4xVRmf%fengguang.wu@intel.com \ --to=lkp@intel.com \ --cc=arjan.van.de.ven@intel.com \ --cc=dave.hansen@intel.com \ --cc=hpa@zytor.com \ --cc=kbuild-all@01.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=kristen.c.accardi@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mingo@redhat.com \ --cc=rick.p.edgecombe@intel.com \ --cc=tglx@linutronix.de \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.