From: Miquel Raynal <miquel.raynal@bootlin.com> To: Thomas Gleixner <tglx@linutronix.de>, Jason Cooper <jason@lakedaemon.net>, Marc Zyngier <marc.zyngier@arm.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will.deacon@arm.com>, Andrew Lunn <andrew@lunn.ch>, Gregory Clement <gregory.clement@bootlin.com>, Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org, Haim Boot <hayim@marvell.com>, Antoine Tenart <antoine.tenart@bootlin.com>, Hanna Hawa <hannah@marvell.com>, Maxime Chevallier <maxime.chevallier@bootlin.com>, Nadav Haklai <nadavh@marvell.com>, Rob Herring <robh+dt@kernel.org>, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Miquel Raynal <miquel.raynal@bootlin.com>, linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 04/17] irqchip/irq-mvebu-icu: fix wrong private data retrieval Date: Fri, 22 Jun 2018 17:14:19 +0200 [thread overview] Message-ID: <20180622151432.1566-5-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20180622151432.1566-1-miquel.raynal@bootlin.com> The irq_domain structure has an host_data pointer that just stores private data. It is meant to not be touched by the IRQ core. However, when it comes to MSI, the MSI layer adds its own private data there with a structure that also has a host_data pointer. Because this IRQ domain is an MSI domain, to access private data we should do a d->host_data->host_data, also wrapped as 'platform_msi_get_host_data()'. This bug was lying there silently because the 'icu' structure retrieved this way was just called by dev_err(), only producing a '(NULL device *):' output on the console. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- drivers/irqchip/irq-mvebu-icu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c index 13063339b416..a2a3acd74491 100644 --- a/drivers/irqchip/irq-mvebu-icu.c +++ b/drivers/irqchip/irq-mvebu-icu.c @@ -105,7 +105,7 @@ static int mvebu_icu_irq_domain_translate(struct irq_domain *d, struct irq_fwspec *fwspec, unsigned long *hwirq, unsigned int *type) { - struct mvebu_icu *icu = d->host_data; + struct mvebu_icu *icu = platform_msi_get_host_data(d); unsigned int icu_group; /* Check the count of the parameters in dt */ -- 2.14.1
WARNING: multiple messages have this Message-ID (diff)
From: miquel.raynal@bootlin.com (Miquel Raynal) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 04/17] irqchip/irq-mvebu-icu: fix wrong private data retrieval Date: Fri, 22 Jun 2018 17:14:19 +0200 [thread overview] Message-ID: <20180622151432.1566-5-miquel.raynal@bootlin.com> (raw) In-Reply-To: <20180622151432.1566-1-miquel.raynal@bootlin.com> The irq_domain structure has an host_data pointer that just stores private data. It is meant to not be touched by the IRQ core. However, when it comes to MSI, the MSI layer adds its own private data there with a structure that also has a host_data pointer. Because this IRQ domain is an MSI domain, to access private data we should do a d->host_data->host_data, also wrapped as 'platform_msi_get_host_data()'. This bug was lying there silently because the 'icu' structure retrieved this way was just called by dev_err(), only producing a '(NULL device *):' output on the console. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com> --- drivers/irqchip/irq-mvebu-icu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/irqchip/irq-mvebu-icu.c b/drivers/irqchip/irq-mvebu-icu.c index 13063339b416..a2a3acd74491 100644 --- a/drivers/irqchip/irq-mvebu-icu.c +++ b/drivers/irqchip/irq-mvebu-icu.c @@ -105,7 +105,7 @@ static int mvebu_icu_irq_domain_translate(struct irq_domain *d, struct irq_fwspec *fwspec, unsigned long *hwirq, unsigned int *type) { - struct mvebu_icu *icu = d->host_data; + struct mvebu_icu *icu = platform_msi_get_host_data(d); unsigned int icu_group; /* Check the count of the parameters in dt */ -- 2.14.1
next prev parent reply other threads:[~2018-06-22 15:14 UTC|newest] Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-06-22 15:14 [PATCH v3 00/17] Add System Error Interrupt support to Armada SoCs Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 01/17] platform-msi: allow creation of MSI domain without interrupt number Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-28 11:12 ` Marc Zyngier 2018-06-28 11:12 ` Marc Zyngier 2018-06-29 7:40 ` Miquel Raynal 2018-06-29 7:40 ` Miquel Raynal 2018-06-29 14:38 ` Marc Zyngier 2018-06-29 14:38 ` Marc Zyngier 2018-06-29 14:43 ` Miquel Raynal 2018-06-29 14:43 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 02/17] dt-bindings/interrupt-controller: fix Marvell ICU length in the example Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 03/17] arm64: dts: marvell: fix CP110 ICU node size Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-25 15:05 ` Gregory CLEMENT 2018-06-25 15:05 ` Gregory CLEMENT 2018-06-25 15:09 ` Miquel Raynal 2018-06-25 15:09 ` Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal [this message] 2018-06-22 15:14 ` [PATCH v3 04/17] irqchip/irq-mvebu-icu: fix wrong private data retrieval Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 05/17] irqchip/irq-mvebu-icu: clarify the reset operation of configured interrupts Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 06/17] irqchip/irq-mvebu-icu: switch to regmap Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-28 12:05 ` Marc Zyngier 2018-06-28 12:05 ` Marc Zyngier 2018-06-29 15:27 ` Miquel Raynal 2018-06-29 15:27 ` Miquel Raynal 2018-06-29 17:17 ` Marc Zyngier 2018-06-29 17:17 ` Marc Zyngier 2018-06-29 18:20 ` Miquel Raynal 2018-06-29 18:20 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 07/17] irqchip/irq-mvebu-icu: make irq_domain local Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-28 12:10 ` Marc Zyngier 2018-06-28 12:10 ` Marc Zyngier 2018-06-29 12:32 ` Miquel Raynal 2018-06-29 12:32 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 08/17] irqchip/irq-mvebu-icu: disociate ICU and NSR Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-28 12:24 ` Marc Zyngier 2018-06-28 12:24 ` Marc Zyngier 2018-06-29 12:30 ` Miquel Raynal 2018-06-29 12:30 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 09/17] irqchip/irq-mvebu-icu: support ICU subnodes Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-28 12:45 ` Marc Zyngier 2018-06-28 12:45 ` Marc Zyngier 2018-06-29 12:34 ` Miquel Raynal 2018-06-29 12:34 ` Miquel Raynal 2018-07-04 9:09 ` Miquel Raynal 2018-07-04 9:09 ` Miquel Raynal 2018-07-04 12:43 ` Marc Zyngier 2018-07-04 12:43 ` Marc Zyngier 2018-07-04 15:16 ` Miquel Raynal 2018-07-04 15:16 ` Miquel Raynal 2018-07-05 8:19 ` Marc Zyngier 2018-07-05 8:19 ` Marc Zyngier 2018-06-22 15:14 ` [PATCH v3 10/17] irqchip/irq-mvebu-sei: add new driver for Marvell SEI Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-28 14:54 ` Marc Zyngier 2018-06-28 14:54 ` Marc Zyngier 2018-06-29 12:41 ` Miquel Raynal 2018-06-29 12:41 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 11/17] arm64: marvell: enable SEI driver Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 12/17] irqchip/irq-mvebu-icu: add support for System Error Interrupts (SEI) Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-28 16:49 ` Marc Zyngier 2018-06-28 16:49 ` Marc Zyngier 2018-06-28 17:12 ` Miquel Raynal 2018-06-28 17:12 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 13/17] dt-bindings/interrupt-controller: update Marvell ICU bindings Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 14/17] dt-bindings/interrupt-controller: add documentation for Marvell SEI controller Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 15/17] arm64: dts: marvell: add AP806 SEI subnode Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 16/17] arm64: dts: marvell: use new bindings for CP110 interrupts Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal 2018-06-22 15:14 ` [PATCH v3 17/17] arm64: dts: marvell: add CP110 ICU SEI subnode Miquel Raynal 2018-06-22 15:14 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180622151432.1566-5-miquel.raynal@bootlin.com \ --to=miquel.raynal@bootlin.com \ --cc=andrew@lunn.ch \ --cc=antoine.tenart@bootlin.com \ --cc=catalin.marinas@arm.com \ --cc=devicetree@vger.kernel.org \ --cc=gregory.clement@bootlin.com \ --cc=hannah@marvell.com \ --cc=hayim@marvell.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=marc.zyngier@arm.com \ --cc=mark.rutland@arm.com \ --cc=maxime.chevallier@bootlin.com \ --cc=nadavh@marvell.com \ --cc=robh+dt@kernel.org \ --cc=sebastian.hesselbarth@gmail.com \ --cc=tglx@linutronix.de \ --cc=thomas.petazzoni@bootlin.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.