From: Pavel Machek <pavel@ucw.cz>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
alan@linux.intel.com, Johan Hovold <johan@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andreas Kemnade <andreas@kemnade.info>,
Arnd Bergmann <arnd@arndb.de>,
"H . Nikolaus Schaller" <hns@goldelico.com>,
Marcel Holtmann <marcel@holtmann.org>,
Sebastian Reichel <sebastian.reichel@collabora.co.uk>,
Tony Lindgren <tony@atomide.com>,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 0/8] gnss: add new GNSS subsystem
Date: Mon, 2 Jul 2018 21:01:23 +0200 [thread overview]
Message-ID: <20180702190123.GA30798@amd> (raw)
In-Reply-To: <20180629182600.GA17562@kroah.com>
[-- Attachment #1: Type: text/plain, Size: 1283 bytes --]
On Fri 2018-06-29 14:26:00, Greg Kroah-Hartman wrote:
> On Fri, Jun 29, 2018 at 11:46:07AM +0200, Pavel Machek wrote:
> >
> > > > Finally, note that documentation (including kerneldoc) remains to be
> > > > written, but hopefully this will not hinder review given that the
> > > > current interfaces are fairly self-describing.
> > >
> > > This all looks great. Thanks for doing this work and adding a new
> > > subsystem for something that has been asked for for many years.
> > >
> > > All now merged in my tree, nice job!
> >
> > I don't think discussion was finished on this one.
>
> It looked done to me as there was only a single set of patches, with no
> other working patches submitted from anyone else.
Is "noone submitted patches on top" sufficient reason to apply the patch?
> If this turns out to be a "bad" api, then we can deal with it then, but
> for now let's try this out.
Series uses /dev/gnss0 , without providing hardware abstraction,
blocking place for proper gnss layer. Suggested fix is to to make it
"/dev/gnssraw0". How do you propose to fix this after it is merged?
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
prev parent reply other threads:[~2018-07-02 19:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 8:22 [PATCH v3 0/8] gnss: add new GNSS subsystem Johan Hovold
2018-06-01 8:22 ` [PATCH v3 1/8] gnss: add GNSS receiver subsystem Johan Hovold
2018-06-01 8:22 ` [PATCH v3 2/8] dt-bindings: add generic gnss binding Johan Hovold
2018-06-01 8:22 ` [PATCH v3 3/8] gnss: add generic serial driver Johan Hovold
2018-06-01 8:22 ` [PATCH v3 4/8] dt-bindings: gnss: add u-blox binding Johan Hovold
2018-06-01 14:34 ` Rob Herring
2018-06-01 8:22 ` [PATCH v3 5/8] gnss: add driver for u-blox receivers Johan Hovold
2018-06-01 8:22 ` [PATCH v3 6/8] dt-bindings: gnss: add sirfstar binding Johan Hovold
2018-06-01 8:22 ` [PATCH v3 7/8] gnss: add driver for sirfstar-based receivers Johan Hovold
2018-06-01 8:22 ` [PATCH v3 8/8] gnss: add receiver type support Johan Hovold
2018-06-01 9:33 ` [PATCH v3 0/8] gnss: add new GNSS subsystem Pavel Machek
2018-06-01 9:49 ` Johan Hovold
2018-06-01 10:26 ` Pavel Machek
2018-06-01 12:22 ` Johan Hovold
2018-06-01 16:26 ` Pavel Machek
2018-06-01 16:37 ` H. Nikolaus Schaller
2018-06-01 21:46 ` Pavel Machek
2018-06-04 10:22 ` Johan Hovold
2018-06-05 21:47 ` Pavel Machek
2018-06-13 8:21 ` Johan Hovold
2018-06-28 12:01 ` Greg Kroah-Hartman
2018-06-29 9:46 ` Pavel Machek
2018-06-29 11:46 ` Johan Hovold
2018-06-29 12:05 ` Pavel Machek
2018-06-29 12:09 ` Johan Hovold
2018-07-02 19:32 ` Pavel Machek
2018-07-03 7:20 ` Johan Hovold
2018-06-29 18:26 ` Greg Kroah-Hartman
2018-07-02 19:01 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180702190123.GA30798@amd \
--to=pavel@ucw.cz \
--cc=alan@linux.intel.com \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hns@goldelico.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sebastian.reichel@collabora.co.uk \
--cc=tony@atomide.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.