[PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s

[PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s

[Chris Wilson]

5s is often not enough for the sound module to finish loading, so bump
the timeout to 10s. For fun, poll quicker over the 1s!

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.linux.com>
---
 lib/igt_pm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index e86fa4a40..615463a08 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -258,12 +258,15 @@ void igt_pm_enable_audio_runtime_pm(void)
 	if (__igt_pm_audio_runtime_power_save[0])
 		return;
 
-	for (int count = 0; count < 5; count++) {
+	for (int count = 0; count < 110; count++) {
 		if (!__igt_pm_enable_audio_runtime_pm())
 			return;
 
 		/* modprobe(sna-hda-intel) acts async so poll for sysfs */
-		sleep(1);
+		if (count < 100)
+			usleep(10 * 1000); /* poll at 10ms for the first 1s */
+		else
+			sleep(1);
 	}
 
 	err = __igt_pm_enable_audio_runtime_pm();
-- 
2.19.0.rc1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[igt-dev] [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s

[Chris Wilson]

5s is often not enough for the sound module to finish loading, so bump
the timeout to 10s. For fun, poll quicker over the 1s!

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Imre Deak <imre.deak@intel.linux.com>
---
 lib/igt_pm.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/igt_pm.c b/lib/igt_pm.c
index e86fa4a40..615463a08 100644
--- a/lib/igt_pm.c
+++ b/lib/igt_pm.c
@@ -258,12 +258,15 @@ void igt_pm_enable_audio_runtime_pm(void)
 	if (__igt_pm_audio_runtime_power_save[0])
 		return;
 
-	for (int count = 0; count < 5; count++) {
+	for (int count = 0; count < 110; count++) {
 		if (!__igt_pm_enable_audio_runtime_pm())
 			return;
 
 		/* modprobe(sna-hda-intel) acts async so poll for sysfs */
-		sleep(1);
+		if (count < 100)
+			usleep(10 * 1000); /* poll at 10ms for the first 1s */
+		else
+			sleep(1);
 	}
 
 	err = __igt_pm_enable_audio_runtime_pm();
-- 
2.19.0.rc1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✗ Fi.CI.BAT: failure for lib/pm: Increase snd module probe timeout to 10s

[Patchwork]

== Series Details ==

Series: lib/pm: Increase snd module probe timeout to 10s
URL   : https://patchwork.freedesktop.org/series/49117/
State : failure

== Summary ==

= CI Bug Log - changes from CI_DRM_4763 -> IGTPW_1781 =

== Summary - FAILURE ==

  Serious unknown changes coming with IGTPW_1781 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1781, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49117/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1781:

  === IGT changes ===

    ==== Possible regressions ====

    igt@pm_rpm@module-reload:
      fi-skl-6600u:       PASS -> INCOMPLETE

    
== Known issues ==

  Here are the changes found in IGTPW_1781 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362, fdo#103191)
      fi-cfl-8109u:       PASS -> INCOMPLETE (fdo#106070)

    igt@kms_psr@primary_page_flip:
      fi-cnl-psr:         PASS -> FAIL (fdo#107336)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-skl-guc:         FAIL (fdo#103191) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     FAIL (fdo#107362, fdo#103191) -> PASS

    igt@pm_rpm@module-reload:
      fi-glk-dsi:         WARN (fdo#107602, fdo#107708) -> PASS
      fi-byt-clapper:     WARN (fdo#107602, fdo#107708) -> PASS
      fi-kbl-x1275:       WARN (fdo#107602, fdo#107708) -> PASS
      fi-cnl-psr:         WARN (fdo#107602, fdo#107708) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708


== Participating hosts (52 -> 46) ==

  Missing    (6): fi-ilk-m540 fi-bxt-dsi fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


== Build changes ==

    * IGT: IGT_4622 -> IGTPW_1781

  CI_DRM_4763: 1f8c06844acac7a349fb80471afcc09f33c6cfc0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1781: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1781/
  IGT_4622: 022be555443eaa3317da6a9a451cf2c9dfcd6ab8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1781/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] ✗ Fi.CI.BAT: failure for lib/pm: Increase snd module probe timeout to 10s

[Chris Wilson]

Quoting Patchwork (2018-09-04 11:49:27)
> == Series Details ==
> 
> Series: lib/pm: Increase snd module probe timeout to 10s
> URL   : https://patchwork.freedesktop.org/series/49117/
> State : failure
> 
> == Summary ==
> 
> = CI Bug Log - changes from CI_DRM_4763 -> IGTPW_1781 =
> 
> == Summary - FAILURE ==
> 
>   Serious unknown changes coming with IGTPW_1781 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in IGTPW_1781, please notify your bug team to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://patchwork.freedesktop.org/api/1.0/series/49117/revisions/1/mbox/
> 
> == Possible new issues ==
> 
>   Here are the unknown changes that may have been introduced in IGTPW_1781:
> 
>   === IGT changes ===
> 
>     ==== Possible regressions ====
> 
>     igt@pm_rpm@module-reload:
>       fi-skl-6600u:       PASS -> INCOMPLETE

Very suspicious, most likely we caught something by polling faster.
Sadly logless and likely transient.
-chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for lib/pm: Increase snd module probe timeout to 10s

[Patchwork]

== Series Details ==

Series: lib/pm: Increase snd module probe timeout to 10s
URL   : https://patchwork.freedesktop.org/series/49117/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4763 -> IGTPW_1783 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49117/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1783 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@kms_flip@basic-plain-flip:
      fi-ilk-650:         PASS -> DMESG-WARN (fdo#106387) +1

    igt@kms_pipe_crc_basic@nonblocking-crc-pipe-b:
      fi-byt-clapper:     PASS -> FAIL (fdo#107362) +1

    igt@kms_psr@primary_page_flip:
      fi-cnl-psr:         PASS -> FAIL (fdo#107336)

    
    ==== Possible fixes ====

    igt@kms_pipe_crc_basic@hang-read-crc-pipe-b:
      fi-skl-guc:         FAIL (fdo#103191) -> PASS

    igt@kms_pipe_crc_basic@read-crc-pipe-b-frame-sequence:
      fi-byt-clapper:     FAIL (fdo#103191, fdo#107362) -> PASS

    igt@pm_rpm@module-reload:
      fi-glk-dsi:         WARN (fdo#107708, fdo#107602) -> PASS
      fi-byt-clapper:     WARN (fdo#107708, fdo#107602) -> PASS
      fi-kbl-x1275:       WARN (fdo#107708, fdo#107602) -> PASS
      fi-cnl-psr:         WARN (fdo#107708, fdo#107602) -> PASS

    
  fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
  fdo#106387 https://bugs.freedesktop.org/show_bug.cgi?id=106387
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107362 https://bugs.freedesktop.org/show_bug.cgi?id=107362
  fdo#107602 https://bugs.freedesktop.org/show_bug.cgi?id=107602
  fdo#107708 https://bugs.freedesktop.org/show_bug.cgi?id=107708


== Participating hosts (52 -> 47) ==

  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4622 -> IGTPW_1783

  CI_DRM_4763: 1f8c06844acac7a349fb80471afcc09f33c6cfc0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1783: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1783/
  IGT_4622: 022be555443eaa3317da6a9a451cf2c9dfcd6ab8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1783/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s

[Imre Deak]

On Tue, Sep 04, 2018 at 11:19:38AM +0100, Chris Wilson wrote:
> 5s is often not enough for the sound module to finish loading, so bump
> the timeout to 10s. For fun, poll quicker over the 1s!
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.linux.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  lib/igt_pm.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index e86fa4a40..615463a08 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -258,12 +258,15 @@ void igt_pm_enable_audio_runtime_pm(void)
>  	if (__igt_pm_audio_runtime_power_save[0])
>  		return;
>  
> -	for (int count = 0; count < 5; count++) {
> +	for (int count = 0; count < 110; count++) {
>  		if (!__igt_pm_enable_audio_runtime_pm())
>  			return;
>  
>  		/* modprobe(sna-hda-intel) acts async so poll for sysfs */
> -		sleep(1);
> +		if (count < 100)
> +			usleep(10 * 1000); /* poll at 10ms for the first 1s */
> +		else
> +			sleep(1);
>  	}
>  
>  	err = __igt_pm_enable_audio_runtime_pm();
> -- 
> 2.19.0.rc1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [igt-dev] [PATCH i-g-t] lib/pm: Increase snd module probe timeout to 10s

[Imre Deak]

On Tue, Sep 04, 2018 at 11:19:38AM +0100, Chris Wilson wrote:
> 5s is often not enough for the sound module to finish loading, so bump
> the timeout to 10s. For fun, poll quicker over the 1s!
> 
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Imre Deak <imre.deak@intel.linux.com>

Reviewed-by: Imre Deak <imre.deak@intel.com>

> ---
>  lib/igt_pm.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/igt_pm.c b/lib/igt_pm.c
> index e86fa4a40..615463a08 100644
> --- a/lib/igt_pm.c
> +++ b/lib/igt_pm.c
> @@ -258,12 +258,15 @@ void igt_pm_enable_audio_runtime_pm(void)
>  	if (__igt_pm_audio_runtime_power_save[0])
>  		return;
>  
> -	for (int count = 0; count < 5; count++) {
> +	for (int count = 0; count < 110; count++) {
>  		if (!__igt_pm_enable_audio_runtime_pm())
>  			return;
>  
>  		/* modprobe(sna-hda-intel) acts async so poll for sysfs */
> -		sleep(1);
> +		if (count < 100)
> +			usleep(10 * 1000); /* poll at 10ms for the first 1s */
> +		else
> +			sleep(1);
>  	}
>  
>  	err = __igt_pm_enable_audio_runtime_pm();
> -- 
> 2.19.0.rc1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for lib/pm: Increase snd module probe timeout to 10s

[Patchwork]

== Series Details ==

Series: lib/pm: Increase snd module probe timeout to 10s
URL   : https://patchwork.freedesktop.org/series/49117/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4622_full -> IGTPW_1783_full =

== Summary - WARNING ==

  Minor unknown changes coming with IGTPW_1783_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_1783_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49117/revisions/1/mbox/

== Possible new issues ==

  Here are the unknown changes that may have been introduced in IGTPW_1783_full:

  === IGT changes ===

    ==== Warnings ====

    igt@kms_cursor_legacy@basic-flip-before-cursor-legacy:
      shard-snb:          SKIP -> PASS

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-render:
      shard-snb:          PASS -> SKIP +4

    igt@pm_rc6_residency@rc6-accuracy:
      shard-kbl:          SKIP -> PASS

    
== Known issues ==

  Here are the changes found in IGTPW_1783_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@drv_suspend@shrink:
      shard-apl:          PASS -> FAIL (fdo#106886)

    igt@gem_exec_await@wide-contexts:
      shard-kbl:          PASS -> FAIL (fdo#105900)

    igt@gem_exec_schedule@pi-ringfull-bsd2:
      shard-kbl:          NOTRUN -> FAIL (fdo#103158)

    igt@kms_available_modes_crc@available_mode_test_crc:
      shard-snb:          PASS -> FAIL (fdo#106641)

    igt@kms_rotation_crc@sprite-rotation-180:
      shard-snb:          PASS -> FAIL (fdo#103925)

    igt@perf@short-reads:
      shard-kbl:          PASS -> FAIL (fdo#103183)

    igt@perf_pmu@semaphore-wait-vcs0:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@pm_rpm@system-suspend-execbuf:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665, fdo#107556)

    
    ==== Possible fixes ====

    igt@drv_suspend@shrink:
      shard-hsw:          INCOMPLETE (fdo#106886, fdo#103540) -> PASS

    igt@gem_ppgtt@blt-vs-render-ctxn:
      shard-kbl:          INCOMPLETE (fdo#103665, fdo#106023) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-scndscrn-shrfb-plflip-blt:
      shard-glk:          FAIL (fdo#103167) -> PASS

    
  fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103183 https://bugs.freedesktop.org/show_bug.cgi?id=103183
  fdo#103540 https://bugs.freedesktop.org/show_bug.cgi?id=103540
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#105900 https://bugs.freedesktop.org/show_bug.cgi?id=105900
  fdo#106023 https://bugs.freedesktop.org/show_bug.cgi?id=106023
  fdo#106641 https://bugs.freedesktop.org/show_bug.cgi?id=106641
  fdo#106886 https://bugs.freedesktop.org/show_bug.cgi?id=106886
  fdo#107556 https://bugs.freedesktop.org/show_bug.cgi?id=107556


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4622 -> IGTPW_1783
    * Linux: CI_DRM_4757 -> CI_DRM_4763

  CI_DRM_4757: 1465de895e2b5d9e74e9a85189c9075155efa30d @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4763: 1f8c06844acac7a349fb80471afcc09f33c6cfc0 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1783: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1783/
  IGT_4622: 022be555443eaa3317da6a9a451cf2c9dfcd6ab8 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1783/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev