[PATCH] xsm: fix clang build

[PATCH] xsm: fix clang build

[Roger Pau Monne]

ebitmap.c:244:32: error: invalid conversion specifier 'Z' [-Werror,-Wformat-invalid-specifier]
               "match my size %Zd (high bit was %d)\n", mapunit,
                              ~^
ebitmap.c:245:16: error: format specifies type 'int' but the argument has type 'unsigned long'
      [-Werror,-Wformat]
               sizeof(u64) * 8, e->highbit);
               ^~~~~~~~~~~~~~~
ebitmap.c:245:33: error: data argument not used by format string [-Werror,-Wformat-extra-args]
               sizeof(u64) * 8, e->highbit);

Use %zd instead of %Zd, which is compliant with C99.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Daniel De Graaf <dgdegra@tycho.nsa.gov>
---
 xen/xsm/flask/ss/ebitmap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/xsm/flask/ss/ebitmap.c b/xen/xsm/flask/ss/ebitmap.c
index bb3ec8e7c9..e1d0a586a7 100644
--- a/xen/xsm/flask/ss/ebitmap.c
+++ b/xen/xsm/flask/ss/ebitmap.c
@@ -241,7 +241,7 @@ int ebitmap_read(struct ebitmap *e, void *fp)
     if ( mapunit != sizeof(u64) * 8 )
     {
         printk(KERN_ERR "Flask: ebitmap: map size %u does not "
-               "match my size %Zd (high bit was %d)\n", mapunit,
+               "match my size %zd (high bit was %d)\n", mapunit,
                sizeof(u64) * 8, e->highbit);
         goto bad;
     }
-- 
2.18.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [PATCH] xsm: fix clang build

[Wei Liu]

On Wed, Sep 05, 2018 at 04:46:06PM +0200, Roger Pau Monne wrote:
> ebitmap.c:244:32: error: invalid conversion specifier 'Z' [-Werror,-Wformat-invalid-specifier]
>                "match my size %Zd (high bit was %d)\n", mapunit,
>                               ~^
> ebitmap.c:245:16: error: format specifies type 'int' but the argument has type 'unsigned long'
>       [-Werror,-Wformat]
>                sizeof(u64) * 8, e->highbit);
>                ^~~~~~~~~~~~~~~
> ebitmap.c:245:33: error: data argument not used by format string [-Werror,-Wformat-extra-args]
>                sizeof(u64) * 8, e->highbit);
> 
> Use %zd instead of %Zd, which is compliant with C99.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [Non-DoD Source] [PATCH] xsm: fix clang build

[DeGraaf, Daniel G]

> -----Original Message-----
> From: Roger Pau Monne <roger.pau@citrix.com>
> Sent: Wednesday, September 5, 2018 10:46 AM
> To: xen-devel@lists.xenproject.org
> Cc: Roger Pau Monne <roger.pau@citrix.com>; Daniel De Graaf <dgdegra@tycho.nsa.gov>
> Subject: [Non-DoD Source] [PATCH] xsm: fix clang build
> 
> ebitmap.c:244:32: error: invalid conversion specifier 'Z' [-Werror,-Wformat-invalid-specifier]
>                "match my size %Zd (high bit was %d)\n", mapunit,
>                               ~^
> ebitmap.c:245:16: error: format specifies type 'int' but the argument has type 'unsigned long'
>       [-Werror,-Wformat]
>                sizeof(u64) * 8, e->highbit);
>                ^~~~~~~~~~~~~~~
> ebitmap.c:245:33: error: data argument not used by format string [-Werror,-Wformat-extra-args]
>                sizeof(u64) * 8, e->highbit);
> 
> Use %zd instead of %Zd, which is compliant with C99.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>

Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel