[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

Add a warning to update test if GEN version is not recognized.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_ctx_isolation.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
index 4325e1c2..bd07b141 100644
--- a/tests/gem_ctx_isolation.c
+++ b/tests/gem_ctx_isolation.c
@@ -700,7 +700,9 @@ igt_main
 		igt_require(has_context_isolation);
 
 		gen = intel_gen(intel_get_drm_devid(fd));
-		//igt_ci_fail_on(gen > LAST_KNOWN_GEN);
+
+		igt_warn_on_f(gen > LAST_KNOWN_GEN,
+				"GEN not recognized! Test needs to be updated to run.");
 		igt_skip_on(gen > LAST_KNOWN_GEN);
 	}
 
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Chris Wilson]

Quoting Antonio Argenziano (2018-09-06 20:59:57)
> Add a warning to update test if GEN version is not recognized.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>  tests/gem_ctx_isolation.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
> index 4325e1c2..bd07b141 100644
> --- a/tests/gem_ctx_isolation.c
> +++ b/tests/gem_ctx_isolation.c
> @@ -700,7 +700,9 @@ igt_main
>                 igt_require(has_context_isolation);
>  
>                 gen = intel_gen(intel_get_drm_devid(fd));
> -               //igt_ci_fail_on(gen > LAST_KNOWN_GEN);
> +
> +               igt_warn_on_f(gen > LAST_KNOWN_GEN,
> +                               "GEN not recognized! Test needs to be updated to run.");
>                 igt_skip_on(gen > LAST_KNOWN_GEN);

Unquestionably an improvement,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

Remember to :set cino=:0,(0 though, i.e. continuation lines should be
indented to the bracket.
-Chris
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

On 06/09/18 13:03, Chris Wilson wrote:
> Quoting Antonio Argenziano (2018-09-06 20:59:57)
>> Add a warning to update test if GEN version is not recognized.
>>
>> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> ---
>>   tests/gem_ctx_isolation.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
>> index 4325e1c2..bd07b141 100644
>> --- a/tests/gem_ctx_isolation.c
>> +++ b/tests/gem_ctx_isolation.c
>> @@ -700,7 +700,9 @@ igt_main
>>                  igt_require(has_context_isolation);
>>   
>>                  gen = intel_gen(intel_get_drm_devid(fd));
>> -               //igt_ci_fail_on(gen > LAST_KNOWN_GEN);
>> +
>> +               igt_warn_on_f(gen > LAST_KNOWN_GEN,
>> +                               "GEN not recognized! Test needs to be updated to run.");
>>                  igt_skip_on(gen > LAST_KNOWN_GEN);
> 
> Unquestionably an improvement,
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> 
> Remember to :set cino=:0,(0 though, i.e. continuation lines should be
> indented to the bracket.

Thanks, I'll change it when pushing,

Antonio

> -Chris
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.BAT: success for tests/gem_ctx_isoation: Add warn for newer gens.

[Patchwork]

== Series Details ==

Series: tests/gem_ctx_isoation: Add warn for newer gens.
URL   : https://patchwork.freedesktop.org/series/49296/
State : success

== Summary ==

= CI Bug Log - changes from CI_DRM_4782 -> IGTPW_1805 =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49296/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1805 that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@debugfs_test@read_all_entries:
      fi-snb-2520m:       PASS -> INCOMPLETE (fdo#103713)

    igt@gem_exec_suspend@basic-s3:
      fi-blb-e6850:       PASS -> INCOMPLETE (fdo#107718)

    igt@kms_pipe_crc_basic@suspend-read-crc-pipe-c:
      fi-bxt-dsi:         PASS -> INCOMPLETE (fdo#103927)

    
    ==== Possible fixes ====

    igt@amdgpu/amd_cs_nop@sync-fork-gfx0:
      fi-kbl-8809g:       DMESG-WARN (fdo#107762) -> PASS

    igt@kms_psr@primary_page_flip:
      fi-kbl-7560u:       FAIL (fdo#107336) -> PASS

    
    ==== Warnings ====

    igt@amdgpu/amd_prime@amd-to-i915:
      fi-kbl-8809g:       DMESG-FAIL (fdo#107762) -> FAIL (fdo#107341)

    
  fdo#103713 https://bugs.freedesktop.org/show_bug.cgi?id=103713
  fdo#103927 https://bugs.freedesktop.org/show_bug.cgi?id=103927
  fdo#107336 https://bugs.freedesktop.org/show_bug.cgi?id=107336
  fdo#107341 https://bugs.freedesktop.org/show_bug.cgi?id=107341
  fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
  fdo#107762 https://bugs.freedesktop.org/show_bug.cgi?id=107762


== Participating hosts (52 -> 49) ==

  Additional (2): fi-byt-j1900 fi-gdg-551 
  Missing    (5): fi-ctg-p8600 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-hsw-4200u 


== Build changes ==

    * IGT: IGT_4632 -> IGTPW_1805

  CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1805: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1805/
  IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1805/issues.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] ✓ Fi.CI.IGT: success for tests/gem_ctx_isoation: Add warn for newer gens.

[Patchwork]

== Series Details ==

Series: tests/gem_ctx_isoation: Add warn for newer gens.
URL   : https://patchwork.freedesktop.org/series/49296/
State : success

== Summary ==

= CI Bug Log - changes from IGT_4632_full -> IGTPW_1805_full =

== Summary - SUCCESS ==

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/49296/revisions/1/mbox/

== Known issues ==

  Here are the changes found in IGTPW_1805_full that come from known issues:

  === IGT changes ===

    ==== Issues hit ====

    igt@gem_workarounds@suspend-resume-context:
      shard-kbl:          PASS -> INCOMPLETE (fdo#103665)

    igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-f:
      shard-snb:          SKIP -> INCOMPLETE (fdo#105411)

    igt@kms_cursor_legacy@cursor-vs-flip-atomic-transitions-varying-size:
      shard-hsw:          PASS -> FAIL (fdo#103355)

    igt@kms_setmode@basic:
      shard-apl:          PASS -> FAIL (fdo#99912)

    igt@kms_sysfs_edid_timing:
      shard-glk:          NOTRUN -> WARN (fdo#100047)

    
    ==== Possible fixes ====

    igt@kms_cursor_legacy@cursor-vs-flip-toggle:
      shard-hsw:          FAIL (fdo#103355) -> PASS +1

    igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-blt:
      shard-snb:          INCOMPLETE (fdo#105411) -> PASS

    igt@kms_frontbuffer_tracking@fbc-2p-primscrn-spr-indfb-draw-mmap-cpu:
      shard-glk:          FAIL (fdo#103167) -> PASS

    igt@kms_plane@pixel-format-pipe-a-planes:
      shard-snb:          FAIL (fdo#107749) -> PASS

    igt@kms_rotation_crc@primary-rotation-180:
      shard-snb:          FAIL (fdo#103925) -> PASS

    
  fdo#100047 https://bugs.freedesktop.org/show_bug.cgi?id=100047
  fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
  fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
  fdo#103665 https://bugs.freedesktop.org/show_bug.cgi?id=103665
  fdo#103925 https://bugs.freedesktop.org/show_bug.cgi?id=103925
  fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
  fdo#107749 https://bugs.freedesktop.org/show_bug.cgi?id=107749
  fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912


== Participating hosts (5 -> 5) ==

  No changes in participating hosts


== Build changes ==

    * IGT: IGT_4632 -> IGTPW_1805
    * Linux: CI_DRM_4775 -> CI_DRM_4782

  CI_DRM_4775: 1a2bb6c061217718b972b3f4a74b96b61cf19d0c @ git://anongit.freedesktop.org/gfx-ci/linux
  CI_DRM_4782: 60edf94611d2374821fbe2a824cebcb425ce7b0d @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_1805: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1805/
  IGT_4632: 94b4e204473a7d9f49e536c8877a4a5636e0d1b2 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_1805/shards.html
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

Re: [igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

Ops, sorry wrong button.

Please ignore this.

Sorry,
Antonio

On 24/09/18 09:38, Antonio Argenziano wrote:
> Add a warning to update test if GEN version is not recognized.
> 
> Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> ---
>   tests/gem_ctx_isolation.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
> index 4325e1c2..bd07b141 100644
> --- a/tests/gem_ctx_isolation.c
> +++ b/tests/gem_ctx_isolation.c
> @@ -700,7 +700,9 @@ igt_main
>   		igt_require(has_context_isolation);
>   
>   		gen = intel_gen(intel_get_drm_devid(fd));
> -		//igt_ci_fail_on(gen > LAST_KNOWN_GEN);
> +
> +		igt_warn_on_f(gen > LAST_KNOWN_GEN,
> +				"GEN not recognized! Test needs to be updated to run.");
>   		igt_skip_on(gen > LAST_KNOWN_GEN);
>   	}
>   
> 
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

[igt-dev] [PATCH i-g-t] tests/gem_ctx_isoation: Add warn for newer gens.

[Antonio Argenziano]

Add a warning to update test if GEN version is not recognized.

Signed-off-by: Antonio Argenziano <antonio.argenziano@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
---
 tests/gem_ctx_isolation.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tests/gem_ctx_isolation.c b/tests/gem_ctx_isolation.c
index 4325e1c2..bd07b141 100644
--- a/tests/gem_ctx_isolation.c
+++ b/tests/gem_ctx_isolation.c
@@ -700,7 +700,9 @@ igt_main
 		igt_require(has_context_isolation);
 
 		gen = intel_gen(intel_get_drm_devid(fd));
-		//igt_ci_fail_on(gen > LAST_KNOWN_GEN);
+
+		igt_warn_on_f(gen > LAST_KNOWN_GEN,
+				"GEN not recognized! Test needs to be updated to run.");
 		igt_skip_on(gen > LAST_KNOWN_GEN);
 	}
 
-- 
2.16.2

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev