From: Herbert Xu <herbert@gondor.apana.org.au>
To: Kees Cook <keescook@chromium.org>
Cc: Eric Biggers <ebiggers@google.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
Gilad Ben-Yossef <gilad@benyossef.com>,
Alexander Stein <alexander.stein@systec-electronic.com>,
Antoine Tenart <antoine.tenart@bootlin.com>,
Boris Brezillon <boris.brezillon@bootlin.com>,
Arnaud Ebalard <arno@natisbad.org>,
Corentin Labbe <clabbe.montjoie@gmail.com>,
Maxime Ripard <maxime.ripard@bootlin.com>,
Chen-Yu Tsai <wens@csie.org>,
Christian Lamparter <chunkeey@gmail.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/4] crypto: skcipher - Enforce non-ASYNC for on-stack requests
Date: Fri, 7 Sep 2018 11:42:42 +0800 [thread overview]
Message-ID: <20180907034242.zhm4dglzkldhvh3x@gondor.apana.org.au> (raw)
In-Reply-To: <20180906225854.40989-3-keescook@chromium.org>
On Thu, Sep 06, 2018 at 03:58:52PM -0700, Kees Cook wrote:
>
> @@ -437,6 +442,12 @@ static inline struct crypto_skcipher *crypto_skcipher_reqtfm_check(
> {
> struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(req);
>
> + if (req->__onstack) {
> + if (WARN_ON(crypto_skcipher_alg(tfm)->base.cra_flags &
> + CRYPTO_ALG_ASYNC))
> + return ERR_PTR(-EINVAL);
> + }
Sorry but I don't like imposing a run-time check on everybody when
stack-based requests are the odd ones out. If we're going to make
this a run-time check (I'd much prefer a compile-time check, but I
understand that this may involve too much churn), then please do it
for stack-based request users only.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: herbert@gondor.apana.org.au (Herbert Xu)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 2/4] crypto: skcipher - Enforce non-ASYNC for on-stack requests
Date: Fri, 7 Sep 2018 11:42:42 +0800 [thread overview]
Message-ID: <20180907034242.zhm4dglzkldhvh3x@gondor.apana.org.au> (raw)
In-Reply-To: <20180906225854.40989-3-keescook@chromium.org>
On Thu, Sep 06, 2018 at 03:58:52PM -0700, Kees Cook wrote:
>
> @@ -437,6 +442,12 @@ static inline struct crypto_skcipher *crypto_skcipher_reqtfm_check(
> {
> struct crypto_skcipher *tfm = crypto_skcipher_reqtfm(req);
>
> + if (req->__onstack) {
> + if (WARN_ON(crypto_skcipher_alg(tfm)->base.cra_flags &
> + CRYPTO_ALG_ASYNC))
> + return ERR_PTR(-EINVAL);
> + }
Sorry but I don't like imposing a run-time check on everybody when
stack-based requests are the odd ones out. If we're going to make
this a run-time check (I'd much prefer a compile-time check, but I
understand that this may involve too much churn), then please do it
for stack-based request users only.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-09-07 3:42 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 22:58 [PATCH v2 0/4] crypto: skcipher - Remove VLA usage Kees Cook
2018-09-06 22:58 ` Kees Cook
2018-09-06 22:58 ` [PATCH v2 1/4] crypto: skcipher - Consolidate encrypt/decrypt sanity check Kees Cook
2018-09-06 22:58 ` Kees Cook
2018-09-06 22:58 ` [PATCH v2 2/4] crypto: skcipher - Enforce non-ASYNC for on-stack requests Kees Cook
2018-09-06 22:58 ` Kees Cook
2018-09-07 3:42 ` Herbert Xu [this message]
2018-09-07 3:42 ` Herbert Xu
2018-09-07 6:56 ` Ard Biesheuvel
2018-09-07 6:56 ` Ard Biesheuvel
2018-09-07 6:56 ` Ard Biesheuvel
2018-09-11 5:52 ` Herbert Xu
2018-09-11 5:52 ` Herbert Xu
2018-09-11 5:52 ` Herbert Xu
2018-09-13 16:46 ` Kees Cook
2018-09-13 16:46 ` Kees Cook
2018-09-13 16:46 ` Kees Cook
2018-09-13 17:40 ` Kees Cook
2018-09-13 17:40 ` Kees Cook
2018-09-13 17:40 ` Kees Cook
2018-09-07 16:02 ` Kees Cook
2018-09-07 16:02 ` Kees Cook
2018-09-11 5:53 ` Herbert Xu
2018-09-11 5:53 ` Herbert Xu
2018-09-06 22:58 ` [PATCH v2 3/4] crypto: skcipher - Remove VLA usage for SKCIPHER_REQUEST_ON_STACK Kees Cook
2018-09-06 22:58 ` Kees Cook
2018-09-06 22:58 ` [PATCH 4/4] crypto: skcipher - Remove unused argument to SKCIPHER_REQUEST_ON_STACK() Kees Cook
2018-09-06 22:58 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180907034242.zhm4dglzkldhvh3x@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=Jonathan.Cameron@huawei.com \
--cc=alexander.stein@systec-electronic.com \
--cc=antoine.tenart@bootlin.com \
--cc=ard.biesheuvel@linaro.org \
--cc=arno@natisbad.org \
--cc=boris.brezillon@bootlin.com \
--cc=chunkeey@gmail.com \
--cc=clabbe.montjoie@gmail.com \
--cc=ebiggers@google.com \
--cc=gilad@benyossef.com \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=pombredanne@nexb.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.