From: Jan Kara <jack@suse.cz> To: Richard Guy Briggs <rgb@redhat.com> Cc: Jan Kara <jack@suse.cz>, Paul Moore <paul@paul-moore.com>, Al Viro <viro@zeniv.linux.org.uk>, linux-audit@redhat.com, linux-fsdevel@vger.kernel.org, Amir Goldstein <amir73il@gmail.com> Subject: Re: [PATCH 09/11] audit: Allocate fsnotify mark independently of chunk Date: Mon, 17 Sep 2018 18:46:23 +0200 [thread overview] Message-ID: <20180917164623.GC10257@quack2.suse.cz> (raw) In-Reply-To: <20180914140909.4q77jy2nuqes2azt@madcap2.tricolour.ca> On Fri 14-09-18 10:09:09, Richard Guy Briggs wrote: > On 2018-09-04 18:06, Jan Kara wrote: > > Allocate fsnotify mark independently instead of embedding it inside > > chunk. This will allow us to just replace chunk attached to mark when > > growing / shrinking chunk instead of replacing mark attached to inode > > which is a more complex operation. > > > > Signed-off-by: Jan Kara <jack@suse.cz> > > --- ... > > +static struct audit_chunk *mark_chunk(struct fsnotify_mark *mark) > > +{ > > + return audit_mark(mark)->chunk; > > +} > > + > > static void audit_tree_destroy_watch(struct fsnotify_mark *entry) > > { > > - struct audit_chunk *chunk = container_of(entry, struct audit_chunk, mark); > > + struct audit_chunk *chunk = mark_chunk(entry); > > audit_mark_put_chunk(chunk); > > + kmem_cache_free(audit_tree_mark_cachep, audit_mark(entry)); > > +} > > + > > +static struct fsnotify_mark *alloc_mark(void) > > +{ > > + struct audit_tree_mark *mark; > > Would it make sense to call this local variable "amark" to indicate it > isn't a struct fsnotify_mark, but in fact an audit helper variant? > > > + > > + mark = kmem_cache_zalloc(audit_tree_mark_cachep, GFP_KERNEL); > > + if (!mark) > > + return NULL; > > + fsnotify_init_mark(&mark->mark, audit_tree_group); > > + mark->mark.mask = FS_IN_IGNORED; > > + return &mark->mark; > > There are no other places where it is used in this patch to name a > variable, but this one I found a bit confusing to follow the > "mark->mark" Yeah, makes sense. I can do the change. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz> To: Richard Guy Briggs <rgb@redhat.com> Cc: Jan Kara <jack@suse.cz>, Amir Goldstein <amir73il@gmail.com>, linux-audit@redhat.com, Al Viro <viro@zeniv.linux.org.uk>, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH 09/11] audit: Allocate fsnotify mark independently of chunk Date: Mon, 17 Sep 2018 18:46:23 +0200 [thread overview] Message-ID: <20180917164623.GC10257@quack2.suse.cz> (raw) In-Reply-To: <20180914140909.4q77jy2nuqes2azt@madcap2.tricolour.ca> On Fri 14-09-18 10:09:09, Richard Guy Briggs wrote: > On 2018-09-04 18:06, Jan Kara wrote: > > Allocate fsnotify mark independently instead of embedding it inside > > chunk. This will allow us to just replace chunk attached to mark when > > growing / shrinking chunk instead of replacing mark attached to inode > > which is a more complex operation. > > > > Signed-off-by: Jan Kara <jack@suse.cz> > > --- ... > > +static struct audit_chunk *mark_chunk(struct fsnotify_mark *mark) > > +{ > > + return audit_mark(mark)->chunk; > > +} > > + > > static void audit_tree_destroy_watch(struct fsnotify_mark *entry) > > { > > - struct audit_chunk *chunk = container_of(entry, struct audit_chunk, mark); > > + struct audit_chunk *chunk = mark_chunk(entry); > > audit_mark_put_chunk(chunk); > > + kmem_cache_free(audit_tree_mark_cachep, audit_mark(entry)); > > +} > > + > > +static struct fsnotify_mark *alloc_mark(void) > > +{ > > + struct audit_tree_mark *mark; > > Would it make sense to call this local variable "amark" to indicate it > isn't a struct fsnotify_mark, but in fact an audit helper variant? > > > + > > + mark = kmem_cache_zalloc(audit_tree_mark_cachep, GFP_KERNEL); > > + if (!mark) > > + return NULL; > > + fsnotify_init_mark(&mark->mark, audit_tree_group); > > + mark->mark.mask = FS_IN_IGNORED; > > + return &mark->mark; > > There are no other places where it is used in this patch to name a > variable, but this one I found a bit confusing to follow the > "mark->mark" Yeah, makes sense. I can do the change. Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
next prev parent reply other threads:[~2018-09-17 22:14 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-04 16:06 [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 01/11] audit_tree: Remove mark->lock locking Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 02/11] audit: Fix possible spurious -ENOSPC error Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 03/11] audit: Fix possible tagging failures Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 04/11] audit: Embed key into chunk Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-13 20:06 ` Richard Guy Briggs 2018-09-13 20:06 ` Richard Guy Briggs 2018-09-04 16:06 ` [PATCH 05/11] audit: Make hash table insertion safe against concurrent lookups Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 06/11] audit: Factor out chunk replacement code Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 07/11] audit: Remove pointless check in insert_hash() Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 08/11] audit: Provide helper for dropping mark's chunk reference Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 09/11] audit: Allocate fsnotify mark independently of chunk Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-14 14:09 ` Richard Guy Briggs 2018-09-14 14:09 ` Richard Guy Briggs 2018-09-17 16:46 ` Jan Kara [this message] 2018-09-17 16:46 ` Jan Kara 2018-10-03 22:11 ` Paul Moore 2018-10-03 22:11 ` Paul Moore 2018-10-03 22:08 ` Paul Moore 2018-10-03 22:08 ` Paul Moore 2018-10-03 22:39 ` Richard Guy Briggs 2018-10-03 22:39 ` Richard Guy Briggs 2018-10-04 6:57 ` Jan Kara 2018-10-04 6:57 ` Jan Kara 2018-09-04 16:06 ` [PATCH 10/11] audit: Replace chunk attached to mark instead of replacing mark Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-04 16:06 ` [PATCH 11/11] audit: Use 'mark' name for fsnotify_mark variables Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-14 18:29 ` Richard Guy Briggs 2018-09-14 18:29 ` Richard Guy Briggs 2018-09-17 16:44 ` Jan Kara 2018-09-17 16:44 ` Jan Kara 2018-09-17 18:13 ` Richard Guy Briggs 2018-09-17 18:13 ` Richard Guy Briggs 2018-09-04 16:06 ` [PATCH 12/11 TESTSUITE] audit_testsuite: Add stress test for tree watches Jan Kara 2018-09-04 16:06 ` Jan Kara 2018-09-14 18:21 ` Richard Guy Briggs 2018-09-14 18:21 ` Richard Guy Briggs 2018-09-17 16:56 ` Jan Kara 2018-09-17 16:56 ` Jan Kara 2018-10-05 21:06 ` Paul Moore 2018-10-05 21:06 ` Paul Moore 2018-10-09 7:40 ` Jan Kara 2018-10-09 7:40 ` Jan Kara 2018-10-10 6:43 ` Paul Moore 2018-10-10 6:43 ` Paul Moore 2018-10-11 11:39 ` Jan Kara 2018-10-11 11:39 ` Jan Kara 2018-10-11 23:03 ` Paul Moore 2018-10-11 23:03 ` Paul Moore 2018-10-15 10:04 ` Jan Kara 2018-10-15 10:04 ` Jan Kara 2018-10-15 15:39 ` Paul Moore 2018-10-15 15:39 ` Paul Moore 2018-10-17 10:09 ` Jan Kara 2018-10-17 10:09 ` Jan Kara 2018-11-14 0:34 ` Paul Moore 2018-11-14 0:34 ` Paul Moore 2018-11-14 12:16 ` Jan Kara 2018-11-14 12:16 ` Jan Kara 2018-11-19 15:19 ` Paul Moore 2018-11-19 15:19 ` Paul Moore 2018-09-14 19:13 ` [PATCH 0/11 v3] audit: Fix various races when tagging and untagging mounts Richard Guy Briggs 2018-09-14 19:13 ` Richard Guy Briggs 2018-09-17 16:57 ` Jan Kara 2018-09-17 16:57 ` Jan Kara 2018-10-04 1:20 ` Paul Moore 2018-10-04 1:20 ` Paul Moore 2018-10-04 6:59 ` Jan Kara 2018-10-04 6:59 ` Jan Kara
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180917164623.GC10257@quack2.suse.cz \ --to=jack@suse.cz \ --cc=amir73il@gmail.com \ --cc=linux-audit@redhat.com \ --cc=linux-fsdevel@vger.kernel.org \ --cc=paul@paul-moore.com \ --cc=rgb@redhat.com \ --cc=viro@zeniv.linux.org.uk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.