* [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs
@ 2018-10-09 13:27 Håkon Bugge
2018-10-09 13:27 ` [PATCH v3 1/2] IB/mlx4: Enable debug print of SMPs Håkon Bugge
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Håkon Bugge @ 2018-10-09 13:27 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel
Cc: leon
SMPs were not printed at all. Added printing of port number and TID to
all MADs
Håkon Bugge (2):
IB/mlx4: Enable debug print of SMPs
IB/mlx4: Add port and TID to MAD debug print
drivers/infiniband/hw/mlx4/mad.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
--
v1 -> v2
* Fixed incorrect format for printing the TID for the second patch
v2 -> v3
* Made v3 consistently for cover-letter and the two patches, my v2
was partly original submission plus a v2. That probably fooled
both the kbuild bot and patchwork
2.14.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v3 1/2] IB/mlx4: Enable debug print of SMPs
2018-10-09 13:27 [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs Håkon Bugge
@ 2018-10-09 13:27 ` Håkon Bugge
2018-10-09 13:27 ` [PATCH v3 2/2] IB/mlx4: Add port and TID to MAD debug print Håkon Bugge
2018-10-16 18:23 ` [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs Doug Ledford
2 siblings, 0 replies; 4+ messages in thread
From: Håkon Bugge @ 2018-10-09 13:27 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel
Cc: leon
IB Subnet Management Packets (SMPs) were excluded from debug prints.
Fixed by enabling print even on QP0 MADs.
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
---
v1 -> v3:
* No changes
---
drivers/infiniband/hw/mlx4/mad.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index e5466d786bb1..1718715cc094 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -807,7 +807,7 @@ static int ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num,
int err;
struct ib_port_attr pattr;
- if (in_wc && in_wc->qp->qp_num) {
+ if (in_wc && in_wc->qp) {
pr_debug("received MAD: slid:%d sqpn:%d "
"dlid_bits:%d dqpn:%d wc_flags:0x%x, cls %x, mtd %x, atr %x\n",
in_wc->slid, in_wc->src_qp,
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v3 2/2] IB/mlx4: Add port and TID to MAD debug print
2018-10-09 13:27 [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs Håkon Bugge
2018-10-09 13:27 ` [PATCH v3 1/2] IB/mlx4: Enable debug print of SMPs Håkon Bugge
@ 2018-10-09 13:27 ` Håkon Bugge
2018-10-16 18:23 ` [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs Doug Ledford
2 siblings, 0 replies; 4+ messages in thread
From: Håkon Bugge @ 2018-10-09 13:27 UTC (permalink / raw)
To: Yishai Hadas, Doug Ledford, Jason Gunthorpe, linux-rdma, linux-kernel
Cc: leon
Add said information and make the debug print format consistent.
Signed-off-by: Håkon Bugge <haakon.bugge@oracle.com>
Acked-by: Leon Romanovsky <leonro@mellanox.com>
---
v1 -> v2:
* Fixed incorrect format for printing the TID
v2 -> v3:
* Added Leon's a-b
---
drivers/infiniband/hw/mlx4/mad.c | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/mad.c b/drivers/infiniband/hw/mlx4/mad.c
index 1718715cc094..8942f5f7f04d 100644
--- a/drivers/infiniband/hw/mlx4/mad.c
+++ b/drivers/infiniband/hw/mlx4/mad.c
@@ -808,14 +808,16 @@ static int ib_process_mad(struct ib_device *ibdev, int mad_flags, u8 port_num,
struct ib_port_attr pattr;
if (in_wc && in_wc->qp) {
- pr_debug("received MAD: slid:%d sqpn:%d "
- "dlid_bits:%d dqpn:%d wc_flags:0x%x, cls %x, mtd %x, atr %x\n",
- in_wc->slid, in_wc->src_qp,
- in_wc->dlid_path_bits,
- in_wc->qp->qp_num,
- in_wc->wc_flags,
- in_mad->mad_hdr.mgmt_class, in_mad->mad_hdr.method,
- be16_to_cpu(in_mad->mad_hdr.attr_id));
+ pr_debug("received MAD: port:%d slid:%d sqpn:%d "
+ "dlid_bits:%d dqpn:%d wc_flags:0x%x tid:%016llx cls:%x mtd:%x atr:%x\n",
+ port_num,
+ in_wc->slid, in_wc->src_qp,
+ in_wc->dlid_path_bits,
+ in_wc->qp->qp_num,
+ in_wc->wc_flags,
+ be64_to_cpu(in_mad->mad_hdr.tid),
+ in_mad->mad_hdr.mgmt_class, in_mad->mad_hdr.method,
+ be16_to_cpu(in_mad->mad_hdr.attr_id));
if (in_wc->wc_flags & IB_WC_GRH) {
pr_debug("sgid_hi:0x%016llx sgid_lo:0x%016llx\n",
be64_to_cpu(in_grh->sgid.global.subnet_prefix),
--
2.14.3
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs
2018-10-09 13:27 [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs Håkon Bugge
2018-10-09 13:27 ` [PATCH v3 1/2] IB/mlx4: Enable debug print of SMPs Håkon Bugge
2018-10-09 13:27 ` [PATCH v3 2/2] IB/mlx4: Add port and TID to MAD debug print Håkon Bugge
@ 2018-10-16 18:23 ` Doug Ledford
2 siblings, 0 replies; 4+ messages in thread
From: Doug Ledford @ 2018-10-16 18:23 UTC (permalink / raw)
To: Håkon Bugge, Yishai Hadas, Jason Gunthorpe, linux-rdma,
linux-kernel
Cc: leon
[-- Attachment #1: Type: text/plain, Size: 864 bytes --]
On Tue, 2018-10-09 at 15:27 +0200, Håkon Bugge wrote:
> SMPs were not printed at all. Added printing of port number and TID to
> all MADs
>
>
> Håkon Bugge (2):
> IB/mlx4: Enable debug print of SMPs
> IB/mlx4: Add port and TID to MAD debug print
>
> drivers/infiniband/hw/mlx4/mad.c | 20 +++++++++++---------
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> --
>
> v1 -> v2
> * Fixed incorrect format for printing the TID for the second patch
> v2 -> v3
> * Made v3 consistently for cover-letter and the two patches, my v2
> was partly original submission plus a v2. That probably fooled
> both the kbuild bot and patchwork
>
> 2.14.3
Thanks, applied.
--
Doug Ledford <dledford@redhat.com>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-10-16 18:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-09 13:27 [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs Håkon Bugge
2018-10-09 13:27 ` [PATCH v3 1/2] IB/mlx4: Enable debug print of SMPs Håkon Bugge
2018-10-09 13:27 ` [PATCH v3 2/2] IB/mlx4: Add port and TID to MAD debug print Håkon Bugge
2018-10-16 18:23 ` [PATCH v3 0/2] IB/mlx4: Enable debug print of SMPs and enhance output for MADs Doug Ledford
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.