From: Boris Brezillon <boris.brezillon@bootlin.com> To: Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> Cc: Tudor Ambarus <tudor.ambarus@microchip.com>, "marek.vasut@gmail.com" <marek.vasut@gmail.com>, "dwmw2@infradead.org" <dwmw2@infradead.org>, "computersforpeace@gmail.com" <computersforpeace@gmail.com>, "richard@nod.at" <richard@nod.at>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "nicolas.ferre@microchip.com" <nicolas.ferre@microchip.com>, "cyrille.pitchen@microchip.com" <cyrille.pitchen@microchip.com>, "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Cristian.Birsan@microchip.com" <Cristian.Birsan@microchip.com> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Date: Tue, 16 Oct 2018 14:17:54 +0200 [thread overview] Message-ID: <20181016141754.38dfcf90@bbrezillon> (raw) In-Reply-To: <20181016140411.3f06e449@bbrezillon> On Tue, 16 Oct 2018 14:04:11 +0200 Boris Brezillon <boris.brezillon@bootlin.com> wrote: > On Tue, 16 Oct 2018 09:51:47 +0000 > Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote: > > > Hi Tudor, > > > > This patch is breaking the 1-4-4 Read protocol for the spansion flash "s25fl512s". > > > > Without this patch read request command for Quad mode, 4-byte enable, is coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. > > But after applying this patch, read request command for Quad mode is coming as 0x6C i.e. SPINOR_OP_READ_1_1_4_4B. > > > > This flash also supports non-uniform erase. > > Can you please check and provide some suggestion? > > Are you sure the regression comes from this patch? I suspect your bug > comes from 41fe242979e4 ("mtd: spi-nor: fsl-quadspi: fix read error for > flash size larger than 16MB"). I guess you're testing with an fsl-qspi controller, right? Can you try with this patch? --->8--- diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index 1ff3430f82c8..c47fe70c9f98 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -477,9 +477,6 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q) static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) { switch (cmd) { - case SPINOR_OP_READ_1_1_4: - case SPINOR_OP_READ_1_1_4_4B: - return SEQID_READ; case SPINOR_OP_WREN: return SEQID_WREN; case SPINOR_OP_WRDI: @@ -490,8 +487,6 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) return SEQID_SE; case SPINOR_OP_CHIP_ERASE: return SEQID_CHIP_ERASE; - case SPINOR_OP_PP: - return SEQID_PP; case SPINOR_OP_RDID: return SEQID_RDID; case SPINOR_OP_WRSR: @@ -503,7 +498,11 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) case SPINOR_OP_BRWR: return SEQID_BRWR; default: - if (cmd == q->nor[0].erase_opcode) + if (cmd == q->nor[0].read_opcode) + return SEQID_READ; + else if (cmd == q->nor[0].program_opcode) + return SEQID_PP; + else if (cmd == q->nor[0].erase_opcode) return SEQID_SE; dev_err(q->dev, "Unsupported cmd 0x%.2x\n", cmd); break;
WARNING: multiple messages have this Message-ID (diff)
From: boris.brezillon@bootlin.com (Boris Brezillon) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories Date: Tue, 16 Oct 2018 14:17:54 +0200 [thread overview] Message-ID: <20181016141754.38dfcf90@bbrezillon> (raw) In-Reply-To: <20181016140411.3f06e449@bbrezillon> On Tue, 16 Oct 2018 14:04:11 +0200 Boris Brezillon <boris.brezillon@bootlin.com> wrote: > On Tue, 16 Oct 2018 09:51:47 +0000 > Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com> wrote: > > > Hi Tudor, > > > > This patch is breaking the 1-4-4 Read protocol for the spansion flash "s25fl512s". > > > > Without this patch read request command for Quad mode, 4-byte enable, is coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. > > But after applying this patch, read request command for Quad mode is coming as 0x6C i.e. SPINOR_OP_READ_1_1_4_4B. > > > > This flash also supports non-uniform erase. > > Can you please check and provide some suggestion? > > Are you sure the regression comes from this patch? I suspect your bug > comes from 41fe242979e4 ("mtd: spi-nor: fsl-quadspi: fix read error for > flash size larger than 16MB"). I guess you're testing with an fsl-qspi controller, right? Can you try with this patch? --->8--- diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index 1ff3430f82c8..c47fe70c9f98 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -477,9 +477,6 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q) static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) { switch (cmd) { - case SPINOR_OP_READ_1_1_4: - case SPINOR_OP_READ_1_1_4_4B: - return SEQID_READ; case SPINOR_OP_WREN: return SEQID_WREN; case SPINOR_OP_WRDI: @@ -490,8 +487,6 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) return SEQID_SE; case SPINOR_OP_CHIP_ERASE: return SEQID_CHIP_ERASE; - case SPINOR_OP_PP: - return SEQID_PP; case SPINOR_OP_RDID: return SEQID_RDID; case SPINOR_OP_WRSR: @@ -503,7 +498,11 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd) case SPINOR_OP_BRWR: return SEQID_BRWR; default: - if (cmd == q->nor[0].erase_opcode) + if (cmd == q->nor[0].read_opcode) + return SEQID_READ; + else if (cmd == q->nor[0].program_opcode) + return SEQID_PP; + else if (cmd == q->nor[0].erase_opcode) return SEQID_SE; dev_err(q->dev, "Unsupported cmd 0x%.2x\n", cmd); break;
next prev parent reply other threads:[~2018-10-16 12:18 UTC|newest] Thread overview: 158+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-09-11 15:40 [PATCH v3 0/2] add support to non-uniform SFDP SPI NOR flash memories Tudor Ambarus 2018-09-11 15:40 ` Tudor Ambarus 2018-09-11 15:40 ` [PATCH v3 1/2] mtd: spi-nor: " Tudor Ambarus 2018-09-11 15:40 ` Tudor Ambarus 2018-09-11 18:55 ` Marek Vasut 2018-09-11 18:55 ` Marek Vasut 2018-09-17 17:03 ` Tudor Ambarus 2018-09-17 17:03 ` Tudor Ambarus 2018-10-16 9:51 ` Yogesh Narayan Gaur 2018-10-16 9:51 ` Yogesh Narayan Gaur 2018-10-16 9:51 ` Yogesh Narayan Gaur 2018-10-16 12:04 ` Boris Brezillon 2018-10-16 12:04 ` Boris Brezillon 2018-10-16 12:04 ` Boris Brezillon 2018-10-16 12:17 ` Boris Brezillon [this message] 2018-10-16 12:17 ` Boris Brezillon 2018-10-16 12:17 ` Boris Brezillon 2018-10-17 1:54 ` Yogesh Narayan Gaur 2018-10-17 1:54 ` Yogesh Narayan Gaur 2018-10-17 1:54 ` Yogesh Narayan Gaur 2018-10-16 15:14 ` Tudor Ambarus 2018-10-16 15:14 ` Tudor Ambarus 2018-10-16 15:14 ` Tudor Ambarus 2018-10-16 16:34 ` Cyrille Pitchen 2018-10-16 16:34 ` Cyrille Pitchen 2018-10-16 16:34 ` Cyrille Pitchen 2018-10-17 2:07 ` Yogesh Narayan Gaur 2018-10-17 2:07 ` Yogesh Narayan Gaur 2018-10-17 2:07 ` Yogesh Narayan Gaur 2018-10-17 3:50 ` Yogesh Narayan Gaur 2018-10-17 3:50 ` Yogesh Narayan Gaur 2018-10-17 3:50 ` Yogesh Narayan Gaur 2018-10-17 7:07 ` Boris Brezillon 2018-10-17 7:07 ` Boris Brezillon 2018-10-17 7:07 ` Boris Brezillon 2018-10-17 7:10 ` Boris Brezillon 2018-10-17 7:10 ` Boris Brezillon 2018-10-17 7:10 ` Boris Brezillon 2018-10-17 7:17 ` Boris Brezillon 2018-10-17 7:17 ` Boris Brezillon 2018-10-17 7:17 ` Boris Brezillon 2018-10-17 7:29 ` Boris Brezillon 2018-10-17 7:29 ` Boris Brezillon 2018-10-17 7:29 ` Boris Brezillon 2018-10-17 7:46 ` Yogesh Narayan Gaur 2018-10-17 7:46 ` Yogesh Narayan Gaur 2018-10-17 7:46 ` Yogesh Narayan Gaur 2018-10-17 8:00 ` Tudor Ambarus 2018-10-17 8:00 ` Tudor Ambarus 2018-10-17 8:00 ` Tudor Ambarus 2018-10-17 8:20 ` Yogesh Narayan Gaur 2018-10-17 8:20 ` Yogesh Narayan Gaur 2018-10-17 8:20 ` Yogesh Narayan Gaur 2018-10-17 8:48 ` Boris Brezillon 2018-10-17 8:48 ` Boris Brezillon 2018-10-17 8:48 ` Boris Brezillon 2018-10-17 9:52 ` Boris Brezillon 2018-10-17 9:52 ` Boris Brezillon 2018-10-17 9:52 ` Boris Brezillon 2018-10-22 6:04 ` Yogesh Narayan Gaur 2018-10-22 6:04 ` Yogesh Narayan Gaur 2018-10-22 6:04 ` Yogesh Narayan Gaur 2018-10-22 7:34 ` Boris Brezillon 2018-10-22 7:34 ` Boris Brezillon 2018-10-22 7:34 ` Boris Brezillon 2018-10-22 8:01 ` Boris Brezillon 2018-10-22 8:01 ` Boris Brezillon 2018-10-22 8:01 ` Boris Brezillon 2018-10-22 8:32 ` Yogesh Narayan Gaur 2018-10-22 8:32 ` Yogesh Narayan Gaur 2018-10-22 8:32 ` Yogesh Narayan Gaur 2018-10-22 9:09 ` Boris Brezillon 2018-10-22 9:09 ` Boris Brezillon 2018-10-22 9:09 ` Boris Brezillon 2018-10-22 8:33 ` Tudor Ambarus 2018-10-22 8:33 ` Tudor Ambarus 2018-10-22 8:33 ` Tudor Ambarus 2018-10-22 9:15 ` Boris Brezillon 2018-10-22 9:15 ` Boris Brezillon 2018-10-22 9:15 ` Boris Brezillon 2018-10-22 10:03 ` Yogesh Narayan Gaur 2018-10-22 10:03 ` Yogesh Narayan Gaur 2018-10-22 10:03 ` Yogesh Narayan Gaur 2018-10-22 10:10 ` Boris Brezillon 2018-10-22 10:10 ` Boris Brezillon 2018-10-22 10:10 ` Boris Brezillon 2018-10-22 10:17 ` Yogesh Narayan Gaur 2018-10-22 10:17 ` Yogesh Narayan Gaur 2018-10-22 10:17 ` Yogesh Narayan Gaur 2018-10-22 10:25 ` Boris Brezillon 2018-10-22 10:25 ` Boris Brezillon 2018-10-22 10:25 ` Boris Brezillon 2018-10-22 10:20 ` Boris Brezillon 2018-10-22 10:20 ` Boris Brezillon 2018-10-22 10:20 ` Boris Brezillon 2018-10-22 10:26 ` Boris Brezillon 2018-10-22 10:26 ` Boris Brezillon 2018-10-22 10:26 ` Boris Brezillon 2018-10-22 10:39 ` Yogesh Narayan Gaur 2018-10-22 10:39 ` Yogesh Narayan Gaur 2018-10-22 10:39 ` Yogesh Narayan Gaur 2018-10-22 10:46 ` Boris Brezillon 2018-10-22 10:46 ` Boris Brezillon 2018-10-22 10:46 ` Boris Brezillon 2018-10-22 10:52 ` Boris Brezillon 2018-10-22 10:52 ` Boris Brezillon 2018-10-22 10:52 ` Boris Brezillon 2018-10-22 11:03 ` Yogesh Narayan Gaur 2018-10-22 11:03 ` Yogesh Narayan Gaur 2018-10-22 11:03 ` Yogesh Narayan Gaur 2018-10-22 11:43 ` Boris Brezillon 2018-10-22 11:43 ` Boris Brezillon 2018-10-22 11:43 ` Boris Brezillon 2018-10-22 11:46 ` Yogesh Narayan Gaur 2018-10-22 11:46 ` Yogesh Narayan Gaur 2018-10-22 11:46 ` Yogesh Narayan Gaur 2018-10-22 11:52 ` Boris Brezillon 2018-10-22 11:52 ` Boris Brezillon 2018-10-22 11:52 ` Boris Brezillon 2018-10-23 4:47 ` Yogesh Narayan Gaur 2018-10-23 4:47 ` Yogesh Narayan Gaur 2018-10-23 4:47 ` Yogesh Narayan Gaur 2018-10-23 5:39 ` Boris Brezillon 2018-10-23 5:39 ` Boris Brezillon 2018-10-23 5:39 ` Boris Brezillon 2018-10-23 8:18 ` Yogesh Narayan Gaur 2018-10-23 8:18 ` Yogesh Narayan Gaur 2018-10-23 8:18 ` Yogesh Narayan Gaur 2018-10-23 8:48 ` Boris Brezillon 2018-10-23 8:48 ` Boris Brezillon 2018-10-23 8:48 ` Boris Brezillon 2018-10-23 8:59 ` Yogesh Narayan Gaur 2018-10-23 8:59 ` Yogesh Narayan Gaur 2018-10-23 8:59 ` Yogesh Narayan Gaur 2018-10-23 9:09 ` Boris Brezillon 2018-10-23 9:09 ` Boris Brezillon 2018-10-23 9:09 ` Boris Brezillon 2018-10-23 9:01 ` Boris Brezillon 2018-10-23 9:01 ` Boris Brezillon 2018-10-23 9:01 ` Boris Brezillon 2018-10-23 9:05 ` Yogesh Narayan Gaur 2018-10-23 9:05 ` Yogesh Narayan Gaur 2018-10-23 9:05 ` Yogesh Narayan Gaur 2018-10-23 9:10 ` Boris Brezillon 2018-10-23 9:10 ` Boris Brezillon 2018-10-23 9:10 ` Boris Brezillon 2018-10-23 9:15 ` Yogesh Narayan Gaur 2018-10-23 9:15 ` Yogesh Narayan Gaur 2018-10-23 9:15 ` Yogesh Narayan Gaur 2018-10-17 9:06 ` Cyrille Pitchen 2018-10-17 9:06 ` Cyrille Pitchen 2018-10-17 9:06 ` Cyrille Pitchen 2018-09-11 15:40 ` [PATCH v3 2/2] mtd: spi-nor: parse SFDP Sector Map Parameter Table Tudor Ambarus 2018-09-11 15:40 ` Tudor Ambarus 2018-09-11 18:56 ` Marek Vasut 2018-09-11 18:56 ` Marek Vasut 2018-09-18 13:09 ` [PATCH v3 0/2] add support to non-uniform SFDP SPI NOR flash memories Boris Brezillon 2018-09-18 13:09 ` Boris Brezillon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181016141754.38dfcf90@bbrezillon \ --to=boris.brezillon@bootlin.com \ --cc=Cristian.Birsan@microchip.com \ --cc=computersforpeace@gmail.com \ --cc=cyrille.pitchen@microchip.com \ --cc=dwmw2@infradead.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=marek.vasut@gmail.com \ --cc=nicolas.ferre@microchip.com \ --cc=richard@nod.at \ --cc=tudor.ambarus@microchip.com \ --cc=yogeshnarayan.gaur@nxp.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.