* [PATCH] staging: wlan-ng: Replace long int with long
@ 2018-10-18 4:38 Maya Nakamura
2018-10-18 5:04 ` [Outreachy kernel] " Vaishali Thakkar
0 siblings, 1 reply; 2+ messages in thread
From: Maya Nakamura @ 2018-10-18 4:38 UTC (permalink / raw)
To: gregkh, outreachy-kernel
Replace long int with long as int is unnecessary. Issue found by
checkpatch.pl.
Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
---
drivers/staging/wlan-ng/p80211conv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
index 91debcf20646..0ff5fda81b05 100644
--- a/drivers/staging/wlan-ng/p80211conv.c
+++ b/drivers/staging/wlan-ng/p80211conv.c
@@ -430,7 +430,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32 ethconv,
/* A bogus length ethfrm has been sent. */
/* Is someone trying an oflow attack? */
netdev_err(netdev, "DIXII frame too large (%ld > %d)\n",
- (long int)(payload_length -
+ (long)(payload_length -
sizeof(struct wlan_llc) -
sizeof(struct wlan_snap)), netdev->mtu);
return 1;
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Outreachy kernel] [PATCH] staging: wlan-ng: Replace long int with long
2018-10-18 4:38 [PATCH] staging: wlan-ng: Replace long int with long Maya Nakamura
@ 2018-10-18 5:04 ` Vaishali Thakkar
0 siblings, 0 replies; 2+ messages in thread
From: Vaishali Thakkar @ 2018-10-18 5:04 UTC (permalink / raw)
To: M. Nakamura; +Cc: Greg KH, outreachy-kernel
On Thu, Oct 18, 2018 at 10:08 AM Maya Nakamura
<m.maya.nakamura@gmail.com> wrote:
>
> Replace long int with long as int is unnecessary. Issue found by
> checkpatch.pl.
It'll be good to explain why do you think 'long int' is unnecessary
here.
> Signed-off-by: Maya Nakamura <m.maya.nakamura@gmail.com>
> ---
> drivers/staging/wlan-ng/p80211conv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/wlan-ng/p80211conv.c b/drivers/staging/wlan-ng/p80211conv.c
> index 91debcf20646..0ff5fda81b05 100644
> --- a/drivers/staging/wlan-ng/p80211conv.c
> +++ b/drivers/staging/wlan-ng/p80211conv.c
> @@ -430,7 +430,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32 ethconv,
> /* A bogus length ethfrm has been sent. */
> /* Is someone trying an oflow attack? */
> netdev_err(netdev, "DIXII frame too large (%ld > %d)\n",
> - (long int)(payload_length -
> + (long)(payload_length -
> sizeof(struct wlan_llc) -
> sizeof(struct wlan_snap)), netdev->mtu);
> return 1;
> --
> 2.17.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181018043801.GA4248%40k-vBox.
> For more options, visit https://groups.google.com/d/optout.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-10-18 5:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-18 4:38 [PATCH] staging: wlan-ng: Replace long int with long Maya Nakamura
2018-10-18 5:04 ` [Outreachy kernel] " Vaishali Thakkar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.