From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Johannes Weiner <hannes@cmpxchg.org>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org> Subject: [RFC PATCH v2 1/2] mm, oom: marks all killed tasks as oom victims Date: Mon, 22 Oct 2018 13:16:36 +0200 [thread overview] Message-ID: <20181022111636.GA18839@dhcp22.suse.cz> (raw) In-Reply-To: <20181022071323.9550-2-mhocko@kernel.org> Updated version From fdd46ec5dbc0cf571c5a2b9e23a021e0c46b4641 Mon Sep 17 00:00:00 2001 From: Michal Hocko <mhocko@suse.com> Date: Mon, 22 Oct 2018 08:52:33 +0200 Subject: [PATCH 1/2] mm, oom: marks all killed tasks as oom victims Historically we have called mark_oom_victim only to the main task selected as the oom victim because oom victims have access to memory reserves and granting the access to all killed tasks could deplete memory reserves very quickly and cause even larger problems. Since only a partial access to memory reserves is allowed there is no longer this risk and so all tasks killed along with the oom victim can be considered as well. The primary motivation for that is that process groups which do not shared signals would behave more like standard thread groups wrt oom handling (aka tsk_is_oom_victim will work the same way for them). - Use find_lock_task_mm to stabilize mm as suggested by Tetsuo Signed-off-by: Michal Hocko <mhocko@suse.com> --- mm/oom_kill.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/mm/oom_kill.c b/mm/oom_kill.c index f10aa5360616..6be22a0b0ff2 100644 --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -879,6 +879,7 @@ static void __oom_kill_process(struct task_struct *victim) */ rcu_read_lock(); for_each_process(p) { + struct task_struct *t; if (!process_shares_mm(p, mm)) continue; if (same_thread_group(p, victim)) @@ -898,6 +899,11 @@ static void __oom_kill_process(struct task_struct *victim) if (unlikely(p->flags & PF_KTHREAD)) continue; do_send_sig_info(SIGKILL, SEND_SIG_FORCED, p, PIDTYPE_TGID); + t = find_lock_task_mm(p); + if (!t) + continue; + mark_oom_victim(t); + task_unlock(t); } rcu_read_unlock(); -- 2.19.1
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Johannes Weiner <hannes@cmpxchg.org>, Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>, David Rientjes <rientjes@google.com>, Andrew Morton <akpm@linux-foundation.org>, LKML <linux-kernel@vger.kernel.org> Subject: [RFC PATCH v2 1/2] mm, oom: marks all killed tasks as oom victims Date: Mon, 22 Oct 2018 13:16:36 +0200 [thread overview] Message-ID: <20181022111636.GA18839@dhcp22.suse.cz> (raw) In-Reply-To: <20181022071323.9550-2-mhocko@kernel.org> Updated version
next prev parent reply other threads:[~2018-10-22 11:16 UTC|newest] Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-22 7:13 [RFC PATCH 0/2] oom, memcg: do not report racy no-eligible OOM Michal Hocko 2018-10-22 7:13 ` Michal Hocko 2018-10-22 7:13 ` [RFC PATCH 1/2] mm, oom: marks all killed tasks as oom victims Michal Hocko 2018-10-22 7:13 ` Michal Hocko 2018-10-22 7:58 ` Tetsuo Handa 2018-10-22 8:48 ` Michal Hocko 2018-10-22 9:42 ` Tetsuo Handa 2018-10-22 10:43 ` Michal Hocko 2018-10-22 10:56 ` Tetsuo Handa 2018-10-22 11:12 ` Michal Hocko 2018-10-22 11:16 ` Michal Hocko [this message] 2018-10-22 11:16 ` [RFC PATCH v2 " Michal Hocko 2018-10-22 7:13 ` [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks Michal Hocko 2018-10-22 7:13 ` Michal Hocko 2018-10-22 11:45 ` Tetsuo Handa 2018-10-22 12:03 ` Michal Hocko 2018-10-22 13:20 ` Tetsuo Handa 2018-10-22 13:43 ` Michal Hocko 2018-10-22 15:12 ` Tetsuo Handa 2018-10-23 1:01 ` Tetsuo Handa 2018-10-23 11:42 ` Michal Hocko 2018-10-23 12:10 ` Michal Hocko 2018-10-23 12:33 ` Tetsuo Handa 2018-10-23 12:48 ` Michal Hocko 2018-10-26 14:25 ` Johannes Weiner 2018-10-26 19:25 ` Michal Hocko 2018-10-26 19:33 ` Michal Hocko 2018-10-27 1:10 ` Tetsuo Handa 2018-11-06 9:44 ` Tetsuo Handa 2018-11-06 9:44 ` Tetsuo Handa 2018-11-06 12:42 ` Michal Hocko 2018-11-07 9:45 ` Tetsuo Handa 2018-11-07 10:08 ` Michal Hocko 2018-12-07 12:43 ` Tetsuo Handa 2018-12-12 10:23 ` Tetsuo Handa 2018-12-12 10:23 ` Tetsuo Handa
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181022111636.GA18839@dhcp22.suse.cz \ --to=mhocko@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=hannes@cmpxchg.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=penguin-kernel@I-love.SAKURA.ne.jp \ --cc=rientjes@google.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.