[OSSTEST PATCH 1/3] sa-init-db: Fix argument parsing

[OSSTEST PATCH 1/3] sa-init-db: Fix argument parsing

[Ian Jackson]

It claimed to have a default db name, but it didn't.  Rework the
option parsing to make the usage message true.  (That saves me typing
  sa-init-db standalone
and getting bizarre errors as sqlite tries to treat the shell script
`standalone' as if it were a database file.)

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 sa-init-db | 17 +++++++++--------
 1 file changed, 9 insertions(+), 8 deletions(-)

diff --git a/sa-init-db b/sa-init-db
index bd9aa4a4..2c97aaba 100755
--- a/sa-init-db
+++ b/sa-init-db
@@ -18,18 +18,19 @@
 
 set -e -o posix
 
-usage(){
-	cat <<END
+badusage(){
+	cat <<END >&2
 usage: ./sa-init-db [database]
 END
+	exit 127
 }
 
-if [ $# -ne 1 ] ; then
-	usage >&2
-	exit 1
-fi
-
-db="$1"
+case "$#.$*" in
+0.)	db=standalone.db	;;
+1.-*)	badusage		;;
+1.*)	db="$1"			;;
+*)	badusage		;;
+esac
 
 sqlite3 "$db" <<END
 	CREATE TABLE flights (
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[OSSTEST PATCH 2/3] standalone-generate-dump-flight-runvars: Add example usage

[Ian Jackson]

I have to reinvent these runes each time, which is somewhat annoying.

Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 standalone-generate-dump-flight-runvars | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/standalone-generate-dump-flight-runvars b/standalone-generate-dump-flight-runvars
index 04631b3d..3b893623 100755
--- a/standalone-generate-dump-flight-runvars
+++ b/standalone-generate-dump-flight-runvars
@@ -7,6 +7,10 @@
 #
 # If no BRANCHes specified, does all that are normally run by
 # cr-daily-branch or out of crontab.
+#
+# A good rune is:
+#   OSSTEST_CONFIG=standalone-config-example ./sa-init-db
+#   OSSTEST_CONFIG=standalone-config-example eatmydata ./standalone-generate-dump-flight-runvars >output
 
 # This is part of "osstest", an automated testing framework for Xen.
 # Copyright (C) 2009-2014 Citrix Inc.
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

[OSSTEST PATCH 3/3] mfi-common: Drop freebsd builds on non-freebsd flights

[Ian Jackson]

Something is wrong with the freebsd repositories.  This causes freebsd
host installation to fail.  This problem has persisted for a while now
and is blocking other work.

For now, drop these.  The jobs being dropped are
      build-amd64-xen-freebsd
      build-amd64-xen-xsm-freebsd
in the branches
      osstest
      xen-unstable
(verified with standalone-generate-dump-flight-runvars).

CC: Roger Pau Monné <roger.pau@citrix.com>
CC: Wei Liu <wei.liu2@citrix.com>
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
---
 mfi-common | 1 +
 1 file changed, 1 insertion(+)

diff --git a/mfi-common b/mfi-common
index ae6a337d..c2866e93 100644
--- a/mfi-common
+++ b/mfi-common
@@ -335,6 +335,7 @@ create_build_jobs () {
       *)                build_on_freebsd=true;;
       esac;;
     esac
+    build_on_freebsd=false
 
     want_prevxen=n
     if branch_wants_migrupgrade_tests ; then
-- 
2.11.0


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

Re: [OSSTEST PATCH 3/3] mfi-common: Drop freebsd builds on non-freebsd flights

[Roger Pau Monné]

On Wed, Oct 24, 2018 at 11:32:01AM +0100, Ian Jackson wrote:
> Something is wrong with the freebsd repositories.  This causes freebsd
> host installation to fail.  This problem has persisted for a while now
> and is blocking other work.
> 
> For now, drop these.  The jobs being dropped are
>       build-amd64-xen-freebsd
>       build-amd64-xen-xsm-freebsd
> in the branches
>       osstest
>       xen-unstable
> (verified with standalone-generate-dump-flight-runvars).
> 
> CC: Roger Pau Monné <roger.pau@citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>

Acked-by: Roger Pau Monné <roger.pau@citrix.com>

I'm really sorry, I've been trying to get this fixed upstream but
there seems to be some (infra?) issues because FreeBSD is in the
middle of the branching process for the 12.0 release.

I have a plan to fix this properly so there's no dependency on
upstream binary packages anymore.

Thanks, Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel