From: Rob Herring <robh@kernel.org> To: Lokesh Vutla <lokeshvutla@ti.com> Cc: Nishanth Menon <nm@ti.com>, Santosh Shilimkar <ssantosh@kernel.org>, tglx@linutronix.de, jason@lakedaemon.net, marc.zyngier@arm.com, Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>, linux-kernel@vger.kernel.org, Tero Kristo <t-kristo@ti.com>, Sekhar Nori <nsekhar@ti.com>, Device Tree Mailing List <devicetree@vger.kernel.org>, Grygorii Strashko <grygorii.strashko@ti.com>, Peter Ujfalusi <peter.ujfalusi@ti.com> Subject: Re: [PATCH v2 06/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Date: Thu, 25 Oct 2018 13:45:56 -0500 [thread overview] Message-ID: <20181025184556.GA19597@bogus> (raw) In-Reply-To: <20181018154017.7112-7-lokeshvutla@ti.com> On Thu, Oct 18, 2018 at 09:10:13PM +0530, Lokesh Vutla wrote: > Add the DT binding documentation for Interrupt router driver. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > Changes since v1: > - Drop dependency on GIC > - Updated supported interrupt types. > > .../interrupt-controller/ti,sci-intr.txt | 81 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > new file mode 100644 > index 000000000000..276bb4f0ad12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > @@ -0,0 +1,81 @@ > +Texas Instruments K3 Interrupt Router > +===================================== > + > +The Interrupt Router (INTR) module provides a mechanism to mux M > +interrupt inputs to N interrupt outputs, where all M inputs are selectable > +to be driven per N output. There is one register per output (MUXCNTL_N) that > +controls the selection. > + > + > + Interrupt Router > + +----------------------+ > + | Inputs Outputs | > + +-------+ | +------+ | > + | GPIO |----------->| | irq0 | | Host IRQ > + +-------+ | +------+ | controller > + | . +-----+ | +-------+ > + +-------+ | . | 0 | |----->| IRQ | > + | INTA |----------->| . +-----+ | +-------+ > + +-------+ | . . | > + | +------+ . | > + | | irqM | +-----+ | > + | +------+ | N | | > + | +-----+ | > + +----------------------+ > + > +Configuration of these MUXCNTL_N registers is done by a system controller > +(like the Device Memory and Security Controller on K3 AM654 SoC). System > +controller will keep track of the used and unused registers within the Router. > +Driver should request the system controller to get the range of GIC IRQs > +assigned to the requesting hosts. It is the drivers responsibility to keep > +track of Host IRQs. > + > +Communication between the host processor running an OS and the system > +controller happens through a protocol called TI System Control Interface > +(TISCI protocol). For more details refer: > +Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > + > +TISCI Interrupt Router Node: > +---------------------------- > +- compatible: Must be "ti,sci-intr". > +- interrupt-controller: Identifies the node as an interrupt controller > +- #interrupt-cells: Specifies the number of cells needed to encode an > + interrupt source. The value should be 3. > + First cell should contain the TISCI device ID of source > + Second cell should contain the interrupt source offset > + within the device > + Third cell specifies the trigger type as defined > + in interrupts.txt in this directory. Only level > + sensitive trigger types are supported. > +- interrupt-parent: phandle of irq parent for TISCI intr. This is implied and could be in a parent node. > +- ti,sci: Phandle to TI-SCI compatible System controller node. > +- ti,sci-dst-id: TISCI device ID of the destination IRQ controller. > +- ti,sci-rm-range-girq: TISCI subtype id representing the host irqs assigned > + to this interrupt router. These need a better explanation and there's still some questions on v1 asked of me that I tried to answer. > + > +Example: > +-------- > +The following example demonstrates both interrupt router node and the consumer > +node(main gpio) on the AM654 SoC: > + > +main_intr: interrupt-controller@1 { > + compatible = "ti,sci-intr"; > + interrupt-controller; > + interrupt-parent = <&gic>; > + #interrupt-cells = <3>; > + ti,sci = <&dmsc>; > + ti,sci-dst-id = <56>; > + ti,sci-rm-range-girq = <0x1>; > +}; > + > +main_gpio0: main_gpio0@600000 { gpio@... > + ... > + interrupt-parent = <&main_intr>; > + interrupts = <57 256 IRQ_TYPE_EDGE_RISING>, > + <57 257 IRQ_TYPE_EDGE_RISING>, > + <57 258 IRQ_TYPE_EDGE_RISING>, > + <57 259 IRQ_TYPE_EDGE_RISING>, > + <57 260 IRQ_TYPE_EDGE_RISING>, > + <57 261 IRQ_TYPE_EDGE_RISING>; > + ... > +}; > diff --git a/MAINTAINERS b/MAINTAINERS > index 06966772cad4..710cf728b9d0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14686,6 +14686,7 @@ F: Documentation/devicetree/bindings/reset/ti,sci-reset.txt > F: Documentation/devicetree/bindings/clock/ti,sci-clk.txt > F: drivers/clk/keystone/sci-clk.c > F: drivers/reset/reset-ti-sci.c > +F: Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > > THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER > M: Hans Verkuil <hverkuil@xs4all.nl> > -- > 2.19.1 >
WARNING: multiple messages have this Message-ID (diff)
From: robh@kernel.org (Rob Herring) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v2 06/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Date: Thu, 25 Oct 2018 13:45:56 -0500 [thread overview] Message-ID: <20181025184556.GA19597@bogus> (raw) In-Reply-To: <20181018154017.7112-7-lokeshvutla@ti.com> On Thu, Oct 18, 2018 at 09:10:13PM +0530, Lokesh Vutla wrote: > Add the DT binding documentation for Interrupt router driver. > > Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com> > --- > Changes since v1: > - Drop dependency on GIC > - Updated supported interrupt types. > > .../interrupt-controller/ti,sci-intr.txt | 81 +++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 82 insertions(+) > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > new file mode 100644 > index 000000000000..276bb4f0ad12 > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > @@ -0,0 +1,81 @@ > +Texas Instruments K3 Interrupt Router > +===================================== > + > +The Interrupt Router (INTR) module provides a mechanism to mux M > +interrupt inputs to N interrupt outputs, where all M inputs are selectable > +to be driven per N output. There is one register per output (MUXCNTL_N) that > +controls the selection. > + > + > + Interrupt Router > + +----------------------+ > + | Inputs Outputs | > + +-------+ | +------+ | > + | GPIO |----------->| | irq0 | | Host IRQ > + +-------+ | +------+ | controller > + | . +-----+ | +-------+ > + +-------+ | . | 0 | |----->| IRQ | > + | INTA |----------->| . +-----+ | +-------+ > + +-------+ | . . | > + | +------+ . | > + | | irqM | +-----+ | > + | +------+ | N | | > + | +-----+ | > + +----------------------+ > + > +Configuration of these MUXCNTL_N registers is done by a system controller > +(like the Device Memory and Security Controller on K3 AM654 SoC). System > +controller will keep track of the used and unused registers within the Router. > +Driver should request the system controller to get the range of GIC IRQs > +assigned to the requesting hosts. It is the drivers responsibility to keep > +track of Host IRQs. > + > +Communication between the host processor running an OS and the system > +controller happens through a protocol called TI System Control Interface > +(TISCI protocol). For more details refer: > +Documentation/devicetree/bindings/arm/keystone/ti,sci.txt > + > +TISCI Interrupt Router Node: > +---------------------------- > +- compatible: Must be "ti,sci-intr". > +- interrupt-controller: Identifies the node as an interrupt controller > +- #interrupt-cells: Specifies the number of cells needed to encode an > + interrupt source. The value should be 3. > + First cell should contain the TISCI device ID of source > + Second cell should contain the interrupt source offset > + within the device > + Third cell specifies the trigger type as defined > + in interrupts.txt in this directory. Only level > + sensitive trigger types are supported. > +- interrupt-parent: phandle of irq parent for TISCI intr. This is implied and could be in a parent node. > +- ti,sci: Phandle to TI-SCI compatible System controller node. > +- ti,sci-dst-id: TISCI device ID of the destination IRQ controller. > +- ti,sci-rm-range-girq: TISCI subtype id representing the host irqs assigned > + to this interrupt router. These need a better explanation and there's still some questions on v1 asked of me that I tried to answer. > + > +Example: > +-------- > +The following example demonstrates both interrupt router node and the consumer > +node(main gpio) on the AM654 SoC: > + > +main_intr: interrupt-controller at 1 { > + compatible = "ti,sci-intr"; > + interrupt-controller; > + interrupt-parent = <&gic>; > + #interrupt-cells = <3>; > + ti,sci = <&dmsc>; > + ti,sci-dst-id = <56>; > + ti,sci-rm-range-girq = <0x1>; > +}; > + > +main_gpio0: main_gpio0 at 600000 { gpio at ... > + ... > + interrupt-parent = <&main_intr>; > + interrupts = <57 256 IRQ_TYPE_EDGE_RISING>, > + <57 257 IRQ_TYPE_EDGE_RISING>, > + <57 258 IRQ_TYPE_EDGE_RISING>, > + <57 259 IRQ_TYPE_EDGE_RISING>, > + <57 260 IRQ_TYPE_EDGE_RISING>, > + <57 261 IRQ_TYPE_EDGE_RISING>; > + ... > +}; > diff --git a/MAINTAINERS b/MAINTAINERS > index 06966772cad4..710cf728b9d0 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -14686,6 +14686,7 @@ F: Documentation/devicetree/bindings/reset/ti,sci-reset.txt > F: Documentation/devicetree/bindings/clock/ti,sci-clk.txt > F: drivers/clk/keystone/sci-clk.c > F: drivers/reset/reset-ti-sci.c > +F: Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt > > THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER > M: Hans Verkuil <hverkuil@xs4all.nl> > -- > 2.19.1 >
next prev parent reply other threads:[~2018-10-25 18:46 UTC|newest] Thread overview: 127+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-18 15:40 [PATCH v2 00/10] Add support for TISCI irqchip drivers Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 01/10] firmware: ti_sci: Add support to get TISCI handle using of_phandle Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 02/10] firmware: ti_sci: Add support for RM core ops Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 03/10] firmware: ti_sci: Add support for IRQ management Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 04/10] firmware: ti_sci: Add RM mapping table for am654 Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 20:42 ` Rob Herring 2018-10-18 20:42 ` Rob Herring 2018-10-18 20:42 ` Rob Herring 2018-10-18 15:40 ` [PATCH v2 05/10] firmware: ti_sci: Add helper apis to manage resources Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 06/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-25 18:45 ` Rob Herring [this message] 2018-10-25 18:45 ` Rob Herring 2018-10-26 6:38 ` Lokesh Vutla 2018-10-26 6:38 ` Lokesh Vutla 2018-10-26 6:38 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 07/10] irqchip: ti-sci-intr: Add support for Interrupt Router driver Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 08/10] dt-bindings: irqchip: Introduce TISCI Interrupt Aggregator bindings Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-19 15:22 ` Marc Zyngier 2018-10-19 15:22 ` Marc Zyngier 2018-10-22 14:35 ` Lokesh Vutla 2018-10-22 14:35 ` Lokesh Vutla 2018-10-22 14:35 ` Lokesh Vutla 2018-10-23 13:50 ` Marc Zyngier 2018-10-23 13:50 ` Marc Zyngier 2018-10-23 13:50 ` Marc Zyngier 2018-10-26 6:39 ` Lokesh Vutla 2018-10-26 6:39 ` Lokesh Vutla 2018-10-26 6:39 ` Lokesh Vutla 2018-10-26 20:19 ` Lokesh Vutla 2018-10-26 20:19 ` Lokesh Vutla 2018-10-26 20:19 ` Lokesh Vutla 2018-10-28 13:31 ` Marc Zyngier 2018-10-28 13:31 ` Marc Zyngier 2018-10-28 13:31 ` Marc Zyngier 2018-10-29 13:04 ` Lokesh Vutla 2018-10-29 13:04 ` Lokesh Vutla 2018-10-29 13:04 ` Lokesh Vutla 2018-11-01 7:55 ` Peter Ujfalusi 2018-11-01 7:55 ` Peter Ujfalusi 2018-11-01 7:55 ` Peter Ujfalusi 2018-11-01 9:00 ` Marc Zyngier 2018-11-01 9:00 ` Marc Zyngier 2018-11-01 9:00 ` Marc Zyngier 2018-11-01 9:14 ` Peter Ujfalusi 2018-11-01 9:14 ` Peter Ujfalusi 2018-11-01 9:14 ` Peter Ujfalusi 2018-11-01 11:15 ` Marc Zyngier 2018-11-01 11:15 ` Marc Zyngier 2018-11-05 8:08 ` Lokesh Vutla 2018-11-05 8:08 ` Lokesh Vutla 2018-11-05 8:08 ` Lokesh Vutla 2018-11-05 15:36 ` Marc Zyngier 2018-11-05 15:36 ` Marc Zyngier 2018-11-05 16:20 ` Lokesh Vutla 2018-11-05 16:20 ` Lokesh Vutla 2018-11-05 16:20 ` Lokesh Vutla 2018-11-05 16:44 ` Marc Zyngier 2018-11-05 16:44 ` Marc Zyngier 2018-11-05 17:56 ` Lokesh Vutla 2018-11-05 17:56 ` Lokesh Vutla 2018-11-05 17:56 ` Lokesh Vutla 2018-10-31 16:39 ` Grygorii Strashko 2018-10-31 16:39 ` Grygorii Strashko 2018-10-31 16:39 ` Grygorii Strashko 2018-10-31 18:21 ` Marc Zyngier 2018-10-31 18:21 ` Marc Zyngier 2018-10-31 18:38 ` Santosh Shilimkar 2018-10-31 18:38 ` Santosh Shilimkar 2018-10-31 18:42 ` Marc Zyngier 2018-10-31 18:42 ` Marc Zyngier 2018-10-31 18:48 ` Santosh Shilimkar 2018-10-31 18:48 ` Santosh Shilimkar 2018-10-31 18:48 ` Santosh Shilimkar 2018-10-31 20:33 ` Grygorii Strashko 2018-10-31 20:33 ` Grygorii Strashko 2018-10-31 20:33 ` Grygorii Strashko 2018-11-01 14:52 ` Marc Zyngier 2018-11-01 14:52 ` Marc Zyngier 2018-11-01 15:36 ` Grygorii Strashko 2018-11-01 15:36 ` Grygorii Strashko 2018-11-01 15:36 ` Grygorii Strashko 2018-11-01 9:09 ` Peter Ujfalusi 2018-11-01 9:09 ` Peter Ujfalusi 2018-11-01 9:09 ` Peter Ujfalusi 2018-10-22 10:42 ` Peter Ujfalusi 2018-10-22 10:42 ` Peter Ujfalusi 2018-10-22 10:42 ` Peter Ujfalusi 2018-10-22 10:43 ` Peter Ujfalusi 2018-10-22 10:43 ` Peter Ujfalusi 2018-10-22 10:43 ` Peter Ujfalusi 2018-10-18 15:40 ` [PATCH v2 10/10] soc: ti: am6: Enable interrupt controller drivers Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-18 15:40 ` Lokesh Vutla 2018-10-22 20:39 ` [PATCH v2 00/10] Add support for TISCI irqchip drivers Santosh Shilimkar 2018-10-22 20:39 ` Santosh Shilimkar 2018-10-23 8:17 ` Lokesh Vutla 2018-10-23 8:17 ` Lokesh Vutla 2018-10-23 8:17 ` Lokesh Vutla 2018-10-23 8:27 ` Marc Zyngier 2018-10-23 8:27 ` Marc Zyngier 2018-10-23 8:27 ` Marc Zyngier 2018-10-23 17:34 ` Santosh Shilimkar 2018-10-23 17:34 ` Santosh Shilimkar 2018-10-26 6:39 ` Lokesh Vutla 2018-10-26 6:39 ` Lokesh Vutla 2018-10-26 6:39 ` Lokesh Vutla
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181025184556.GA19597@bogus \ --to=robh@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=grygorii.strashko@ti.com \ --cc=jason@lakedaemon.net \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lokeshvutla@ti.com \ --cc=marc.zyngier@arm.com \ --cc=nm@ti.com \ --cc=nsekhar@ti.com \ --cc=peter.ujfalusi@ti.com \ --cc=ssantosh@kernel.org \ --cc=t-kristo@ti.com \ --cc=tglx@linutronix.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.