From: Michal Hocko <mhocko@kernel.org> To: <linux-mm@kvack.org> Cc: Andrew Morton <akpm@linux-foundation.org>, Oscar Salvador <OSalvador@suse.com>, Baoquan He <bhe@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: [RFC PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Date: Wed, 7 Nov 2018 11:18:25 +0100 [thread overview] Message-ID: <20181107101830.17405-1-mhocko@kernel.org> (raw) Hi, I have been promissing to improve memory offlining failures debugging for quite some time. As things stand now we get only very limited information in the kernel log when the offlining fails. It is usually only [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000-0x8267fffffff] failed without no further details. We do not know what exactly fails and for what reason. Whenever I was forced to debug such a failure I've always had to do a debugging patch to tell me more. We can enable some tracepoints but it would be much better to get a better picture without using them. This patch series does 2 things. The first one is to make dump_page more usable by printing more information about the mapping patch 1. Then it reduces the log level from emerg to warning so that this function is usable from less critical context patch 2. Then I have added more detailed information about the offlining failure patch 4 and finally add dump_page to isolation and offlining migration paths. Patch 3 is a trivial cleanup. Does this look go to you? Shortlog Michal Hocko (5): mm: print more information about mapping in __dump_page mm: lower the printk loglevel for __dump_page messages mm, memory_hotplug: drop pointless block alignment checks from __offline_pages mm, memory_hotplug: print reason for the offlining failure mm, memory_hotplug: be more verbose for memory offline failures Diffstat: mm/debug.c | 23 ++++++++++++++++++----- mm/memory_hotplug.c | 52 +++++++++++++++++++++++++++++++--------------------- mm/page_alloc.c | 1 + 3 files changed, 50 insertions(+), 26 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Michal Hocko <mhocko@kernel.org> To: linux-mm@kvack.org Cc: Andrew Morton <akpm@linux-foundation.org>, Oscar Salvador <OSalvador@suse.com>, Baoquan He <bhe@redhat.com>, LKML <linux-kernel@vger.kernel.org> Subject: [RFC PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Date: Wed, 7 Nov 2018 11:18:25 +0100 [thread overview] Message-ID: <20181107101830.17405-1-mhocko@kernel.org> (raw) Hi, I have been promissing to improve memory offlining failures debugging for quite some time. As things stand now we get only very limited information in the kernel log when the offlining fails. It is usually only [ 1984.506184] rac1 kernel: memory offlining [mem 0x82600000000-0x8267fffffff] failed without no further details. We do not know what exactly fails and for what reason. Whenever I was forced to debug such a failure I've always had to do a debugging patch to tell me more. We can enable some tracepoints but it would be much better to get a better picture without using them. This patch series does 2 things. The first one is to make dump_page more usable by printing more information about the mapping patch 1. Then it reduces the log level from emerg to warning so that this function is usable from less critical context patch 2. Then I have added more detailed information about the offlining failure patch 4 and finally add dump_page to isolation and offlining migration paths. Patch 3 is a trivial cleanup. Does this look go to you? Shortlog Michal Hocko (5): mm: print more information about mapping in __dump_page mm: lower the printk loglevel for __dump_page messages mm, memory_hotplug: drop pointless block alignment checks from __offline_pages mm, memory_hotplug: print reason for the offlining failure mm, memory_hotplug: be more verbose for memory offline failures Diffstat: mm/debug.c | 23 ++++++++++++++++++----- mm/memory_hotplug.c | 52 +++++++++++++++++++++++++++++++--------------------- mm/page_alloc.c | 1 + 3 files changed, 50 insertions(+), 26 deletions(-)
next reply other threads:[~2018-11-07 10:18 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-07 10:18 Michal Hocko [this message] 2018-11-07 10:18 ` [RFC PATCH 0/5] mm, memory_hotplug: improve memory offlining failures debugging Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 1/5] mm: print more information about mapping in __dump_page Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-24 0:04 ` Andrew Morton 2018-11-24 0:04 ` Andrew Morton 2018-11-25 8:10 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 2/5] mm: lower the printk loglevel for __dump_page messages Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-16 0:56 ` Baoquan He 2018-12-12 14:25 ` Michal Hocko 2018-12-12 14:34 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 3/5] mm, memory_hotplug: drop pointless block alignment checks from __offline_pages Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 4/5] mm, memory_hotplug: print reason for the offlining failure Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-07 22:04 ` Andrew Morton 2018-11-07 22:04 ` Andrew Morton 2018-11-08 8:01 ` Michal Hocko 2018-11-13 8:02 ` Michal Hocko 2018-11-08 6:23 ` Anshuman Khandual 2018-11-08 7:59 ` Michal Hocko 2018-11-07 10:18 ` [RFC PATCH 5/5] mm, memory_hotplug: be more verbose for memory offline failures Michal Hocko 2018-11-07 10:18 ` Michal Hocko 2018-11-08 7:16 ` Anshuman Khandual 2018-11-08 8:12 ` Michal Hocko 2018-11-08 8:19 ` Anshuman Khandual 2018-11-13 8:03 ` Michal Hocko 2018-11-16 0:07 ` Andrew Morton 2018-11-16 0:07 ` Andrew Morton 2018-11-16 7:21 ` Michal Hocko 2018-11-16 7:21 ` Michal Hocko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20181107101830.17405-1-mhocko@kernel.org \ --to=mhocko@kernel.org \ --cc=OSalvador@suse.com \ --cc=akpm@linux-foundation.org \ --cc=bhe@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.