All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong (Peter Hong)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw,
	"Ji-Ze Hong (Peter Hong)" <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH V1 1/1] USB: serial: f81534: fix reading old/new IC config
Date: Tue, 20 Nov 2018 18:29:43 +0100	[thread overview]
Message-ID: <20181120172943.GJ19900@localhost> (raw)
In-Reply-To: <1542250724-11667-1-git-send-email-hpeter+linux_kernel@gmail.com>

On Thu, Nov 15, 2018 at 10:58:44AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81532/534 had a internal configuration space to save & control
> IC state with address F81534_CUSTOM_ADDRESS_START (0x2f00). Layout
> as following:
> 	+00h: to indicate the section is valid
> 	+01h~04h: UART Mode & port availability
> 	+05h~08h: Output pin control on IC power on
> 	+09h~12h: Output pin control on working <-- New added
> 
> Old driver will use +05~08h as default on working, but newer IC will
> configed with shutdown mode(7) in 05h~08h and working mode with RS232(1)
> in 09h~12h. It'll make mainstream driver not working.
> 
> This patch will make mainstream driver compatible older and newer IC.
> If using a old IC, the +05h~08h will be 00h~06h, we'll direct apply it.
> If using a new IC, the +05h~08h will be 07h or larger, we'll read +09h~12h
> to apply newer configuration.
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>

Applied for -next. I guess you can ask Greg if he's willing to take this
into stable once 4.21-rc1 is out (as it is enabling support for a new
class of devices).

Thanks,
Johan

WARNING: multiple messages have this Message-ID (diff)
From: Johan Hovold <johan@kernel.org>
To: "Ji-Ze Hong \(Peter Hong\)" <hpeter@gmail.com>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	peter_hong@fintek.com.tw,
	"Ji-Ze Hong \(Peter Hong\)" <hpeter+linux_kernel@gmail.com>
Subject: [V1,1/1] USB: serial: f81534: fix reading old/new IC config
Date: Tue, 20 Nov 2018 18:29:43 +0100	[thread overview]
Message-ID: <20181120172943.GJ19900@localhost> (raw)

On Thu, Nov 15, 2018 at 10:58:44AM +0800, Ji-Ze Hong (Peter Hong) wrote:
> The F81532/534 had a internal configuration space to save & control
> IC state with address F81534_CUSTOM_ADDRESS_START (0x2f00). Layout
> as following:
> 	+00h: to indicate the section is valid
> 	+01h~04h: UART Mode & port availability
> 	+05h~08h: Output pin control on IC power on
> 	+09h~12h: Output pin control on working <-- New added
> 
> Old driver will use +05~08h as default on working, but newer IC will
> configed with shutdown mode(7) in 05h~08h and working mode with RS232(1)
> in 09h~12h. It'll make mainstream driver not working.
> 
> This patch will make mainstream driver compatible older and newer IC.
> If using a old IC, the +05h~08h will be 00h~06h, we'll direct apply it.
> If using a new IC, the +05h~08h will be 07h or larger, we'll read +09h~12h
> to apply newer configuration.
> 
> Signed-off-by: Ji-Ze Hong (Peter Hong) <hpeter+linux_kernel@gmail.com>

Applied for -next. I guess you can ask Greg if he's willing to take this
into stable once 4.21-rc1 is out (as it is enabling support for a new
class of devices).

Thanks,
Johan

  reply	other threads:[~2018-11-20 17:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-15  2:58 [PATCH V1 1/1] USB: serial: f81534: fix reading old/new IC config Ji-Ze Hong (Peter Hong)
2018-11-15  2:58 ` [V1,1/1] " Ji-Ze Hong (Peter Hong)
2018-11-20 17:29 ` Johan Hovold [this message]
2018-11-20 17:29   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20181120172943.GJ19900@localhost \
    --to=johan@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hpeter+linux_kernel@gmail.com \
    --cc=hpeter@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=peter_hong@fintek.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.