All of lore.kernel.org
 help / color / mirror / Atom feed
* [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case
@ 2018-11-28 13:03 Stanislav Lisovskiy
  2018-11-28 13:56 ` Maarten Lankhorst
                   ` (3 more replies)
  0 siblings, 4 replies; 6+ messages in thread
From: Stanislav Lisovskiy @ 2018-11-28 13:03 UTC (permalink / raw)
  To: igt-dev; +Cc: stanislav.lisovskiy, ville.syrjala, martin.peres

Otherwise we are getting EINVAL as drm requires it
at some point.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108642
Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
---
 tests/kms_properties.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/kms_properties.c b/tests/kms_properties.c
index 82d28e9b..eb9cbdda 100644
--- a/tests/kms_properties.c
+++ b/tests/kms_properties.c
@@ -100,7 +100,7 @@ static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropert
 			ret = drmModeAtomicAddProperty(req, id, prop_id, i);
 			igt_assert(ret >= 0);
 
-			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
+			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
 			igt_assert_eq(ret, 0);
 		}
 	}
-- 
2.17.1

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case
  2018-11-28 13:03 [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case Stanislav Lisovskiy
@ 2018-11-28 13:56 ` Maarten Lankhorst
  2018-12-07 16:11   ` James Ausmus
  2018-11-28 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 6+ messages in thread
From: Maarten Lankhorst @ 2018-11-28 13:56 UTC (permalink / raw)
  To: Stanislav Lisovskiy, igt-dev; +Cc: ville.syrjala, martin.peres

Op 28-11-18 om 14:03 schreef Stanislav Lisovskiy:
> Otherwise we are getting EINVAL as drm requires it
> at some point.
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108642
> Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> ---
>  tests/kms_properties.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> index 82d28e9b..eb9cbdda 100644
> --- a/tests/kms_properties.c
> +++ b/tests/kms_properties.c
> @@ -100,7 +100,7 @@ static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropert
>  			ret = drmModeAtomicAddProperty(req, id, prop_id, i);
>  			igt_assert(ret >= 0);
>  
> -			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> +			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
>  			igt_assert_eq(ret, 0);
>  		}
>  	}

Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

Lets wait for CI results before committing it. :)

_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Allow a full modeset in kms_properties atomic case
  2018-11-28 13:03 [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case Stanislav Lisovskiy
  2018-11-28 13:56 ` Maarten Lankhorst
@ 2018-11-28 13:57 ` Patchwork
  2018-12-06 11:17 ` [igt-dev] ✓ Fi.CI.BAT: success for Allow a full modeset in kms_properties atomic case (rev2) Patchwork
  2018-12-07  5:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-11-28 13:57 UTC (permalink / raw)
  To: Stanislav Lisovskiy; +Cc: igt-dev

== Series Details ==

Series: Allow a full modeset in kms_properties atomic case
URL   : https://patchwork.freedesktop.org/series/53157/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5213 -> IGTPW_2103
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53157/revisions/1/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2103 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@i915_selftest@live_objects:
    - fi-cfl-8109u:       PASS -> INCOMPLETE [fdo#108474]

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-a:
    - fi-cfl-8109u:       PASS -> DMESG-WARN [fdo#106107] / [k.org#200587]

  
#### Possible fixes ####

  * igt@gem_basic@create-fd-close:
    - fi-kbl-7560u:       INCOMPLETE -> PASS

  * igt@gem_ctx_create@basic-files:
    - fi-bsw-n3050:       FAIL [fdo#108656] -> PASS

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-ivb-3520m:       FAIL [fdo#108880] -> PASS

  * igt@kms_frontbuffer_tracking@basic:
    - fi-byt-clapper:     FAIL [fdo#103167] -> PASS

  * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence:
    - fi-byt-clapper:     FAIL [fdo#103191] / [fdo#107362] -> PASS

  * igt@kms_pipe_crc_basic@suspend-read-crc-pipe-b:
    - fi-blb-e6850:       INCOMPLETE [fdo#107718] -> PASS

  * igt@prime_vgem@basic-fence-flip:
    - fi-gdg-551:         FAIL [fdo#103182] -> PASS

  
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103182]: https://bugs.freedesktop.org/show_bug.cgi?id=103182
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
  [fdo#107362]: https://bugs.freedesktop.org/show_bug.cgi?id=107362
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108474]: https://bugs.freedesktop.org/show_bug.cgi?id=108474
  [fdo#108656]: https://bugs.freedesktop.org/show_bug.cgi?id=108656
  [fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880
  [k.org#200587]: https://bugzilla.kernel.org/show_bug.cgi?id=200587


Participating hosts (51 -> 44)
------------------------------

  Missing    (7): fi-kbl-soraka fi-kbl-7567u fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 


Build changes
-------------

    * IGT: IGT_4735 -> IGTPW_2103

  CI_DRM_5213: 5912c54d9804fb15d6a9fa2798bfef1e837c8938 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2103: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2103/
  IGT_4735: b05c028ccdb6ac8e8d8499a041bb14dfe358ee26 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2103/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.BAT: success for Allow a full modeset in kms_properties atomic case (rev2)
  2018-11-28 13:03 [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case Stanislav Lisovskiy
  2018-11-28 13:56 ` Maarten Lankhorst
  2018-11-28 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
@ 2018-12-06 11:17 ` Patchwork
  2018-12-07  5:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-12-06 11:17 UTC (permalink / raw)
  To: Stanislav Lisovskiy; +Cc: igt-dev

== Series Details ==

Series: Allow a full modeset in kms_properties atomic case (rev2)
URL   : https://patchwork.freedesktop.org/series/53157/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5274 -> IGTPW_2126
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53157/revisions/2/mbox/

Known issues
------------

  Here are the changes found in IGTPW_2126 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s3:
    - fi-blb-e6850:       PASS -> INCOMPLETE [fdo#107718]

  * igt@gem_exec_suspend@basic-s4-devices:
    - fi-ivb-3520m:       NOTRUN -> FAIL [fdo#108880]

  * igt@i915_selftest@live_contexts:
    - {fi-icl-u3}:        NOTRUN -> DMESG-FAIL [fdo#108569]

  * igt@i915_selftest@live_hangcheck:
    - fi-kbl-7560u:       PASS -> INCOMPLETE [fdo#108044]

  * igt@i915_selftest@live_workarounds:
    - {fi-icl-u3}:        NOTRUN -> DMESG-FAIL [fdo#108954]

  * igt@kms_chamelium@common-hpd-after-suspend:
    - {fi-kbl-7567u}:     NOTRUN -> DMESG-WARN [fdo#108473]

  * igt@kms_chamelium@dp-crc-fast:
    - {fi-kbl-7500u}:     NOTRUN -> FAIL [fdo#103841] +8

  * igt@kms_frontbuffer_tracking@basic:
    - {fi-icl-u3}:        NOTRUN -> FAIL [fdo#103167]

  * {igt@runner@aborted}:
    - {fi-icl-y}:         NOTRUN -> FAIL [fdo#108070]

  
#### Possible fixes ####

  * igt@i915_selftest@live_execlists:
    - fi-apl-guc:         INCOMPLETE [fdo#103927] / [fdo#108622] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103841]: https://bugs.freedesktop.org/show_bug.cgi?id=103841
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
  [fdo#108044]: https://bugs.freedesktop.org/show_bug.cgi?id=108044
  [fdo#108070]: https://bugs.freedesktop.org/show_bug.cgi?id=108070
  [fdo#108473]: https://bugs.freedesktop.org/show_bug.cgi?id=108473
  [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
  [fdo#108622]: https://bugs.freedesktop.org/show_bug.cgi?id=108622
  [fdo#108880]: https://bugs.freedesktop.org/show_bug.cgi?id=108880
  [fdo#108954]: https://bugs.freedesktop.org/show_bug.cgi?id=108954


Participating hosts (26 -> 45)
------------------------------

  Additional (21): fi-skl-6770hq fi-bdw-gvtdvm fi-skl-6260u fi-icl-u3 fi-icl-y fi-skl-6600u fi-snb-2600 fi-hsw-4770r fi-bdw-5557u fi-glk-dsi fi-kbl-7500u fi-ivb-3520m fi-kbl-r fi-kbl-7567u fi-skl-guc fi-cfl-8700k fi-glk-j4005 fi-cfl-guc fi-kbl-guc fi-cfl-8109u fi-skl-iommu 
  Missing    (2): fi-byt-squawks fi-bsw-cyan 


Build changes
-------------

    * IGT: IGT_4743 -> IGTPW_2126

  CI_DRM_5274: 3117375b77ec896e358afaff7c307bfad01d0de7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2126: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2126/
  IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2126/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [igt-dev] ✓ Fi.CI.IGT: success for Allow a full modeset in kms_properties atomic case (rev2)
  2018-11-28 13:03 [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case Stanislav Lisovskiy
                   ` (2 preceding siblings ...)
  2018-12-06 11:17 ` [igt-dev] ✓ Fi.CI.BAT: success for Allow a full modeset in kms_properties atomic case (rev2) Patchwork
@ 2018-12-07  5:17 ` Patchwork
  3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2018-12-07  5:17 UTC (permalink / raw)
  To: Stanislav Lisovskiy; +Cc: igt-dev

== Series Details ==

Series: Allow a full modeset in kms_properties atomic case (rev2)
URL   : https://patchwork.freedesktop.org/series/53157/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_5274_full -> IGTPW_2126_full
====================================================

Summary
-------

  **WARNING**

  Minor unknown changes coming with IGTPW_2126_full need to be verified
  manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in IGTPW_2126_full, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://patchwork.freedesktop.org/api/1.0/series/53157/revisions/2/mbox/

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in IGTPW_2126_full:

### IGT changes ###

#### Warnings ####

  * igt@pm_rc6_residency@rc6-accuracy:
    - shard-snb:          SKIP -> PASS

  
Known issues
------------

  Here are the changes found in IGTPW_2126_full that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_fence@basic-await-default:
    - shard-hsw:          PASS -> FAIL [fdo#108888]

  * igt@kms_cursor_crc@cursor-128x128-suspend:
    - shard-glk:          PASS -> FAIL [fdo#103232] +2
    - shard-apl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_cursor_crc@cursor-64x21-random:
    - shard-apl:          PASS -> FAIL [fdo#103232] +3

  * igt@kms_cursor_crc@cursor-64x64-suspend:
    - shard-apl:          PASS -> DMESG-FAIL [fdo#103232]
    - shard-kbl:          PASS -> FAIL [fdo#103191] / [fdo#103232]

  * igt@kms_flip@flip-vs-expired-vblank-interruptible:
    - shard-apl:          PASS -> FAIL [fdo#102887] / [fdo#105363]
    - shard-glk:          PASS -> FAIL [fdo#102887] / [fdo#105363]

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-render:
    - shard-apl:          PASS -> FAIL [fdo#103167] +3

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
    - shard-glk:          PASS -> FAIL [fdo#103167] +3
    - shard-kbl:          PASS -> FAIL [fdo#103167]

  * igt@kms_plane@plane-panning-bottom-right-suspend-pipe-c-planes:
    - shard-kbl:          PASS -> INCOMPLETE [fdo#103665]

  * igt@kms_plane@plane-position-covered-pipe-a-planes:
    - shard-glk:          PASS -> FAIL [fdo#103166] +2

  * igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb:
    - shard-apl:          PASS -> FAIL [fdo#108145]

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-glk:          PASS -> FAIL [fdo#108145]

  * igt@kms_plane_multiple@atomic-pipe-a-tiling-x:
    - shard-apl:          PASS -> FAIL [fdo#103166] +3

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-x:
    - shard-kbl:          PASS -> FAIL [fdo#103166]

  * igt@prime_vgem@sync-bsd2:
    - shard-snb:          SKIP -> INCOMPLETE [fdo#105411]

  * igt@sw_sync@sync_busy_fork_unixsocket:
    - shard-glk:          PASS -> INCOMPLETE [fdo#103359] / [k.org#198133]

  
#### Possible fixes ####

  * igt@kms_available_modes_crc@available_mode_test_crc:
    - shard-apl:          FAIL [fdo#106641] -> PASS

  * igt@kms_color@pipe-c-legacy-gamma:
    - shard-apl:          FAIL [fdo#104782] -> PASS

  * igt@kms_cursor_crc@cursor-128x128-sliding:
    - shard-apl:          FAIL [fdo#103232] -> PASS +1

  * igt@kms_cursor_crc@cursor-128x42-sliding:
    - shard-kbl:          FAIL [fdo#103232] -> PASS

  * igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
    - shard-apl:          FAIL [fdo#103167] -> PASS +1
    - shard-glk:          FAIL [fdo#103167] -> PASS
    - shard-kbl:          FAIL [fdo#103167] -> PASS

  * {igt@kms_plane@pixel-format-pipe-b-planes-source-clamping}:
    - shard-apl:          FAIL [fdo#108948] -> PASS

  * igt@kms_plane_alpha_blend@pipe-a-constant-alpha-max:
    - shard-glk:          FAIL [fdo#108145] -> PASS
    - shard-kbl:          FAIL [fdo#108145] -> PASS

  * igt@kms_plane_alpha_blend@pipe-b-constant-alpha-max:
    - shard-apl:          FAIL [fdo#108145] -> PASS +1

  * igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
    - shard-glk:          FAIL [fdo#103166] -> PASS +1
    - shard-kbl:          FAIL [fdo#103166] -> PASS

  * igt@kms_plane_multiple@atomic-pipe-c-tiling-yf:
    - shard-apl:          FAIL [fdo#103166] -> PASS +3

  * igt@kms_properties@connector-properties-atomic:
    - shard-apl:          FAIL [fdo#108642] -> PASS
    - shard-glk:          FAIL [fdo#108642] -> PASS
    - shard-hsw:          FAIL [fdo#108642] -> PASS
    - shard-kbl:          FAIL [fdo#108642] -> PASS

  * {igt@kms_rotation_crc@multiplane-rotation-cropping-top}:
    - shard-glk:          DMESG-FAIL [fdo#105763] / [fdo#106538] -> PASS

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#102887]: https://bugs.freedesktop.org/show_bug.cgi?id=102887
  [fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
  [fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
  [fdo#103191]: https://bugs.freedesktop.org/show_bug.cgi?id=103191
  [fdo#103232]: https://bugs.freedesktop.org/show_bug.cgi?id=103232
  [fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
  [fdo#103665]: https://bugs.freedesktop.org/show_bug.cgi?id=103665
  [fdo#104782]: https://bugs.freedesktop.org/show_bug.cgi?id=104782
  [fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
  [fdo#105411]: https://bugs.freedesktop.org/show_bug.cgi?id=105411
  [fdo#105763]: https://bugs.freedesktop.org/show_bug.cgi?id=105763
  [fdo#106538]: https://bugs.freedesktop.org/show_bug.cgi?id=106538
  [fdo#106641]: https://bugs.freedesktop.org/show_bug.cgi?id=106641
  [fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
  [fdo#108642]: https://bugs.freedesktop.org/show_bug.cgi?id=108642
  [fdo#108888]: https://bugs.freedesktop.org/show_bug.cgi?id=108888
  [fdo#108948]: https://bugs.freedesktop.org/show_bug.cgi?id=108948
  [k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133


Participating hosts (7 -> 5)
------------------------------

  Missing    (2): shard-skl shard-iclb 


Build changes
-------------

    * IGT: IGT_4743 -> IGTPW_2126
    * Piglit: piglit_4509 -> None

  CI_DRM_5274: 3117375b77ec896e358afaff7c307bfad01d0de7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGTPW_2126: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2126/
  IGT_4743: edb2db2cf2b6665d7ba3fa9117263302f6307a4f @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_2126/
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case
  2018-11-28 13:56 ` Maarten Lankhorst
@ 2018-12-07 16:11   ` James Ausmus
  0 siblings, 0 replies; 6+ messages in thread
From: James Ausmus @ 2018-12-07 16:11 UTC (permalink / raw)
  To: Maarten Lankhorst
  Cc: Stanislav Lisovskiy, igt-dev, ville.syrjala, martin.peres

On Wed, Nov 28, 2018 at 02:56:03PM +0100, Maarten Lankhorst wrote:
> Op 28-11-18 om 14:03 schreef Stanislav Lisovskiy:
> > Otherwise we are getting EINVAL as drm requires it
> > at some point.
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108642
> > Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
> > ---
> >  tests/kms_properties.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/kms_properties.c b/tests/kms_properties.c
> > index 82d28e9b..eb9cbdda 100644
> > --- a/tests/kms_properties.c
> > +++ b/tests/kms_properties.c
> > @@ -100,7 +100,7 @@ static void max_bpc_prop_test(int fd, uint32_t id, uint32_t type, drmModePropert
> >  			ret = drmModeAtomicAddProperty(req, id, prop_id, i);
> >  			igt_assert(ret >= 0);
> >  
> > -			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY, NULL);
> > +			ret = drmModeAtomicCommit(fd, req, DRM_MODE_ATOMIC_TEST_ONLY | DRM_MODE_ATOMIC_ALLOW_MODESET, NULL);
> >  			igt_assert_eq(ret, 0);
> >  		}
> >  	}
> 
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> 
> Lets wait for CI results before committing it. :)

Can this get merged now, or is it still waiting for something
additional?

Thanks!

-James

> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2018-12-07 16:10 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-28 13:03 [igt-dev] [PATCH i-g-t] Allow a full modeset in kms_properties atomic case Stanislav Lisovskiy
2018-11-28 13:56 ` Maarten Lankhorst
2018-12-07 16:11   ` James Ausmus
2018-11-28 13:57 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-12-06 11:17 ` [igt-dev] ✓ Fi.CI.BAT: success for Allow a full modeset in kms_properties atomic case (rev2) Patchwork
2018-12-07  5:17 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.