From: Bjorn Helgaas <helgaas@kernel.org>
To: Thinh Nguyen <thinh.nguyen@synopsys.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
USB <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver
Date: Mon, 10 Dec 2018 12:54:33 -0600 [thread overview]
Message-ID: <20181210185433.GB47246@google.com> (raw)
In-Reply-To: <30102591E157244384E984126FC3CB4F639A8945@us01wembx1.internal.synopsys.com>
On Sat, Dec 08, 2018 at 02:49:09AM +0000, Thinh Nguyen wrote:
> Hi Bjorn,
>
> On 11/6/2018 12:44 AM, Felipe Balbi wrote:
> > Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
> >
> >> ++ linux-usb
> >> ++ Greg
> >>
> >> On 11/2/2018 6:47 PM, Thinh Nguyen wrote:
> >>> Synopsys USB 3.x host HAPS platform has a class code of
> >>> PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these
> >>> devices should use dwc3-haps driver. Set driver_override to dwc3-haps
> >>> for these platforms.
> >>>
> >>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> > FWIW:
> >
> > Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> >
>
> Please let me know if you're ok with these 2 patches. (This and patch
> subject "[PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs")
1) Run "git log --oneline drivers/pci/quirks.c" ...
2) quirk_amd_nl_class() and quirk_netmos() do something similar in a
different way. quirk_amd_nl_class() in particular seems to be doing
exactly the same thing. I think since they're doing the same thing, they
should do it the same way. Would the quirk_amd_nl_class() solution work
for you?
Bjorn
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Helgaas <helgaas@kernel.org>
To: Thinh Nguyen <thinh.nguyen@synopsys.com>
Cc: Felipe Balbi <felipe.balbi@linux.intel.com>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
USB <linux-usb@vger.kernel.org>
Subject: [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs
Date: Mon, 10 Dec 2018 12:54:33 -0600 [thread overview]
Message-ID: <20181210185433.GB47246@google.com> (raw)
On Sat, Dec 08, 2018 at 02:49:09AM +0000, Thinh Nguyen wrote:
> Hi Bjorn,
>
> On 11/6/2018 12:44 AM, Felipe Balbi wrote:
> > Thinh Nguyen <thinh.nguyen@synopsys.com> writes:
> >
> >> ++ linux-usb
> >> ++ Greg
> >>
> >> On 11/2/2018 6:47 PM, Thinh Nguyen wrote:
> >>> Synopsys USB 3.x host HAPS platform has a class code of
> >>> PCI_CLASS_SERIAL_USB_XHCI, and xhci driver can claim it. However, these
> >>> devices should use dwc3-haps driver. Set driver_override to dwc3-haps
> >>> for these platforms.
> >>>
> >>> Signed-off-by: Thinh Nguyen <thinhn@synopsys.com>
> > FWIW:
> >
> > Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com>
> >
>
> Please let me know if you're ok with these 2 patches. (This and patch
> subject "[PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs")
1) Run "git log --oneline drivers/pci/quirks.c" ...
2) quirk_amd_nl_class() and quirk_netmos() do something similar in a
different way. quirk_amd_nl_class() in particular seems to be doing
exactly the same thing. I think since they're doing the same thing, they
should do it the same way. Would the quirk_amd_nl_class() solution work
for you?
Bjorn
next prev parent reply other threads:[~2018-12-10 18:54 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-03 1:47 [PATCH 1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-03 1:47 ` [1/2] " Thinh Nguyen
2018-11-03 1:47 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-11-05 18:49 ` Thinh Nguyen
2018-11-05 18:49 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-06 8:43 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Felipe Balbi
2018-11-06 8:43 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Felipe Balbi
2018-12-08 2:49 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-12-08 2:49 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-12-10 18:54 ` Bjorn Helgaas [this message]
2018-12-10 18:54 ` Bjorn Helgaas
2018-12-10 21:51 ` [PATCH 2/2] pci: quirks: Override Synopsys USB 3.x HAPS device driver Thinh Nguyen
2018-12-10 21:51 ` [1/2] pci: pci_ids: Move Synopsys HAPS platform device IDs Thinh Nguyen
2018-11-03 6:25 ` [PATCH 1/2] " Greg KH
2018-11-03 6:25 ` [1/2] " Greg Kroah-Hartman
2018-11-05 18:46 ` [PATCH 1/2] " Thinh Nguyen
2018-11-05 18:46 ` [1/2] " Thinh Nguyen
2018-11-05 18:56 ` [PATCH 1/2] " Greg KH
2018-11-05 18:56 ` [1/2] " Greg Kroah-Hartman
2018-12-10 18:49 ` [PATCH 1/2] " Bjorn Helgaas
2018-12-10 18:49 ` [1/2] " Bjorn Helgaas
2018-12-10 21:49 ` [PATCH 1/2] " Thinh Nguyen
2018-12-10 21:49 ` [1/2] " Thinh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181210185433.GB47246@google.com \
--to=helgaas@kernel.org \
--cc=felipe.balbi@linux.intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=thinh.nguyen@synopsys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.