[Buildroot] [PATCH] netsurf: fix build error

[Buildroot] [PATCH] netsurf: fix build error

[Francois Perrad]

the previous commit allows to build host-libpng

now, this library is found when compiling the host tool convert_image

see http://autobuild.buildroot.net/results/d0b/d0bbd563fe5c9463316b2ba0d7ef5553be0563bc/

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/netsurf/netsurf.mk | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
index 3339b35c9..1671944e9 100644
--- a/package/netsurf/netsurf.mk
+++ b/package/netsurf/netsurf.mk
@@ -27,6 +27,7 @@ endif
 ifeq ($(BR2_PACKAGE_NETSURF_SDL),y)
 NETSURF_DEPENDENCIES += sdl host-libpng
 NETSURF_FRONTEND = framebuffer
+NETSURF_CONFIG="HOST_CFLAGS=-I$(HOST_DIR)/include HOST_LDFLAGS='-lpng -L$(HOST_DIR)/lib'"
 endif
 
 ifeq ($(BR2_PACKAGE_LIBICONV),y)
@@ -52,6 +53,7 @@ NETSURF_MAKE_OPTS = \
 	CC="$(TARGET_CC)" \
 	AR="$(TARGET_AR)" \
 	TMP_PREFIX=$(STAGING_DIR)/usr \
+	NETSURF_CONFIG="$(NETSURF_CONFIG)" \
 	PREFIX=/usr
 
 define NETSURF_BUILD_CMDS
-- 
2.17.1

[Buildroot] [PATCH] netsurf: fix build error

[Andreas Naumann]

Hi Francois,

Am 11.12.18 um 16:02 schrieb Francois Perrad:
> add missing host dependency
> 
> see http://autobuild.buildroot.net/results/d0b/d0bbd563fe5c9463316b2ba0d7ef5553be0563bc/build-end.log

Unfortunately it didnt fix the issue for me. In an ARM build I get

[mmia5] 2018-12-12T14:09:53 TESTMENT: build/Linux-framebuffer/testament.h
[mmia5] 2018-12-12T14:09:53 HOST CC: 
build/Linux-framebuffer/tools/convert_image
[mmia5] 2018-12-12T14:09:53 HOST CC: 
build/Linux-framebuffer/tools/convert_font
[mmia5] 2018-12-12T14:09:53 COMPILE: content/content.c
[mmia5] 2018-12-12T14:09:53 COMPILE: content/content_factory.c
[mmia5] 2018-12-12T14:09:53 frontends/framebuffer/convert_image.c:22:10: 
fatal error: png.h: No such file or directory
[mmia5] 2018-12-12T14:09:53 #include <png.h>
[mmia5] 2018-12-12T14:09:53 ^~~~~~~
[mmia5] 2018-12-12T14:09:53 compilation terminated.
[mmia5] 2018-12-12T14:09:53 frontends/framebuffer/Makefile:97: recipe 
for target 'build/Linux-framebuffer/tools/convert_image' failed
[mmia5] 2018-12-12T14:09:53 make[3]: *** 
[build/Linux-framebuffer/tools/convert_image] Error 1


regards,
Andreas


> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>   package/netsurf/netsurf.mk | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
> index 162ac5d79..3339b35c9 100644
> --- a/package/netsurf/netsurf.mk
> +++ b/package/netsurf/netsurf.mk
> @@ -25,7 +25,7 @@ endif
>   endif
>   
>   ifeq ($(BR2_PACKAGE_NETSURF_SDL),y)
> -NETSURF_DEPENDENCIES += sdl
> +NETSURF_DEPENDENCIES += sdl host-libpng
>   NETSURF_FRONTEND = framebuffer
>   endif
>   
> 

[Buildroot] [PATCH] netsurf: fix build error

[Arnout Vandecappelle]

 Hi Francois,

On 11/12/2018 16:02, Francois Perrad wrote:
> add missing host dependency
> 
> see http://autobuild.buildroot.net/results/d0b/d0bbd563fe5c9463316b2ba0d7ef5553be0563bc/build-end.log
> 
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>

 Applied to master, thanks.

 I've rewritten the commit message as follows:

    package/netsurf: add dependency on host-libpng for sdl

    libpng is used by the convert_image host tool, which is built when SDL
    is enabled.

    Fixes:

http://autobuild.buildroot.net/results/d0b/d0bbd563fe5c9463316b2ba0d7ef5553be0563bc/

 The important bits are:

- package/netsurf instead of netsurf - we recently agreed on that formatting;

- the subject line should describe what is done, not just "fix an error"

- having "Fixes:" in the commit message makes sure that the F column in
patchwork is tagged, that's convenient for locating the more urgent patches.

 Regards,
 Arnout

> ---
>  package/netsurf/netsurf.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
> index 162ac5d79..3339b35c9 100644
> --- a/package/netsurf/netsurf.mk
> +++ b/package/netsurf/netsurf.mk
> @@ -25,7 +25,7 @@ endif
>  endif
>  
>  ifeq ($(BR2_PACKAGE_NETSURF_SDL),y)
> -NETSURF_DEPENDENCIES += sdl
> +NETSURF_DEPENDENCIES += sdl host-libpng
>  NETSURF_FRONTEND = framebuffer
>  endif
>  
> 

[Buildroot] [PATCH] netsurf: fix build error

[Francois Perrad]

add missing host dependency

see http://autobuild.buildroot.net/results/d0b/d0bbd563fe5c9463316b2ba0d7ef5553be0563bc/build-end.log

Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
---
 package/netsurf/netsurf.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/netsurf/netsurf.mk b/package/netsurf/netsurf.mk
index 162ac5d79..3339b35c9 100644
--- a/package/netsurf/netsurf.mk
+++ b/package/netsurf/netsurf.mk
@@ -25,7 +25,7 @@ endif
 endif
 
 ifeq ($(BR2_PACKAGE_NETSURF_SDL),y)
-NETSURF_DEPENDENCIES += sdl
+NETSURF_DEPENDENCIES += sdl host-libpng
 NETSURF_FRONTEND = framebuffer
 endif
 
-- 
2.17.1