* [LTP] [PATCH] Fix cgroup_lib.sh helper
@ 2019-01-11 16:10 Cristian Marussi
2019-01-14 12:42 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Cristian Marussi @ 2019-01-11 16:10 UTC (permalink / raw)
To: ltp
A typo compromised get_cgroup_mountpoint() effectiveness
leading to cgroup_regression test_5 systematic failure.
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
---
testcases/kernel/controllers/cgroup_lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/testcases/kernel/controllers/cgroup_lib.sh b/testcases/kernel/controllers/cgroup_lib.sh
index 8c19c6c3e..45ab51b87 100644
--- a/testcases/kernel/controllers/cgroup_lib.sh
+++ b/testcases/kernel/controllers/cgroup_lib.sh
@@ -16,7 +16,7 @@ get_cgroup_mountpoint()
[ $# -eq 0 ] && tst_brk TBROK "get_cgroup_mountpoint: subsystem not defined"
mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
- [ -z "$mountpoint" ] && return 1
+ [ -z "$mntpoint" ] && return 1
echo $mntpoint
return 0
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [LTP] [PATCH] Fix cgroup_lib.sh helper
2019-01-11 16:10 [LTP] [PATCH] Fix cgroup_lib.sh helper Cristian Marussi
@ 2019-01-14 12:42 ` Petr Vorel
2019-01-14 13:11 ` Cristian Marussi
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2019-01-14 12:42 UTC (permalink / raw)
To: ltp
Hi Cristian,
...
> mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
> - [ -z "$mountpoint" ] && return 1
> + [ -z "$mntpoint" ] && return 1
Thanks for fix, merged.
I'm sorry, that was introduced by me, while do some changes in your commit.
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
* [LTP] [PATCH] Fix cgroup_lib.sh helper
2019-01-14 12:42 ` Petr Vorel
@ 2019-01-14 13:11 ` Cristian Marussi
0 siblings, 0 replies; 3+ messages in thread
From: Cristian Marussi @ 2019-01-14 13:11 UTC (permalink / raw)
To: ltp
Hi
On 14/01/2019 12:42, Petr Vorel wrote:
> Hi Cristian,
>
> ...
>> mntpoint=$(grep cgroup /proc/mounts | grep -w $subsystem | awk '{ print $2 }')
>> - [ -z "$mountpoint" ] && return 1
>> + [ -z "$mntpoint" ] && return 1
> Thanks for fix, merged.
>
> I'm sorry, that was introduced by me, while do some changes in your commit.
No problem.
>
>
> Kind regards,
> Petr
>
Thanks
Regards
Cristian
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 13:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-11 16:10 [LTP] [PATCH] Fix cgroup_lib.sh helper Cristian Marussi
2019-01-14 12:42 ` Petr Vorel
2019-01-14 13:11 ` Cristian Marussi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.