All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] neighbour: Do not perturb drop profiles when neigh_probe
@ 2019-01-17 15:11 Yang Wei
  2019-01-18  6:08 ` David Miller
  0 siblings, 1 reply; 2+ messages in thread
From: Yang Wei @ 2019-01-17 15:11 UTC (permalink / raw)
  To: netdev; +Cc: davem, yang.wei9

From: Yang Wei <yang.wei9@zte.com.cn>

Replace the kfree_skb() by consume_skb() to be drop monitor(dropwatch,
perf) friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
---
 net/core/neighbour.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 763a7b0..9177f04 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -1002,7 +1002,7 @@ static void neigh_probe(struct neighbour *neigh)
 	if (neigh->ops->solicit)
 		neigh->ops->solicit(neigh, skb);
 	atomic_inc(&neigh->probes);
-	kfree_skb(skb);
+	consume_skb(skb);
 }
 
 /* Called when a timer expires for a neighbour entry. */
-- 
2.7.4



^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] neighbour: Do not perturb drop profiles when neigh_probe
  2019-01-17 15:11 [PATCH] neighbour: Do not perturb drop profiles when neigh_probe Yang Wei
@ 2019-01-18  6:08 ` David Miller
  0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-01-18  6:08 UTC (permalink / raw)
  To: albin_yang; +Cc: netdev, yang.wei9

From: Yang Wei <albin_yang@163.com>
Date: Thu, 17 Jan 2019 23:11:30 +0800

> From: Yang Wei <yang.wei9@zte.com.cn>
> 
> Replace the kfree_skb() by consume_skb() to be drop monitor(dropwatch,
> perf) friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-01-18  6:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 15:11 [PATCH] neighbour: Do not perturb drop profiles when neigh_probe Yang Wei
2019-01-18  6:08 ` David Miller

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.