From: Lee Jones <lee.jones@linaro.org> To: Pi-Hsun Shih <pihsun@chromium.org> Cc: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>, Rob Herring <robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Mark Brown <broonie@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Liam Girdwood <lgirdwood@gmail.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@lists.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, open list <linux-kernel@vger.kernel.org>, srv_heupstream@mediatek.com Subject: Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC Date: Thu, 31 Jan 2019 10:01:53 +0000 [thread overview] Message-ID: <20190131100153.GJ4701@dell> (raw) In-Reply-To: <CANdKZ0csqmTFj7+03yRAM25z4jGEQYQvOuSWggDY81spGqhgfA@mail.gmail.com> On Thu, 31 Jan 2019, Pi-Hsun Shih wrote: > On Wed, Jan 30, 2019 at 5:19 PM Hsin-Hsiung Wang > <hsin-hsiung.wang@mediatek.com> wrote: > > > > This adds support for the MediaTek MT6358 PMIC. This is a > > multifunction device with the following sub modules: > > > > - Regulator > > - RTC > > - Codec > > - Interrupt > > > > It is interfaced to the host controller using SPI interface > > by a proprietary hardware called PMIC wrapper or pwrap. > > MT6358 MFD is a child device of the pwrap. > > > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> > > --- > > drivers/mfd/Makefile | 2 +- > > drivers/mfd/mt6358-irq.c | 236 +++++ > > drivers/mfd/mt6397-core.c | 62 +- > > include/linux/mfd/mt6358/core.h | 158 +++ > > include/linux/mfd/mt6358/registers.h | 1926 ++++++++++++++++++++++++++++++++++ > > include/linux/mfd/mt6397/core.h | 3 + > > 6 files changed, 2385 insertions(+), 2 deletions(-) > > create mode 100644 drivers/mfd/mt6358-irq.c > > create mode 100644 include/linux/mfd/mt6358/core.h > > create mode 100644 include/linux/mfd/mt6358/registers.h [100's (hundreds) of lines of code cut] > > +static const struct mfd_cell mt6358_devs[] = { > > + { > > + .name = "mt6358-regulator", > > + .of_compatible = "mediatek,mt6358-regulator" > > + }, { > > + .name = "mt6397-rtc", > > Should this be "mt6358-rtc"? [1000's (thousands) of lines of code cut] When replying to a patch, especially one as large as this, you should cut all of the irrelevant quotes. Put another way, you should only quote what you are replying to, and maybe a small section before/after to keep the context. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org> To: Pi-Hsun Shih <pihsun@chromium.org> Cc: Mark Rutland <mark.rutland@arm.com>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, srv_heupstream@mediatek.com, Liam Girdwood <lgirdwood@gmail.com>, Rob Herring <robh+dt@kernel.org>, open list <linux-kernel@vger.kernel.org>, Mark Brown <broonie@kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@lists.infradead.org>, Matthias Brugger <matthias.bgg@gmail.com>, Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> Subject: Re: [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC Date: Thu, 31 Jan 2019 10:01:53 +0000 [thread overview] Message-ID: <20190131100153.GJ4701@dell> (raw) In-Reply-To: <CANdKZ0csqmTFj7+03yRAM25z4jGEQYQvOuSWggDY81spGqhgfA@mail.gmail.com> On Thu, 31 Jan 2019, Pi-Hsun Shih wrote: > On Wed, Jan 30, 2019 at 5:19 PM Hsin-Hsiung Wang > <hsin-hsiung.wang@mediatek.com> wrote: > > > > This adds support for the MediaTek MT6358 PMIC. This is a > > multifunction device with the following sub modules: > > > > - Regulator > > - RTC > > - Codec > > - Interrupt > > > > It is interfaced to the host controller using SPI interface > > by a proprietary hardware called PMIC wrapper or pwrap. > > MT6358 MFD is a child device of the pwrap. > > > > Signed-off-by: Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com> > > --- > > drivers/mfd/Makefile | 2 +- > > drivers/mfd/mt6358-irq.c | 236 +++++ > > drivers/mfd/mt6397-core.c | 62 +- > > include/linux/mfd/mt6358/core.h | 158 +++ > > include/linux/mfd/mt6358/registers.h | 1926 ++++++++++++++++++++++++++++++++++ > > include/linux/mfd/mt6397/core.h | 3 + > > 6 files changed, 2385 insertions(+), 2 deletions(-) > > create mode 100644 drivers/mfd/mt6358-irq.c > > create mode 100644 include/linux/mfd/mt6358/core.h > > create mode 100644 include/linux/mfd/mt6358/registers.h [100's (hundreds) of lines of code cut] > > +static const struct mfd_cell mt6358_devs[] = { > > + { > > + .name = "mt6358-regulator", > > + .of_compatible = "mediatek,mt6358-regulator" > > + }, { > > + .name = "mt6397-rtc", > > Should this be "mt6358-rtc"? [1000's (thousands) of lines of code cut] When replying to a patch, especially one as large as this, you should cut all of the irrelevant quotes. Put another way, you should only quote what you are replying to, and maybe a small section before/after to keep the context. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-01-31 10:02 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-01-30 9:18 [PATCH 0/6] Add Support for MediaTek PMIC MT6358 MFD Core and Regulator Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 9:18 ` [PATCH 1/6] mfd: mt6397: extract irq related code from core driver Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-02-07 9:08 ` Lee Jones 2019-02-07 9:08 ` Lee Jones 2019-01-30 9:18 ` [PATCH 2/6] dt-bindings: mfd: Add compatible for the MediaTek MT6358 PMIC Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-02-25 14:54 ` Rob Herring 2019-02-25 14:54 ` Rob Herring 2019-02-25 14:54 ` Rob Herring 2019-01-30 9:18 ` [PATCH 3/6] regulator: Add document for MT6358 regulator Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-02-25 16:03 ` Rob Herring 2019-02-25 16:03 ` Rob Herring 2019-02-25 16:03 ` Rob Herring 2019-01-30 9:18 ` [PATCH 4/6] mfd: Add support for the MediaTek MT6358 PMIC Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-31 3:56 ` Pi-Hsun Shih 2019-01-31 3:56 ` Pi-Hsun Shih 2019-01-31 8:33 ` Hsin-hsiung Wang 2019-01-31 8:33 ` Hsin-hsiung Wang 2019-01-31 8:33 ` Hsin-hsiung Wang 2019-01-31 10:01 ` Lee Jones [this message] 2019-01-31 10:01 ` Lee Jones 2019-01-31 10:01 ` Lee Jones 2019-02-07 9:34 ` Lee Jones 2019-02-07 9:34 ` Lee Jones 2019-02-07 10:04 ` Marc Zyngier 2019-02-07 10:04 ` Marc Zyngier 2019-02-07 12:03 ` Mark Brown 2019-02-07 12:03 ` Mark Brown 2019-02-08 20:09 ` Matthias Kaehlcke 2019-02-08 20:09 ` Matthias Kaehlcke 2019-01-30 9:18 ` [PATCH 5/6] regulator: mt6358: Add support for MT6358 regulator Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 15:18 ` Mark Brown 2019-01-30 15:18 ` Mark Brown 2019-02-01 2:13 ` Hsin-hsiung Wang 2019-02-01 2:13 ` Hsin-hsiung Wang 2019-02-01 2:13 ` Hsin-hsiung Wang 2019-01-30 9:18 ` [PATCH 6/6] arm64: dts: mt6358: add PMIC MT6358 related nodes Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang 2019-01-30 9:18 ` Hsin-Hsiung Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190131100153.GJ4701@dell \ --to=lee.jones@linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=hsin-hsiung.wang@mediatek.com \ --cc=lgirdwood@gmail.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=mark.rutland@arm.com \ --cc=matthias.bgg@gmail.com \ --cc=pihsun@chromium.org \ --cc=robh+dt@kernel.org \ --cc=srv_heupstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.