From: Florian Fainelli <f.fainelli@gmail.com> To: netdev@vger.kernel.org Cc: Florian Fainelli <f.fainelli@gmail.com>, "David S. Miller" <davem@davemloft.net>, Ido Schimmel <idosch@mellanox.com>, linux-kernel@vger.kernel.org (open list), devel@driverdev.osuosl.org (open list:STAGING SUBSYSTEM), bridge@lists.linux-foundation.org (moderated list:ETHERNET BRIDGE), jiri@mellanox.com, andrew@lunn.ch, vivien.didelot@gmail.com Subject: [PATCH net-next v4 1/9] Documentation: networking: switchdev: Update port parent ID section Date: Mon, 11 Feb 2019 11:09:53 -0800 [thread overview] Message-ID: <20190211191001.8623-2-f.fainelli@gmail.com> (raw) In-Reply-To: <20190211191001.8623-1-f.fainelli@gmail.com> Update the section about switchdev drivers having to implement a switchdev_port_attr_get() function to return SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after commit bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID"). Fixes: bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID") Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Documentation/networking/switchdev.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index f3244d87512a..ea90243340a9 100644 --- a/Documentation/networking/switchdev.txt +++ b/Documentation/networking/switchdev.txt @@ -92,11 +92,11 @@ device. Switch ID ^^^^^^^^^ -The switchdev driver must implement the switchdev op switchdev_port_attr_get -for SWITCHDEV_ATTR_ID_PORT_PARENT_ID for each port netdev, returning the same -physical ID for each port of a switch. The ID must be unique between switches -on the same system. The ID does not need to be unique between switches on -different systems. +The switchdev driver must implement the net_device operation +ndo_get_port_parent_id for each port netdev, returning the same physical ID for +each port of a switch. The ID must be unique between switches on the same +system. The ID does not need to be unique between switches on different +systems. The switch ID is used to locate ports on a switch and to know if aggregated ports belong to the same switch. -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com> To: netdev@vger.kernel.org Cc: "open list:STAGING SUBSYSTEM" <devel@driverdev.osuosl.org>, andrew@lunn.ch, Florian Fainelli <f.fainelli@gmail.com>, "moderated list:ETHERNET BRIDGE" <bridge@lists.linux-foundation.org>, open list <linux-kernel@vger.kernel.org>, vivien.didelot@gmail.com, Ido Schimmel <idosch@mellanox.com>, jiri@mellanox.com, "David S. Miller" <davem@davemloft.net> Subject: [Bridge] [PATCH net-next v4 1/9] Documentation: networking: switchdev: Update port parent ID section Date: Mon, 11 Feb 2019 11:09:53 -0800 [thread overview] Message-ID: <20190211191001.8623-2-f.fainelli@gmail.com> (raw) In-Reply-To: <20190211191001.8623-1-f.fainelli@gmail.com> Update the section about switchdev drivers having to implement a switchdev_port_attr_get() function to return SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after commit bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID"). Fixes: bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID") Acked-by: Jiri Pirko <jiri@mellanox.com> Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- Documentation/networking/switchdev.txt | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt index f3244d87512a..ea90243340a9 100644 --- a/Documentation/networking/switchdev.txt +++ b/Documentation/networking/switchdev.txt @@ -92,11 +92,11 @@ device. Switch ID ^^^^^^^^^ -The switchdev driver must implement the switchdev op switchdev_port_attr_get -for SWITCHDEV_ATTR_ID_PORT_PARENT_ID for each port netdev, returning the same -physical ID for each port of a switch. The ID must be unique between switches -on the same system. The ID does not need to be unique between switches on -different systems. +The switchdev driver must implement the net_device operation +ndo_get_port_parent_id for each port netdev, returning the same physical ID for +each port of a switch. The ID must be unique between switches on the same +system. The ID does not need to be unique between switches on different +systems. The switch ID is used to locate ports on a switch and to know if aggregated ports belong to the same switch. -- 2.17.1
next prev parent reply other threads:[~2019-02-11 19:10 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-02-11 19:09 [PATCH net-next v4 0/9] net: Remove switchdev_ops Florian Fainelli 2019-02-11 19:09 ` [Bridge] " Florian Fainelli 2019-02-11 19:09 ` Florian Fainelli [this message] 2019-02-11 19:09 ` [Bridge] [PATCH net-next v4 1/9] Documentation: networking: switchdev: Update port parent ID section Florian Fainelli 2019-02-12 12:19 ` Ido Schimmel 2019-02-12 12:19 ` [Bridge] " Ido Schimmel 2019-02-11 19:09 ` [PATCH net-next v4 2/9] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET Florian Fainelli 2019-02-11 19:09 ` [Bridge] " Florian Fainelli 2019-02-12 13:55 ` Ido Schimmel 2019-02-12 13:55 ` [Bridge] " Ido Schimmel 2019-02-11 19:09 ` [PATCH net-next v4 3/9] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET Florian Fainelli 2019-02-11 19:09 ` [Bridge] " Florian Fainelli 2019-02-11 19:09 ` [PATCH net-next v4 4/9] mlxsw: spectrum_switchdev: " Florian Fainelli 2019-02-11 19:09 ` [Bridge] " Florian Fainelli 2019-02-12 14:07 ` Ido Schimmel 2019-02-12 14:07 ` [Bridge] " Ido Schimmel 2019-02-11 19:09 ` [PATCH net-next v4 5/9] net: mscc: ocelot: " Florian Fainelli 2019-02-11 19:09 ` [Bridge] " Florian Fainelli 2019-02-11 19:09 ` [PATCH net-next v4 6/9] staging: fsl-dpaa2: ethsw: " Florian Fainelli 2019-02-11 19:09 ` [Bridge] " Florian Fainelli 2019-02-11 19:09 ` [PATCH net-next v4 7/9] net: dsa: " Florian Fainelli 2019-02-11 19:09 ` [Bridge] " Florian Fainelli 2019-02-11 19:10 ` [PATCH net-next v4 8/9] net: switchdev: Replace port attr get/set SDO with a notification Florian Fainelli 2019-02-11 19:10 ` [Bridge] " Florian Fainelli 2019-02-11 19:10 ` [PATCH net-next v4 9/9] net: Remove switchdev_ops Florian Fainelli 2019-02-11 19:10 ` [Bridge] " Florian Fainelli 2019-02-12 14:10 ` Ido Schimmel 2019-02-12 14:10 ` [Bridge] " Ido Schimmel 2019-02-11 20:16 ` [PATCH net-next v4 0/9] " David Miller 2019-02-11 20:16 ` [Bridge] " David Miller 2019-02-11 21:40 ` Ido Schimmel 2019-02-11 21:40 ` [Bridge] " Ido Schimmel 2019-02-12 13:14 ` Ido Schimmel 2019-02-12 13:14 ` [Bridge] " Ido Schimmel 2019-02-12 13:53 ` Jiri Pirko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20190211191001.8623-2-f.fainelli@gmail.com \ --to=f.fainelli@gmail.com \ --cc=andrew@lunn.ch \ --cc=bridge@lists.linux-foundation.org \ --cc=davem@davemloft.net \ --cc=devel@driverdev.osuosl.org \ --cc=idosch@mellanox.com \ --cc=jiri@mellanox.com \ --cc=linux-kernel@vger.kernel.org \ --cc=netdev@vger.kernel.org \ --cc=vivien.didelot@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.