* [Buildroot] [PATCH v3] zbar: bump version to 0.22
@ 2019-03-08 22:19 Peter Seiderer
2019-03-09 13:24 ` Thomas Petazzoni
0 siblings, 1 reply; 3+ messages in thread
From: Peter Seiderer @ 2019-03-08 22:19 UTC (permalink / raw)
To: buildroot
- change from git download to official release and
download site (drop need for autoreconf)
- drop dependency on kernel headers >= 3.17 (should be fixed with
commit 'v4l2: make ZBar build and run on Kernels < 3.16' (see [1]),
propagate removal to gst-plugins-bad
[1] https://git.linuxtv.org/zbar.git/commit/?id=fa5c48127ec1e3670e28540c2e6a03431ebac5b8
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
Changes v1 -> v2:
- rebased on current master
Changes v2 -> v3:
- propagate removal of header dependency to gst-plugins-bad
(suggested by Thomas Petazzoni)
Note:
Previous commit dd08ca7aa98209222a077d1db97323bbc3b563b2 lifted the
kernel headers dependency from >= 3.0 to >= 3.17, a complete
test-pkg run without headers dependency showed no error, so
remove the kernel headers dependency...
---
package/gstreamer/gst-plugins-bad/Config.in | 6 ++----
package/zbar/Config.in | 6 ++----
package/zbar/zbar.hash | 2 +-
package/zbar/zbar.mk | 6 +++---
4 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/package/gstreamer/gst-plugins-bad/Config.in b/package/gstreamer/gst-plugins-bad/Config.in
index 411e4b6174..39139c0458 100644
--- a/package/gstreamer/gst-plugins-bad/Config.in
+++ b/package/gstreamer/gst-plugins-bad/Config.in
@@ -321,12 +321,10 @@ config BR2_PACKAGE_GST_PLUGINS_BAD_ZBAR
depends on BR2_TOOLCHAIN_HAS_THREADS # zbar-> libv4l
depends on BR2_USE_MMU # zbar-> libv4l
depends on BR2_INSTALL_LIBSTDCPP # zbar-> libv4l
- depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # zbar
select BR2_PACKAGE_ZBAR
-comment "zbar plugin needs a toolchain w/ threads, C++ and headers >= 3.17"
+comment "zbar plugin needs a toolchain w/ threads, C++"
depends on BR2_USE_MMU
- depends on !BR2_TOOLCHAIN_HAS_THREADS \
- || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
endif
diff --git a/package/zbar/Config.in b/package/zbar/Config.in
index e850c1f02b..e0b28365fc 100644
--- a/package/zbar/Config.in
+++ b/package/zbar/Config.in
@@ -3,7 +3,6 @@ config BR2_PACKAGE_ZBAR
depends on BR2_TOOLCHAIN_HAS_THREADS # libv4l
depends on BR2_USE_MMU # libv4l
depends on BR2_INSTALL_LIBSTDCPP # libv4l
- depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17 # v4l2_query_ext_ctrl
select BR2_PACKAGE_JPEG
select BR2_PACKAGE_LIBV4L
help
@@ -11,7 +10,6 @@ config BR2_PACKAGE_ZBAR
https://git.linuxtv.org/zbar.git/about/
-comment "zbar needs a toolchain w/ threads, C++ and headers >= 3.17"
+comment "zbar needs a toolchain w/ threads, C++"
depends on BR2_USE_MMU
- depends on !BR2_TOOLCHAIN_HAS_THREADS \
- || !BR2_INSTALL_LIBSTDCPP || !BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
+ depends on !BR2_TOOLCHAIN_HAS_THREADS || !BR2_INSTALL_LIBSTDCPP
diff --git a/package/zbar/zbar.hash b/package/zbar/zbar.hash
index 47a080af12..0f44d0f5c0 100644
--- a/package/zbar/zbar.hash
+++ b/package/zbar/zbar.hash
@@ -1,3 +1,3 @@
# Locally computed:
-sha256 7eb73c180c787184ede0f98806c52b23eb9c24609673e1ed51210504ea2937f5 zbar-681b0f305fb5c5bb0df8437f7d740b29a93a7889.tar.gz
+sha256 1ba9e94c7217a8bd3800f9f3abddf3ed393a62cdf141a709765aad2788744eb7 zbar-0.22.tar.bz2
sha256 36b6d3fa47916943fd5fec313c584784946047ec1337a78b440e5992cb595f89 LICENSE
diff --git a/package/zbar/zbar.mk b/package/zbar/zbar.mk
index 2146aee85b..63220774b9 100644
--- a/package/zbar/zbar.mk
+++ b/package/zbar/zbar.mk
@@ -4,12 +4,12 @@
#
################################################################################
-ZBAR_VERSION = 681b0f305fb5c5bb0df8437f7d740b29a93a7889
-ZBAR_SITE = git://linuxtv.org/zbar.git
+ZBAR_VERSION = 0.22
+ZBAR_SOURCE = zbar-$(ZBAR_VERSION).tar.bz2
+ZBAR_SITE = https://www.linuxtv.org/downloads/zbar
ZBAR_LICENSE = LGPL-2.1+
ZBAR_LICENSE_FILES = LICENSE
ZBAR_INSTALL_STAGING = YES
-ZBAR_AUTORECONF = YES
ZBAR_DEPENDENCIES = libv4l jpeg
# add host-gettext for AM_ICONV macro
ZBAR_DEPENDENCIES += host-gettext
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v3] zbar: bump version to 0.22
2019-03-08 22:19 [Buildroot] [PATCH v3] zbar: bump version to 0.22 Peter Seiderer
@ 2019-03-09 13:24 ` Thomas Petazzoni
2019-03-09 20:38 ` Peter Seiderer
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Petazzoni @ 2019-03-09 13:24 UTC (permalink / raw)
To: buildroot
Hello Peter,
On Fri, 8 Mar 2019 23:19:47 +0100
Peter Seiderer <ps.report@gmx.net> wrote:
> - change from git download to official release and
> download site (drop need for autoreconf)
>
> - drop dependency on kernel headers >= 3.17 (should be fixed with
> commit 'v4l2: make ZBar build and run on Kernels < 3.16' (see [1]),
> propagate removal to gst-plugins-bad
>
> [1] https://git.linuxtv.org/zbar.git/commit/?id=fa5c48127ec1e3670e28540c2e6a03431ebac5b8
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
I didn't pay attention, but in fact this is still not correct.
zbar selects libv4l, and libv4l has a dependency on headers >= 3.0. So
zbar should keep a dependency on >= 3.0, and so should the
gst-plugins-bad zbar option. Otherwise, you can enable zbar on < 3.0
headers, but libv4l is not selectable, violating the kconfig
correctness of the configuration.
Conclusion: we need a headers >= 3.0 dependency on zbar and the
gst-plugins-bad zbar option.
Could you fix this and resend ?
Thanks a lot!
Thomas Petazzoni
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH v3] zbar: bump version to 0.22
2019-03-09 13:24 ` Thomas Petazzoni
@ 2019-03-09 20:38 ` Peter Seiderer
0 siblings, 0 replies; 3+ messages in thread
From: Peter Seiderer @ 2019-03-09 20:38 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Sat, 9 Mar 2019 14:24:12 +0100, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Peter,
>
> On Fri, 8 Mar 2019 23:19:47 +0100
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > - change from git download to official release and
> > download site (drop need for autoreconf)
> >
> > - drop dependency on kernel headers >= 3.17 (should be fixed with
> > commit 'v4l2: make ZBar build and run on Kernels < 3.16' (see [1]),
> > propagate removal to gst-plugins-bad
> >
> > [1] https://git.linuxtv.org/zbar.git/commit/?id=fa5c48127ec1e3670e28540c2e6a03431ebac5b8
> >
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
>
> I didn't pay attention, but in fact this is still not correct.
>
> zbar selects libv4l, and libv4l has a dependency on headers >= 3.0. So
> zbar should keep a dependency on >= 3.0, and so should the
> gst-plugins-bad zbar option. Otherwise, you can enable zbar on < 3.0
> headers, but libv4l is not selectable, violating the kconfig
> correctness of the configuration.
>
> Conclusion: we need a headers >= 3.0 dependency on zbar and the
> gst-plugins-bad zbar option.
O.k.
>
> Could you fix this and resend ?
Yes, updated patch will follow....
Regards,
Peter
>
> Thanks a lot!
>
> Thomas Petazzoni
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-09 20:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-08 22:19 [Buildroot] [PATCH v3] zbar: bump version to 0.22 Peter Seiderer
2019-03-09 13:24 ` Thomas Petazzoni
2019-03-09 20:38 ` Peter Seiderer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.