* [virtio] [PATCH] signal start and end of structures consistently
@ 2019-03-11 15:50 Michael S. Tsirkin
2019-03-11 16:00 ` Cornelia Huck
0 siblings, 1 reply; 2+ messages in thread
From: Michael S. Tsirkin @ 2019-03-11 15:50 UTC (permalink / raw)
To: virtio, virtio-dev
Make sure all structs have the format:
struct X [
...
];
VIRTIO-170
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
content.tex | 11 +++++------
virtio-gpu.tex | 2 +-
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/content.tex b/content.tex
index 4180296..f40d4fc 100644
--- a/content.tex
+++ b/content.tex
@@ -5272,8 +5272,7 @@ The following commands are defined:
#define VIRTIO_SCSI_T_TMF_QUERY_TASK 6
#define VIRTIO_SCSI_T_TMF_QUERY_TASK_SET 7
-struct virtio_scsi_ctrl_tmf
-{
+struct virtio_scsi_ctrl_tmf {
// Device-readable part
le32 type;
le32 subtype;
@@ -5281,7 +5280,7 @@ struct virtio_scsi_ctrl_tmf
le64 id;
// Device-writable part
u8 response;
-}
+};
/* command-specific response values */
#define VIRTIO_SCSI_S_FUNCTION_COMPLETE 0
@@ -5328,7 +5327,7 @@ struct virtio_scsi_ctrl_an {
// Device-writable part
le32 event_actual;
u8 response;
-}
+};
#define VIRTIO_SCSI_EVT_ASYNC_OPERATIONAL_CHANGE 2
#define VIRTIO_SCSI_EVT_ASYNC_POWER_MGMT 4
@@ -5363,7 +5362,7 @@ struct virtio_scsi_ctrl_an {
// Device-writable part
le32 event_actual;
u8 response;
-}
+};
\end{lstlisting}
By sending this command, the driver asks the specified LUN to
@@ -5415,7 +5414,7 @@ struct virtio_scsi_event {
le32 event;
u8 lun[8];
le32 reason;
-}
+};
\end{lstlisting}
The devices sets bit 31 in \field{event} to report lost events
diff --git a/virtio-gpu.tex b/virtio-gpu.tex
index 0cf2209..992d4e6 100644
--- a/virtio-gpu.tex
+++ b/virtio-gpu.tex
@@ -47,7 +47,7 @@ struct virtio_gpu_config {
le32 events_clear;
le32 num_scanouts;
le32 reserved;
-}
+};
\end{lstlisting}
\subsubsection{Device configuration fields}
--
MST
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [virtio] [PATCH] signal start and end of structures consistently
2019-03-11 15:50 [virtio] [PATCH] signal start and end of structures consistently Michael S. Tsirkin
@ 2019-03-11 16:00 ` Cornelia Huck
0 siblings, 0 replies; 2+ messages in thread
From: Cornelia Huck @ 2019-03-11 16:00 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: virtio, virtio-dev
On Mon, 11 Mar 2019 11:50:00 -0400
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> Make sure all structs have the format:
>
> struct X [
> ...
> ];
[] or {}?
(either will work, I guess)
>
> VIRTIO-170
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> content.tex | 11 +++++------
> virtio-gpu.tex | 2 +-
> 2 files changed, 6 insertions(+), 7 deletions(-)
>
> diff --git a/content.tex b/content.tex
> index 4180296..f40d4fc 100644
> --- a/content.tex
> +++ b/content.tex
> @@ -5272,8 +5272,7 @@ The following commands are defined:
> #define VIRTIO_SCSI_T_TMF_QUERY_TASK 6
> #define VIRTIO_SCSI_T_TMF_QUERY_TASK_SET 7
>
> -struct virtio_scsi_ctrl_tmf
> -{
> +struct virtio_scsi_ctrl_tmf {
> // Device-readable part
> le32 type;
> le32 subtype;
> @@ -5281,7 +5280,7 @@ struct virtio_scsi_ctrl_tmf
> le64 id;
> // Device-writable part
> u8 response;
> -}
> +};
>
> /* command-specific response values */
> #define VIRTIO_SCSI_S_FUNCTION_COMPLETE 0
> @@ -5328,7 +5327,7 @@ struct virtio_scsi_ctrl_an {
> // Device-writable part
> le32 event_actual;
> u8 response;
> -}
> +};
>
> #define VIRTIO_SCSI_EVT_ASYNC_OPERATIONAL_CHANGE 2
> #define VIRTIO_SCSI_EVT_ASYNC_POWER_MGMT 4
> @@ -5363,7 +5362,7 @@ struct virtio_scsi_ctrl_an {
> // Device-writable part
> le32 event_actual;
> u8 response;
> -}
> +};
> \end{lstlisting}
>
> By sending this command, the driver asks the specified LUN to
> @@ -5415,7 +5414,7 @@ struct virtio_scsi_event {
> le32 event;
> u8 lun[8];
> le32 reason;
> -}
> +};
> \end{lstlisting}
>
> The devices sets bit 31 in \field{event} to report lost events
> diff --git a/virtio-gpu.tex b/virtio-gpu.tex
> index 0cf2209..992d4e6 100644
> --- a/virtio-gpu.tex
> +++ b/virtio-gpu.tex
> @@ -47,7 +47,7 @@ struct virtio_gpu_config {
> le32 events_clear;
> le32 num_scanouts;
> le32 reserved;
> -}
> +};
> \end{lstlisting}
>
> \subsubsection{Device configuration fields}
---------------------------------------------------------------------
To unsubscribe from this mail list, you must leave the OASIS TC that
generates this mail. Follow this link to all your TCs in OASIS at:
https://www.oasis-open.org/apps/org/workgroup/portal/my_workgroups.php
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-11 16:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-11 15:50 [virtio] [PATCH] signal start and end of structures consistently Michael S. Tsirkin
2019-03-11 16:00 ` Cornelia Huck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.